3c02842f2e
This patch adds a new (optional) attribute to TURN_ALLOCATE_REQUEST, TURN_LOGGING_ID (0xFF05). The attribute is put into the comprehension-optional range so that a TURN server should ignore it if it doesn't know if. https://tools.ietf.org/html/rfc5389#section-18.2 The intended usage of this attribute is to correlate client and backend logs. Bug: webrtc:10897 Change-Id: I51fdbe15f9025e817cd91ee8e2c3355133212daa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149829 Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28966}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.