
Replace the two versions with a single DownConvertToCodecFormat. As mentioned in comments, this could be further consolidated with RemixAndResample but we should write a full audio converter class in that case. Along the way: - Fix the bug present in Channel::Demultiplex with mono input and a stereo codec. - Remove the 32 kHz max from the OnDataAvailable path. This avoids a 48 -> 32 -> 48 conversion when VoE is passed 48 kHz audio; instead we get a straight pass-through to ACM. The 32 kHz conversion is still needed in the RecordedDataIsAvailable path until APM natively supports 48 kHz. - Merge resampler improvements from ACM1 to ACM2. This allows ACM to handle 44.1 kHz audio passed to VoE and was originally done here: https://webrtc-codereview.appspot.com/1590004 - Reuse the RemixAndResample unit tests for DownConvertToCodecFormat. - Remove unused functions from utility.cc. BUG=3155,3000,b/12867572 TESTED=voe_cmd_test using both the OnDataAvailable and RecordedDataIsAvailable paths, with a captured audio format of all combinations of {44.1,48} kHz and {1,2} channels, running through all codecs, and finally using both ACM1 and ACM2. R=henrika@webrtc.org, turaj@webrtc.org, xians@webrtc.org Review URL: https://webrtc-codereview.appspot.com/11019005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@5843 4adac7df-926f-26a2-2b94-8c16560cd09d
57 lines
1.8 KiB
C++
57 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "webrtc/modules/audio_coding/main/acm2/acm_resampler.h"
|
|
|
|
#include <string.h>
|
|
|
|
#include "webrtc/common_audio/resampler/include/resampler.h"
|
|
#include "webrtc/system_wrappers/interface/logging.h"
|
|
|
|
namespace webrtc {
|
|
namespace acm2 {
|
|
|
|
ACMResampler::ACMResampler() {
|
|
}
|
|
|
|
ACMResampler::~ACMResampler() {
|
|
}
|
|
|
|
int ACMResampler::Resample10Msec(const int16_t* in_audio,
|
|
int in_freq_hz,
|
|
int out_freq_hz,
|
|
int num_audio_channels,
|
|
int16_t* out_audio) {
|
|
int in_length = in_freq_hz * num_audio_channels / 100;
|
|
int out_length = out_freq_hz * num_audio_channels / 100;
|
|
if (in_freq_hz == out_freq_hz) {
|
|
memcpy(out_audio, in_audio, in_length * sizeof(int16_t));
|
|
return in_length / num_audio_channels;
|
|
}
|
|
|
|
if (resampler_.InitializeIfNeeded(in_freq_hz, out_freq_hz,
|
|
num_audio_channels) != 0) {
|
|
LOG_FERR3(LS_ERROR, InitializeIfNeeded, in_freq_hz, out_freq_hz,
|
|
num_audio_channels);
|
|
return -1;
|
|
}
|
|
|
|
out_length = resampler_.Resample(in_audio, in_length, out_audio, out_length);
|
|
if (out_length == -1) {
|
|
LOG_FERR4(LS_ERROR, Resample, in_audio, in_length, out_audio, out_length);
|
|
return -1;
|
|
}
|
|
|
|
return out_length / num_audio_channels;
|
|
}
|
|
|
|
} // namespace acm2
|
|
} // namespace webrtc
|