zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
43e7d3bc150788045b549f4ab94a91095980d059
platform-external-webrtc/webrtc/modules/rtp_rtcp/source
History
noahric 43e7d3bc15 Avoid overflow in checking for emulation bytes in rbsp. 
Also fixed an arithmetic issue where a 0 0 3 at the end of the rbsp would include the 3 (that's not a legal bitstream anyway, so it probably wasn't a real bug, but it was incorrect).

This maintains the underflow fix from an earlier CL (https://codereview.webrtc.org/1219493004/). The overflow fix is virtually impossible to hit (hence no unit tests), but is there for strict correctness.

BUG=

Review URL: https://codereview.webrtc.org/1226203002

Cr-Commit-Position: refs/heads/master@{#9581}
2015-07-14 17:45:07 +00:00
..
mock
Some refactoring inside rtp_rtcp/.
2014-07-08 12:10:51 +00:00
bitrate.cc
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
bitrate.h
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
byte_io_unittest.cc
Make sure ByteReader<T>::Read* is properly constified.
2015-01-28 12:38:16 +00:00
byte_io.h
Make sure ByteReader<T>::Read* is properly constified.
2015-01-28 12:38:16 +00:00
dtmf_queue.cc
Remove potential deadlock in RTPSenderAudio.
2015-02-12 12:20:50 +00:00
dtmf_queue.h
Formatted dtmf_queue.
2013-05-08 10:04:06 +00:00
fec_private_tables_bursty.h
Include files from webrtc/.. paths in rtp_rtcp/
2013-05-29 14:27:38 +00:00
fec_private_tables_random.h
Include files from webrtc/.. paths in rtp_rtcp/
2013-05-29 14:27:38 +00:00
fec_receiver_impl.cc
Prevent OOB reads in FEC packets without complete RED headers.
2015-06-30 08:32:47 +00:00
fec_receiver_impl.h
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
fec_receiver_unittest.cc
Prevent heap overflows for incorrect FEC packet lengths.
2015-07-06 10:09:15 +00:00
fec_test_helper.cc
Use ByteReader/ByteWriter instead of rtputility and manual shift/add.
2015-03-17 16:44:54 +00:00
fec_test_helper.h
Misc. cleanup split out of https://webrtc-codereview.appspot.com/37699004/ :
2015-02-23 21:29:45 +00:00
forward_error_correction_internal.cc
Switch C++-style C headers with their C equivalents.
2013-08-05 16:22:53 +00:00
forward_error_correction_internal.h
Add include guards to forward_error_correction_internal.h
2013-12-24 05:06:12 +00:00
forward_error_correction.cc
Prevent heap overflows for incorrect FEC packet lengths.
2015-07-06 10:09:15 +00:00
forward_error_correction.h
Prevent heap overflows for incorrect FEC packet lengths.
2015-07-06 10:09:15 +00:00
h264_sps_parser_unittest.cc
Fixed incorrect RBSP parsing. The original version would eat 0x3 as an emulation byte in places where it shouldn't, whereas the real parsing is only supposed to eat 0x3 preceded by 0x0 0x0.
2015-04-29 00:55:43 +00:00
h264_sps_parser.cc
Avoid overflow in checking for emulation bytes in rbsp.
2015-07-14 17:45:07 +00:00
h264_sps_parser.h
Add h.264 AVC SPS parsing for resolution (re-land)
2015-04-24 11:56:44 +00:00
nack_rtx_unittest.cc
Support handling multiple RTX but only generate SDP with RTX associated with VP8.
2015-04-21 12:25:42 +00:00
OWNERS
Make everyone an OWNER for .gyp/.gypi add/delete purposes, non-talk/ edition.
2014-04-14 20:08:03 +00:00
packet_loss_stats_unittest.cc
Add statistics gathering for packet loss.
2015-07-11 01:10:08 +00:00
packet_loss_stats.cc
Add statistics gathering for packet loss.
2015-07-11 01:10:08 +00:00
packet_loss_stats.h
Add statistics gathering for packet loss.
2015-07-11 01:10:08 +00:00
producer_fec_unittest.cc
Reland "Avoid critsect for protection- and qm setting callbacks in
2015-04-14 19:28:03 +00:00
producer_fec.cc
Reland "Avoid critsect for protection- and qm setting callbacks in
2015-04-14 19:28:03 +00:00
producer_fec.h
Reland "Avoid critsect for protection- and qm setting callbacks in
2015-04-14 19:28:03 +00:00
receive_statistics_impl.cc
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
receive_statistics_impl.h
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
receive_statistics_unittest.cc
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
remote_ntp_time_estimator_unittest.cc
Use int64_t more consistently for times, in particular for RTT values.
2015-01-12 21:51:21 +00:00
remote_ntp_time_estimator.cc
Use int64_t more consistently for times, in particular for RTT values.
2015-01-12 21:51:21 +00:00
rtcp_format_remb_unittest.cc
Remove MimdRateControl and factories for RemoteBitrateEstimor.
2015-07-06 08:51:01 +00:00
rtcp_packet_unittest.cc
Use RtcpPacket classes for SenderReport/ReceiveReport in RTCPSender
2015-06-22 13:21:40 +00:00
rtcp_packet.cc
Use RtcpPacket classes for SenderReport/ReceiveReport in RTCPSender
2015-06-22 13:21:40 +00:00
rtcp_packet.h
Use RtcpPacket classes for SenderReport/ReceiveReport in RTCPSender
2015-06-22 13:21:40 +00:00
rtcp_receiver_help.cc
Added support for sending and receiving RTCP XR packets:
2013-10-02 13:15:34 +00:00
rtcp_receiver_help.h
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
rtcp_receiver_unittest.cc
Remove MimdRateControl and factories for RemoteBitrateEstimor.
2015-07-06 08:51:01 +00:00
rtcp_receiver.cc
Refactor RTCP sender
2015-05-11 08:17:46 +00:00
rtcp_receiver.h
Prevent sender RTCP signals for receive-only channels.
2015-04-23 15:52:58 +00:00
rtcp_sender_unittest.cc
Remove MimdRateControl and factories for RemoteBitrateEstimor.
2015-07-06 08:51:01 +00:00
rtcp_sender.cc
Send Sdes using RtcpPacket
2015-06-25 12:46:23 +00:00
rtcp_sender.h
Send Sdes using RtcpPacket
2015-06-25 12:46:23 +00:00
rtcp_utility_unittest.cc
Add stats for duplicate sent and received NACK requests.
2014-10-29 12:42:30 +00:00
rtcp_utility.cc
Refactor RTCP sender
2015-05-11 08:17:46 +00:00
rtcp_utility.h
Refactor RTCP sender
2015-05-11 08:17:46 +00:00
rtp_fec_unittest.cc
Use ByteReader/ByteWriter instead of rtputility and manual shift/add.
2015-03-17 16:44:54 +00:00
rtp_format_h264_unittest.cc
Prevent size_t underflow in H264 SPS parsing.
2015-07-01 10:00:20 +00:00
rtp_format_h264.cc
Prevent OOB read on truncated H264 headers.
2015-06-30 15:23:42 +00:00
rtp_format_h264.h
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
rtp_format_video_generic.cc
Prevent OOB reads for zero-length H264 payloads.
2015-06-30 12:09:47 +00:00
rtp_format_video_generic.h
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
rtp_format_vp8_test_helper.cc
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
rtp_format_vp8_test_helper.h
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
rtp_format_vp8_unittest.cc
Prevent depacketizer OOB reads on zero-length VP8 payload.
2015-06-30 09:12:09 +00:00
rtp_format_vp8.cc
Prevent depacketizer OOB reads on zero-length VP8 payload.
2015-06-30 09:12:09 +00:00
rtp_format_vp8.h
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
rtp_format.cc
Remove callback from RtpDepacketizer::Parse().
2014-09-29 08:00:22 +00:00
rtp_format.h
Remove partially defined WebRtcRTPHeader from Parse().
2014-11-07 11:02:12 +00:00
rtp_header_extension_unittest.cc
Enable CVO by default through webrtc pipeline.
2015-04-01 22:33:15 +00:00
rtp_header_extension.cc
Enable CVO by default through webrtc pipeline.
2015-04-01 22:33:15 +00:00
rtp_header_extension.h
Enable CVO by default through webrtc pipeline.
2015-04-01 22:33:15 +00:00
rtp_header_parser.cc
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
rtp_packet_history_unittest.cc
Fixed potential crash if rtp packet history is completely full.
2015-02-02 13:08:14 +00:00
rtp_packet_history.cc
Fixed potential crash if rtp packet history is completely full.
2015-02-02 13:08:14 +00:00
rtp_packet_history.h
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
rtp_payload_registry_unittest.cc
Register sample rate of Audio RED in RTPPayloadRegistry.
2015-03-25 15:11:34 +00:00
rtp_payload_registry.cc
Fail RTP parsing on excessive padding length.
2015-07-01 12:35:56 +00:00
rtp_receiver_audio.cc
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
rtp_receiver_audio.h
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
rtp_receiver_impl.cc
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
rtp_receiver_impl.h
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
rtp_receiver_strategy.cc
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
rtp_receiver_strategy.h
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
rtp_receiver_video.cc
Fail RTP parsing on excessive padding length.
2015-07-01 12:35:56 +00:00
rtp_receiver_video.h
Removing private and unused method in RTPReceiver.
2015-03-09 11:54:45 +00:00
rtp_rtcp_config.h
Use int64_t for milliseconds more often, primarily for TimeUntilNextProcess.
2014-12-15 22:09:40 +00:00
rtp_rtcp_impl_unittest.cc
Add support for fragmentation in RtcpPacket.
2015-06-08 07:54:24 +00:00
rtp_rtcp_impl.cc
Merge methods for configuring NACK/FEC/hybrid.
2015-07-14 16:36:37 +00:00
rtp_rtcp_impl.h
Merge methods for configuring NACK/FEC/hybrid.
2015-07-14 16:36:37 +00:00
rtp_sender_audio.cc
Use ByteReader/ByteWriter instead of rtputility and manual shift/add.
2015-03-17 16:44:54 +00:00
rtp_sender_audio.h
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
rtp_sender_unittest.cc
Fail RTP parsing on excessive padding length.
2015-07-01 12:35:56 +00:00
rtp_sender_video.cc
Reland "Avoid critsect for protection- and qm setting callbacks in
2015-04-14 19:28:03 +00:00
rtp_sender_video.h
Reland "Avoid critsect for protection- and qm setting callbacks in
2015-04-14 19:28:03 +00:00
rtp_sender.cc
Merge methods for configuring NACK/FEC/hybrid.
2015-07-14 16:36:37 +00:00
rtp_sender.h
Merge methods for configuring NACK/FEC/hybrid.
2015-07-14 16:36:37 +00:00
rtp_utility.cc
Fail RTP parsing on excessive padding length.
2015-07-01 12:35:56 +00:00
rtp_utility.h
Use ByteReader/ByteWriter instead of rtputility and manual shift/add.
2015-03-17 16:44:54 +00:00
ssrc_database.cc
Remove remains of WEBRTC_NO_STL.
2014-07-22 06:48:58 +00:00
ssrc_database.h
Remove remains of WEBRTC_NO_STL.
2014-07-22 06:48:58 +00:00
tmmbr_help.cc
Landing pkasting's webrtc fixes for MSVC level 4 warnings in WebRTC.
2014-07-11 19:09:59 +00:00
tmmbr_help.h
Sorted headers under rtp_rtcp/.
2013-07-10 15:40:42 +00:00
video_codec_information.h
Proper spacing for end-of-namespace comments.
2013-07-03 15:12:26 +00:00
vp8_partition_aggregator_unittest.cc
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
vp8_partition_aggregator.cc
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
vp8_partition_aggregator.h
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00