45b35d442d
These metrics were not only non-standard, but residing in the non-standard "track" stats object that we want to delete. As per https://github.com/w3c/webrtc-stats/issues/695#issuecomment-1259611462 these metrics are no longer needed because we already have inbound-rtp.totalInterFrameDelay/totalSquaredInterFrameDelay which is basically the same thing. // mac_rel infra failures are unrelated NOTRY=True Bug: webrtc:14522 Change-Id: I565da42514a93f15532ba8357dd006547a5296ee Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278100 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38509}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.