437d129ef5
The ERLE is used to estimate residual echo for echo suppression. The ERLE is reduced during far-end offset to avoid echo leakage. When there is a strong near-end present this can cause unnecessary transparency loss. This change adds an ERLE estimation that does not compensate for onsets and uses it for residual echo estimation when the suppressor considers the near-end to be dominant. Bug: webrtc:12686 Change-Id: Ida78eeacf1f95c6e62403f86ba3f2ff055898a84 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215323 Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33786}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.