4fe660785b
GetCroppingWindowRect() is too generic and easy to be misused. For example, in WindowCapturerWin, it's used to calculate the DesktopRect of the target window, which is inaccurate. See the screenshot in the bug, it wrongly crops borders on Windows 8+. So GetCroppingWindowRect() should be removed eventually, the logic should be placed in CroppingWindowCapturerWin. But since it's still used in the deprecated logic in MouseCursorMonitorWin, I would prefer to remove this function after MouseCursorMonitor improvement has been finished. But before that, WindowCapturerWin should use GetWindowDrawableRect() instead of GetCroppedWindowRect() to avoid the wrongly cropping behavior on Windows 8+. Bug: webrtc:8157 Change-Id: I012b663dced8105623c563dbe55ffcb8d7f17f75 Reviewed-on: https://chromium-review.googlesource.com/642092 Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#19614}
Name: WebRTC URL: http://www.webrtc.org Version: 90 License: BSD License File: LICENSE Description: WebRTC provides real time voice and video processing functionality to enable the implementation of PeerConnection/MediaStream. Third party code used in this project is described in the file LICENSE_THIRD_PARTY.