Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.
Not inlining virtual functions with simple bodies such as
{ return false; }
strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.
BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47429004
Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
49 lines
1.3 KiB
Objective-C
49 lines
1.3 KiB
Objective-C
/*
|
|
* Copyright 2007 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
// A libjingle compatible SocketServer for OSX/iOS/Cocoa.
|
|
|
|
#ifndef WEBRTC_BASE_MACCOCOASOCKETSERVER_H_
|
|
#define WEBRTC_BASE_MACCOCOASOCKETSERVER_H_
|
|
|
|
#include "webrtc/base/macsocketserver.h"
|
|
|
|
#ifdef __OBJC__
|
|
@class NSTimer, MacCocoaSocketServerHelperRtc;
|
|
#else
|
|
class NSTimer;
|
|
class MacCocoaSocketServerHelperRtc;
|
|
#endif
|
|
|
|
namespace rtc {
|
|
|
|
// A socketserver implementation that wraps the main cocoa
|
|
// application loop accessed through [NSApp run].
|
|
class MacCocoaSocketServer : public MacBaseSocketServer {
|
|
public:
|
|
explicit MacCocoaSocketServer();
|
|
~MacCocoaSocketServer() override;
|
|
|
|
bool Wait(int cms, bool process_io) override;
|
|
void WakeUp() override;
|
|
|
|
private:
|
|
MacCocoaSocketServerHelperRtc* helper_;
|
|
NSTimer* timer_; // Weak.
|
|
// The count of how many times we're inside the NSApplication main loop.
|
|
int run_count_;
|
|
|
|
DISALLOW_EVIL_CONSTRUCTORS(MacCocoaSocketServer);
|
|
};
|
|
|
|
} // namespace rtc
|
|
|
|
#endif // WEBRTC_BASE_MACCOCOASOCKETSERVER_H_
|