Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.
Not inlining virtual functions with simple bodies such as
{ return false; }
strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.
BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47429004
Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
105 lines
3.2 KiB
C++
105 lines
3.2 KiB
C++
/*
|
|
* Copyright 2004 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_BASE_ASYNCHTTPREQUEST_H_
|
|
#define WEBRTC_BASE_ASYNCHTTPREQUEST_H_
|
|
|
|
#include <string>
|
|
#include "webrtc/base/event.h"
|
|
#include "webrtc/base/httpclient.h"
|
|
#include "webrtc/base/signalthread.h"
|
|
#include "webrtc/base/socketpool.h"
|
|
#include "webrtc/base/sslsocketfactory.h"
|
|
|
|
namespace rtc {
|
|
|
|
class FirewallManager;
|
|
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
// AsyncHttpRequest
|
|
// Performs an HTTP request on a background thread. Notifies on the foreground
|
|
// thread once the request is done (successfully or unsuccessfully).
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
|
|
class AsyncHttpRequest : public SignalThread {
|
|
public:
|
|
explicit AsyncHttpRequest(const std::string &user_agent);
|
|
~AsyncHttpRequest() override;
|
|
|
|
// If start_delay is less than or equal to zero, this starts immediately.
|
|
// Start_delay defaults to zero.
|
|
int start_delay() const { return start_delay_; }
|
|
void set_start_delay(int delay) { start_delay_ = delay; }
|
|
|
|
const ProxyInfo& proxy() const { return proxy_; }
|
|
void set_proxy(const ProxyInfo& proxy) {
|
|
proxy_ = proxy;
|
|
}
|
|
void set_firewall(FirewallManager * firewall) {
|
|
firewall_ = firewall;
|
|
}
|
|
|
|
// The DNS name of the host to connect to.
|
|
const std::string& host() { return host_; }
|
|
void set_host(const std::string& host) { host_ = host; }
|
|
|
|
// The port to connect to on the target host.
|
|
int port() { return port_; }
|
|
void set_port(int port) { port_ = port; }
|
|
|
|
// Whether the request should use SSL.
|
|
bool secure() { return secure_; }
|
|
void set_secure(bool secure) { secure_ = secure; }
|
|
|
|
// Time to wait on the download, in ms.
|
|
int timeout() { return timeout_; }
|
|
void set_timeout(int timeout) { timeout_ = timeout; }
|
|
|
|
// Fail redirects to allow analysis of redirect urls, etc.
|
|
bool fail_redirect() const { return fail_redirect_; }
|
|
void set_fail_redirect(bool redirect) { fail_redirect_ = redirect; }
|
|
|
|
// Returns the redirect when redirection occurs
|
|
const std::string& response_redirect() { return response_redirect_; }
|
|
|
|
HttpRequestData& request() { return client_.request(); }
|
|
HttpResponseData& response() { return client_.response(); }
|
|
HttpErrorType error() { return error_; }
|
|
|
|
protected:
|
|
void set_error(HttpErrorType error) { error_ = error; }
|
|
void OnWorkStart() override;
|
|
void OnWorkStop() override;
|
|
void OnComplete(HttpClient* client, HttpErrorType error);
|
|
void OnMessage(Message* message) override;
|
|
void DoWork() override;
|
|
|
|
private:
|
|
void LaunchRequest();
|
|
|
|
int start_delay_;
|
|
ProxyInfo proxy_;
|
|
FirewallManager* firewall_;
|
|
std::string host_;
|
|
int port_;
|
|
bool secure_;
|
|
int timeout_;
|
|
bool fail_redirect_;
|
|
SslSocketFactory factory_;
|
|
ReuseSocketPool pool_;
|
|
HttpClient client_;
|
|
HttpErrorType error_;
|
|
std::string response_redirect_;
|
|
};
|
|
|
|
} // namespace rtc
|
|
|
|
#endif // WEBRTC_BASE_ASYNCHTTPREQUEST_H_
|