zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
5d8f8fa0b6816bf3bd0f09e60110dc515403a109
platform-external-webrtc/pc
History
Henrik Boström 5d8f8fa0b6 Revert "Adding test for adding ICE candidate before applying answer." 
This reverts commit dd59d7049158a25f97ab1c7d381bfb4f8ed127c7.

Reason for revert: Speculatively reverting this due to chromium test.

The AutoRoller has been turned off for a couple of days due to the M67 branch cut. Did this cause a regression that made it into M67 or are the tests broken?

Failed roll:
https://chromium-review.googlesource.com/c/chromium/src/+/1011676
Example run:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/24406
Expected diff:
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=77d652517595443eea13f6ba9aaff67728305213&as=RTCPeerConnection-addIceCandidate-diff.txt

Original change's description:
> Adding test for adding ICE candidate before applying answer.
> 
> This was working before, but somewhat by accident (because an error
> wasn't being surfaced).
> 
> This CL also starts surfacing that error, from
> JsepTransportController::AddRemoteCandidates to PeerConnection.
> 
> Bug: None
> Change-Id: Ib48c9c00ea2a5baa5f7e3210c5dc7a339498b2d0
> Reviewed-on: https://webrtc-review.googlesource.com/69015
> Reviewed-by: Steve Anton <steveanton@webrtc.org>
> Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22830}

TBR=steveanton@webrtc.org,deadbeef@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I78a1df5d1e38569d02565bf343881420cc171347
Reviewed-on: https://webrtc-review.googlesource.com/69860
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22863}
2018-04-13 16:22:38 +00:00
..
test
By default, don't use SRTP_AES128_CM_SHA1_32 protection profile.
2018-04-05 23:43:07 +00:00
audiomonitor.h
Delete AudioMonitor and related code.
2018-01-30 09:48:29 +00:00
audiotrack.cc
Remove "using rtc::scoped_ptr" from audiotrack.cc.
2017-11-28 21:29:18 +00:00
audiotrack.h
…
BUILD.gn
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
bundlefilter_unittest.cc
Revert "Reland "Replace BundleFilter with RtpDemuxer in RtpTransport.""
2018-03-29 02:45:17 +00:00
bundlefilter.cc
Revert "Reland "Replace BundleFilter with RtpDemuxer in RtpTransport.""
2018-03-29 02:45:17 +00:00
bundlefilter.h
Revert "Reland "Replace BundleFilter with RtpDemuxer in RtpTransport.""
2018-03-29 02:45:17 +00:00
channel_unittest.cc
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
channel.cc
Adds support for signaling a=msid lines without a=ssrc lines.
2018-04-03 21:21:11 +00:00
channel.h
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
channelmanager_unittest.cc
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
channelmanager.cc
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
channelmanager.h
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
createpeerconnectionfactory.cc
Revert "Revert "Enables PeerConnectionFactory using external fec controller""
2018-02-20 12:41:55 +00:00
currentspeakermonitor_unittest.cc
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
currentspeakermonitor.cc
Delete AudioMonitor and related code.
2018-01-30 09:48:29 +00:00
currentspeakermonitor.h
…
datachannel_unittest.cc
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
datachannel.cc
Assorted logging pedantry
2018-02-13 10:47:24 +00:00
datachannel.h
…
DEPS
Reland "Removing forward headers in modules/audio_coding/codecs.""
2018-02-06 10:38:19 +00:00
dtlssrtptransport_unittest.cc
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
dtlssrtptransport.cc
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
dtlssrtptransport.h
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
dtmfsender_unittest.cc
Make DTMF sender wait before sending the first tone.
2018-03-06 13:23:11 +00:00
dtmfsender.cc
Make DTMF sender wait before sending the first tone.
2018-03-06 13:23:11 +00:00
dtmfsender.h
…
externalhmac.cc
Securely clear memory containing key information / passwords before freeing.
2018-03-07 22:06:20 +00:00
externalhmac.h
[CFI] Fix cfi-icall failures
2017-12-12 09:27:07 +00:00
iceserverparsing_unittest.cc
…
iceserverparsing.cc
Stop using LOG macros in favor of RTC_ prefixed macros.
2017-11-09 11:56:32 +00:00
iceserverparsing.h
…
jsepicecandidate.cc
…
jsepsessiondescription_unittest.cc
Use the SDP ContentInfo helpers to avoid downcasting
2017-12-22 00:17:53 +00:00
jsepsessiondescription.cc
Add MSID signaling compatibility for Unified Plan endpoints
2018-02-01 21:17:41 +00:00
jseptransport2_unittest.cc
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
jseptransport2.cc
Revert "Adding test for adding ICE candidate before applying answer."
2018-04-13 16:22:38 +00:00
jseptransport2.h
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
jseptransportcontroller_unittest.cc
Handle the corner cases for BUNDLE.
2018-04-11 00:05:35 +00:00
jseptransportcontroller.cc
Fix handling of empty BUNDLE groups.
2018-04-12 22:03:18 +00:00
jseptransportcontroller.h
Fix handling of empty BUNDLE groups.
2018-04-12 22:03:18 +00:00
localaudiosource_unittest.cc
Optional: Use nullopt and implicit construction in /pc
2017-11-21 17:53:37 +00:00
localaudiosource.cc
…
localaudiosource.h
…
mediaconstraintsinterface_unittest.cc
Rename a few MediaConfig::Video flags for consistency.
2018-01-22 17:32:58 +00:00
mediasession_unittest.cc
By default, don't use SRTP_AES128_CM_SHA1_32 protection profile.
2018-04-05 23:43:07 +00:00
mediasession.cc
Fix handling of empty BUNDLE groups.
2018-04-12 22:03:18 +00:00
mediasession.h
Negotiate the MID header extension for Unified Plan
2018-04-06 19:51:18 +00:00
mediastream_unittest.cc
Name change from stream label to stream id for spec compliance.
2018-03-02 20:44:48 +00:00
mediastream.cc
Name change from stream label to stream id for spec compliance.
2018-03-02 20:44:48 +00:00
mediastream.h
Small parameter name change from label->id in pc/mediastream.h.
2018-04-02 16:17:45 +00:00
mediastreamobserver.cc
…
mediastreamobserver.h
…
mediastreamtrack.h
…
OWNERS
Clean up the pc/OWNERS file.
2018-02-03 19:28:58 +00:00
peerconnection_bundle_unittest.cc
Fix handling of empty BUNDLE groups.
2018-04-12 22:03:18 +00:00
peerconnection_crypto_unittest.cc
Reland "Set session error if SetLocal/RemoteDescription ever fails"
2018-02-17 02:08:19 +00:00
peerconnection_datachannel_unittest.cc
Parameterize PeerConnection data channel tests for Unified Plan
2018-01-20 00:50:53 +00:00
peerconnection_ice_unittest.cc
Revert "Adding test for adding ICE candidate before applying answer."
2018-04-13 16:22:38 +00:00
peerconnection_integrationtest.cc
Adding regression test for rejecting and un-rejecting an m= section.
2018-04-11 23:29:36 +00:00
peerconnection_jsep_unittest.cc
Report an error when trying to set complex Plan B SDP on Unified Plan
2018-04-11 18:16:26 +00:00
peerconnection_media_unittest.cc
Handle the corner cases for BUNDLE.
2018-04-11 00:05:35 +00:00
peerconnection_rtp_unittest.cc
Report an error when trying to set complex Plan B SDP on Unified Plan
2018-04-11 18:16:26 +00:00
peerconnection_signaling_unittest.cc
Parameterize PeerConnection signaling tests for Unified Plan
2018-02-09 19:48:09 +00:00
peerconnection.cc
Revert "Adding test for adding ICE candidate before applying answer."
2018-04-13 16:22:38 +00:00
peerconnection.h
Revert "Add thread checker to PortAllocator and its subclasses and fix a bug"
2018-04-11 11:15:08 +00:00
peerconnectionendtoend_unittest.cc
Re-enable test on mac now that issue is fixed.
2018-04-13 11:29:28 +00:00
peerconnectionfactory_unittest.cc
Extend FakePeriodicVideoCapturer with FakeVideoCapturerWithTaskQueue.
2018-02-07 16:42:01 +00:00
peerconnectionfactory.cc
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
peerconnectionfactory.h
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
peerconnectioninterface_unittest.cc
Revert "Add thread checker to PortAllocator and its subclasses and fix a bug"
2018-04-11 11:15:08 +00:00
peerconnectioninternal.h
Implement certificate chain stats.
2018-02-24 00:44:06 +00:00
peerconnectionwrapper.cc
Report UMA metrics for received SDP format
2018-03-06 21:22:51 +00:00
peerconnectionwrapper.h
Report UMA metrics for received SDP format
2018-03-06 21:22:51 +00:00
proxy_unittest.cc
Clean up dependencies of peerconnection_unittest.
2017-09-15 12:51:00 +00:00
remoteaudiosource.cc
Configure media flow correctly with Unified Plan
2018-01-18 19:01:38 +00:00
remoteaudiosource.h
Configure media flow correctly with Unified Plan
2018-01-18 19:01:38 +00:00
rtcpmuxfilter_unittest.cc
…
rtcpmuxfilter.cc
Stop using LOG macros in favor of RTC_ prefixed macros.
2017-11-09 11:56:32 +00:00
rtcpmuxfilter.h
Move sessiondescription.h/cc from p2p/base to pc/
2017-12-20 00:21:52 +00:00
rtcstats_integrationtest.cc
PeerConnectionInterface::GetStats() with selector argument added.
2018-03-26 12:08:20 +00:00
rtcstatscollector_unittest.cc
RTCStatsCollector::GetStatsReport() with optional selector argument.
2018-03-19 15:32:16 +00:00
rtcstatscollector.cc
Ensure that data channel transport stats are included
2018-04-02 18:45:27 +00:00
rtcstatscollector.h
Ensure that data channel transport stats are included
2018-04-02 18:45:27 +00:00
rtcstatstraversal_unittest.cc
Stats traversal algorithm added.
2018-03-12 10:54:09 +00:00
rtcstatstraversal.cc
RTCStatsCollector::GetStatsReport() with optional selector argument.
2018-03-19 15:32:16 +00:00
rtcstatstraversal.h
Stats traversal algorithm added.
2018-03-12 10:54:09 +00:00
rtpmediautils_unittest.cc
Implement legacy offer_to_receive options for Unified Plan
2018-01-27 02:20:29 +00:00
rtpmediautils.cc
Implement legacy offer_to_receive options for Unified Plan
2018-01-27 02:20:29 +00:00
rtpmediautils.h
Implement legacy offer_to_receive options for Unified Plan
2018-01-27 02:20:29 +00:00
rtpreceiver.cc
Final name changing of MediaStreamInterface.label() to id().
2018-03-14 20:30:52 +00:00
rtpreceiver.h
Reland "Update RTCStatsCollector to work with RtpTransceivers"
2018-02-17 00:01:39 +00:00
rtpsender.cc
Delete obsolete enable argument to SetVideoSend.
2018-04-09 08:45:29 +00:00
rtpsender.h
Delete obsolete enable argument to SetVideoSend.
2018-04-09 08:45:29 +00:00
rtpsenderreceiver_unittest.cc
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
rtptransceiver.cc
Add log messages for Unified Plan processing
2018-04-02 20:49:55 +00:00
rtptransceiver.h
Fire OnRenegotiationNeeded when changing transceiver direction
2018-02-21 19:15:09 +00:00
rtptransport_unittest.cc
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
rtptransport.cc
Filter out the non-RTP packet in RtpTransport.
2018-04-04 01:50:19 +00:00
rtptransport.h
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
rtptransportinternal.h
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
rtptransportinternaladapter.h
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
rtptransporttestutil.h
Revert "Reland "Replace BundleFilter with RtpDemuxer in RtpTransport.""
2018-03-29 02:45:17 +00:00
sctputils_unittest.cc
…
sctputils.cc
Stop using LOG macros in favor of RTC_ prefixed macros.
2017-11-09 11:56:32 +00:00
sctputils.h
…
sdputils.cc
Replace string type with SdpType enum
2017-12-07 19:08:47 +00:00
sdputils.h
Move sessiondescription.h/cc from p2p/base to pc/
2017-12-20 00:21:52 +00:00
sessiondescription.cc
Use the SDP ContentInfo helpers to avoid downcasting
2017-12-22 00:17:53 +00:00
sessiondescription.h
Add MSID signaling compatibility for Unified Plan endpoints
2018-02-01 21:17:41 +00:00
srtpfilter_unittest.cc
Securely clear memory containing key information / passwords before freeing.
2018-03-07 22:06:20 +00:00
srtpfilter.cc
Securely clear memory containing key information / passwords before freeing.
2018-03-07 22:06:20 +00:00
srtpfilter.h
Securely clear memory containing key information / passwords before freeing.
2018-03-07 22:06:20 +00:00
srtpsession_unittest.cc
Report SRTP error codes to UMA
2018-03-20 18:37:49 +00:00
srtpsession.cc
Report SRTP error codes to UMA
2018-03-20 18:37:49 +00:00
srtpsession.h
Report SRTP error codes to UMA
2018-03-20 18:37:49 +00:00
srtptestutil.h
…
srtptransport_unittest.cc
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
srtptransport.cc
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
srtptransport.h
Use new TransportController implementation in PeerConnection.
2018-03-30 18:41:19 +00:00
statscollector_unittest.cc
Name change from stream label to stream id for spec compliance.
2018-03-02 20:44:48 +00:00
statscollector.cc
Reland "Add hugeFramesSent GetStats metric"
2018-03-06 13:38:11 +00:00
statscollector.h
Implement certificate chain stats.
2018-02-24 00:44:06 +00:00
streamcollection.h
Final name changing of MediaStreamInterface.label() to id().
2018-03-14 20:30:52 +00:00
trackmediainfomap_unittest.cc
Reland "Update RTCStatsCollector to work with RtpTransceivers"
2018-02-17 00:01:39 +00:00
trackmediainfomap.cc
Reland "Update RTCStatsCollector to work with RtpTransceivers"
2018-02-17 00:01:39 +00:00
trackmediainfomap.h
Reland "Update RTCStatsCollector to work with RtpTransceivers"
2018-02-17 00:01:39 +00:00
transportstats.cc
Create the JsepTransportController and JsepTransport2.
2018-02-23 00:13:45 +00:00
transportstats.h
Create the JsepTransportController and JsepTransport2.
2018-02-23 00:13:45 +00:00
videocapturertracksource_unittest.cc
Update VideoCapturerTrackSourceTest to deliver frames via TaskQueue.
2018-02-07 14:25:08 +00:00
videocapturertracksource.cc
Optional: Use nullopt and implicit construction in /pc
2017-11-21 17:53:37 +00:00
videocapturertracksource.h
…
videotrack_unittest.cc
Update several tests: FakeVideoCapturer -> FakeVideoCapturerWithTaskQueue.
2018-02-08 09:03:58 +00:00
videotrack.cc
Enable cpplint in pc/
2017-10-30 18:08:29 +00:00
videotrack.h
…
videotracksource.cc
…
videotracksource.h
Move videosinkinterface.h to common_video to solve a circular dep.
2018-01-04 13:19:49 +00:00
webrtcsdp_unittest.cc
Adds support for signaling a=msid lines without a=ssrc lines.
2018-04-03 21:21:11 +00:00
webrtcsdp.cc
Adds support for signaling a=msid lines without a=ssrc lines.
2018-04-03 21:21:11 +00:00
webrtcsdp.h
Add MSID signaling compatibility for Unified Plan endpoints
2018-02-01 21:17:41 +00:00
webrtcsessiondescriptionfactory.cc
Assorted logging pedantry
2018-02-13 10:47:24 +00:00
webrtcsessiondescriptionfactory.h
Move internal PeerConnection methods to PeerConnectionInternal
2018-01-24 17:24:29 +00:00