3791d332c5
When using VideoEncoderSoftwareFallbackWrapper, releasing and initialization of encoder_ (H/W) and fallback_encoder_(S/W) happen repeatedly as reconfiguration procedure is called from higher layer. Below problems would occur when our encoder_(H/W) fails to initialize or encode. Firstly, some encoders' SetFecControllerOverride() functions will fail during repeated calls since they have checks like RTC_DCHECK(!fec_controller_override_) to avoid repeated assignment of fec_controller_override_. (see : LibvpxVp8Encoder::SetFecControllerOverride()) Secondly, if main_ encoder fails to initialize at first attempt, FEC setting (fec_controller_override) will not set until reconfiguration procedure is called again. This CL comes with two changes to fix above problems. 1. Sets fec_controller_override to both encoders when SoftwareFallbackWrapper::SetFecController() is called. 2. Removes the current_encoder()->SetFecControllerOverride() in PrimeEncoder() to avoid redundant calls which may involve fatal error. Bug: webrtc:13184 Change-Id: I082c93de552bc9ec3141c6490d35acfcee2f8935 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234301 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35231}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.