610c76323e
This CL plumbs an additional signal from VideoSendStream down to VideoStreamEncoder, namely the amount of headroom that's left between the encoder max bitrate and the current bitrate allocation for the media track. This will be used in follow-up CLs to tune encoder rate adjustment and some codec specific paramaters a bit differently, based on the knowledge if we are network constrained or not. Bug: webrtc:10155 Change-Id: Ic6ccc79be5c6845468bab65b4ca9918b56923fa4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125981 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27008}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.