65e3044b40
This reverts commit fdd41ecf6b05b02a1ee12583e537f1cdb5922919. Reason for revert: Breaks WebRTC roll into Chrome: https://crrev.com/c/2335265 Sample failure: https://ci.chromium.org/p/chromium/builders/try/linux_chromium_compile_dbg_ng/688153? Original change's description: > Add EncodedImageCallback::OnEncodedImage without RTPFragmentationHeader > > RTPFragmentationHeader is no longer used by any webrtc code. > > Bug: webrtc:6471 > Change-Id: I1362d58465c550f5c8e0a5b292dc0abcd6251431 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180120 > Reviewed-by: Sebastian Jansson <srte@webrtc.org> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > Reviewed-by: Niels Moller <nisse@webrtc.org> > Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31833} TBR=danilchap@webrtc.org,brandtr@webrtc.org,nisse@webrtc.org,srte@webrtc.org Change-Id: I6bd021637b0c140f6625612caebdb5829decdfb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6471 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180821 Reviewed-by: Marina Ciocea <marinaciocea@webrtc.org> Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31839}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.