I am working on enabling AV1 profile-1 support for Chrome Remote Desktop and I noticed that when our host adds both AV1 profile-0 and AV1 profile-1 codecs to the SDP, the second codec is stripped. I tracked the problem down to this class as the IsSameCodecSpecific function was not looking at the format params to determine whether the additional AV1 codec entries were duplciates of the first. Bug: chromium:1329660 Change-Id: I6ee0c264657203631a43f74f64e08153dca4f63a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273981 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/main@{#38020}
472 lines
16 KiB
C++
472 lines
16 KiB
C++
/*
|
|
* Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "media/base/codec.h"
|
|
|
|
#include "absl/algorithm/container.h"
|
|
#include "absl/strings/match.h"
|
|
#include "api/video_codecs/av1_profile.h"
|
|
#include "api/video_codecs/h264_profile_level_id.h"
|
|
#include "api/video_codecs/vp9_profile.h"
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/logging.h"
|
|
#include "rtc_base/string_encode.h"
|
|
#include "rtc_base/strings/string_builder.h"
|
|
|
|
namespace cricket {
|
|
namespace {
|
|
|
|
std::string GetH264PacketizationModeOrDefault(const CodecParameterMap& params) {
|
|
auto it = params.find(kH264FmtpPacketizationMode);
|
|
if (it != params.end()) {
|
|
return it->second;
|
|
}
|
|
// If packetization-mode is not present, default to "0".
|
|
// https://tools.ietf.org/html/rfc6184#section-6.2
|
|
return "0";
|
|
}
|
|
|
|
bool IsSameH264PacketizationMode(const CodecParameterMap& left,
|
|
const CodecParameterMap& right) {
|
|
return GetH264PacketizationModeOrDefault(left) ==
|
|
GetH264PacketizationModeOrDefault(right);
|
|
}
|
|
|
|
// Some (video) codecs are actually families of codecs and rely on parameters
|
|
// to distinguish different incompatible family members.
|
|
bool IsSameCodecSpecific(const std::string& name1,
|
|
const CodecParameterMap& params1,
|
|
const std::string& name2,
|
|
const CodecParameterMap& params2) {
|
|
// The names might not necessarily match, so check both.
|
|
auto either_name_matches = [&](const std::string name) {
|
|
return absl::EqualsIgnoreCase(name, name1) ||
|
|
absl::EqualsIgnoreCase(name, name2);
|
|
};
|
|
if (either_name_matches(kH264CodecName))
|
|
return webrtc::H264IsSameProfile(params1, params2) &&
|
|
IsSameH264PacketizationMode(params1, params2);
|
|
if (either_name_matches(kVp9CodecName))
|
|
return webrtc::VP9IsSameProfile(params1, params2);
|
|
if (either_name_matches(kAv1CodecName))
|
|
return webrtc::AV1IsSameProfile(params1, params2);
|
|
return true;
|
|
}
|
|
|
|
} // namespace
|
|
|
|
FeedbackParams::FeedbackParams() = default;
|
|
FeedbackParams::~FeedbackParams() = default;
|
|
|
|
bool FeedbackParam::operator==(const FeedbackParam& other) const {
|
|
return absl::EqualsIgnoreCase(other.id(), id()) &&
|
|
absl::EqualsIgnoreCase(other.param(), param());
|
|
}
|
|
|
|
bool FeedbackParams::operator==(const FeedbackParams& other) const {
|
|
return params_ == other.params_;
|
|
}
|
|
|
|
bool FeedbackParams::Has(const FeedbackParam& param) const {
|
|
return absl::c_linear_search(params_, param);
|
|
}
|
|
|
|
void FeedbackParams::Add(const FeedbackParam& param) {
|
|
if (param.id().empty()) {
|
|
return;
|
|
}
|
|
if (Has(param)) {
|
|
// Param already in `this`.
|
|
return;
|
|
}
|
|
params_.push_back(param);
|
|
RTC_CHECK(!HasDuplicateEntries());
|
|
}
|
|
|
|
void FeedbackParams::Intersect(const FeedbackParams& from) {
|
|
std::vector<FeedbackParam>::iterator iter_to = params_.begin();
|
|
while (iter_to != params_.end()) {
|
|
if (!from.Has(*iter_to)) {
|
|
iter_to = params_.erase(iter_to);
|
|
} else {
|
|
++iter_to;
|
|
}
|
|
}
|
|
}
|
|
|
|
bool FeedbackParams::HasDuplicateEntries() const {
|
|
for (std::vector<FeedbackParam>::const_iterator iter = params_.begin();
|
|
iter != params_.end(); ++iter) {
|
|
for (std::vector<FeedbackParam>::const_iterator found = iter + 1;
|
|
found != params_.end(); ++found) {
|
|
if (*found == *iter) {
|
|
return true;
|
|
}
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
Codec::Codec(int id, const std::string& name, int clockrate)
|
|
: id(id), name(name), clockrate(clockrate) {}
|
|
|
|
Codec::Codec() : id(0), clockrate(0) {}
|
|
|
|
Codec::Codec(const Codec& c) = default;
|
|
Codec::Codec(Codec&& c) = default;
|
|
Codec::~Codec() = default;
|
|
Codec& Codec::operator=(const Codec& c) = default;
|
|
Codec& Codec::operator=(Codec&& c) = default;
|
|
|
|
bool Codec::operator==(const Codec& c) const {
|
|
return this->id == c.id && // id is reserved in objective-c
|
|
name == c.name && clockrate == c.clockrate && params == c.params &&
|
|
feedback_params == c.feedback_params;
|
|
}
|
|
|
|
bool Codec::Matches(const Codec& codec,
|
|
const webrtc::FieldTrialsView* field_trials) const {
|
|
// Match the codec id/name based on the typical static/dynamic name rules.
|
|
// Matching is case-insensitive.
|
|
|
|
// Legacy behaviour with killswitch.
|
|
if (field_trials &&
|
|
field_trials->IsDisabled("WebRTC-PayloadTypes-Lower-Dynamic-Range")) {
|
|
const int kMaxStaticPayloadId = 95;
|
|
return (id <= kMaxStaticPayloadId || codec.id <= kMaxStaticPayloadId)
|
|
? (id == codec.id)
|
|
: (absl::EqualsIgnoreCase(name, codec.name));
|
|
}
|
|
// We support the ranges [96, 127] and more recently [35, 65].
|
|
// https://www.iana.org/assignments/rtp-parameters/rtp-parameters.xhtml#rtp-parameters-1
|
|
// Within those ranges we match by codec name, outside by codec id.
|
|
const int kLowerDynamicRangeMin = 35;
|
|
const int kLowerDynamicRangeMax = 65;
|
|
const int kUpperDynamicRangeMin = 96;
|
|
const int kUpperDynamicRangeMax = 127;
|
|
const bool is_id_in_dynamic_range =
|
|
(id >= kLowerDynamicRangeMin && id <= kLowerDynamicRangeMax) ||
|
|
(id >= kUpperDynamicRangeMin && id <= kUpperDynamicRangeMax);
|
|
const bool is_codec_id_in_dynamic_range =
|
|
(codec.id >= kLowerDynamicRangeMin &&
|
|
codec.id <= kLowerDynamicRangeMax) ||
|
|
(codec.id >= kUpperDynamicRangeMin && codec.id <= kUpperDynamicRangeMax);
|
|
return is_id_in_dynamic_range && is_codec_id_in_dynamic_range
|
|
? (absl::EqualsIgnoreCase(name, codec.name))
|
|
: (id == codec.id);
|
|
}
|
|
|
|
bool Codec::MatchesCapability(
|
|
const webrtc::RtpCodecCapability& codec_capability) const {
|
|
webrtc::RtpCodecParameters codec_parameters = ToCodecParameters();
|
|
|
|
return codec_parameters.name == codec_capability.name &&
|
|
codec_parameters.kind == codec_capability.kind &&
|
|
(codec_parameters.name == cricket::kRtxCodecName ||
|
|
(codec_parameters.num_channels == codec_capability.num_channels &&
|
|
codec_parameters.clock_rate == codec_capability.clock_rate &&
|
|
codec_parameters.parameters == codec_capability.parameters));
|
|
}
|
|
|
|
bool Codec::GetParam(const std::string& name, std::string* out) const {
|
|
CodecParameterMap::const_iterator iter = params.find(name);
|
|
if (iter == params.end())
|
|
return false;
|
|
*out = iter->second;
|
|
return true;
|
|
}
|
|
|
|
bool Codec::GetParam(const std::string& name, int* out) const {
|
|
CodecParameterMap::const_iterator iter = params.find(name);
|
|
if (iter == params.end())
|
|
return false;
|
|
return rtc::FromString(iter->second, out);
|
|
}
|
|
|
|
void Codec::SetParam(const std::string& name, const std::string& value) {
|
|
params[name] = value;
|
|
}
|
|
|
|
void Codec::SetParam(const std::string& name, int value) {
|
|
params[name] = rtc::ToString(value);
|
|
}
|
|
|
|
bool Codec::RemoveParam(const std::string& name) {
|
|
return params.erase(name) == 1;
|
|
}
|
|
|
|
void Codec::AddFeedbackParam(const FeedbackParam& param) {
|
|
feedback_params.Add(param);
|
|
}
|
|
|
|
bool Codec::HasFeedbackParam(const FeedbackParam& param) const {
|
|
return feedback_params.Has(param);
|
|
}
|
|
|
|
void Codec::IntersectFeedbackParams(const Codec& other) {
|
|
feedback_params.Intersect(other.feedback_params);
|
|
}
|
|
|
|
webrtc::RtpCodecParameters Codec::ToCodecParameters() const {
|
|
webrtc::RtpCodecParameters codec_params;
|
|
codec_params.payload_type = id;
|
|
codec_params.name = name;
|
|
codec_params.clock_rate = clockrate;
|
|
codec_params.parameters.insert(params.begin(), params.end());
|
|
return codec_params;
|
|
}
|
|
|
|
AudioCodec::AudioCodec(int id,
|
|
const std::string& name,
|
|
int clockrate,
|
|
int bitrate,
|
|
size_t channels)
|
|
: Codec(id, name, clockrate), bitrate(bitrate), channels(channels) {}
|
|
|
|
AudioCodec::AudioCodec() : Codec(), bitrate(0), channels(0) {}
|
|
|
|
AudioCodec::AudioCodec(const AudioCodec& c) = default;
|
|
AudioCodec::AudioCodec(AudioCodec&& c) = default;
|
|
AudioCodec& AudioCodec::operator=(const AudioCodec& c) = default;
|
|
AudioCodec& AudioCodec::operator=(AudioCodec&& c) = default;
|
|
|
|
bool AudioCodec::operator==(const AudioCodec& c) const {
|
|
return bitrate == c.bitrate && channels == c.channels && Codec::operator==(c);
|
|
}
|
|
|
|
bool AudioCodec::Matches(const AudioCodec& codec,
|
|
const webrtc::FieldTrialsView* field_trials) const {
|
|
// If a nonzero clockrate is specified, it must match the actual clockrate.
|
|
// If a nonzero bitrate is specified, it must match the actual bitrate,
|
|
// unless the codec is VBR (0), where we just force the supplied value.
|
|
// The number of channels must match exactly, with the exception
|
|
// that channels=0 is treated synonymously as channels=1, per RFC
|
|
// 4566 section 6: " [The channels] parameter is OPTIONAL and may be
|
|
// omitted if the number of channels is one."
|
|
// Preference is ignored.
|
|
// TODO(juberti): Treat a zero clockrate as 8000Hz, the RTP default clockrate.
|
|
return Codec::Matches(codec, field_trials) &&
|
|
((codec.clockrate == 0 /*&& clockrate == 8000*/) ||
|
|
clockrate == codec.clockrate) &&
|
|
(codec.bitrate == 0 || bitrate <= 0 || bitrate == codec.bitrate) &&
|
|
((codec.channels < 2 && channels < 2) || channels == codec.channels);
|
|
}
|
|
|
|
std::string AudioCodec::ToString() const {
|
|
char buf[256];
|
|
rtc::SimpleStringBuilder sb(buf);
|
|
sb << "AudioCodec[" << id << ":" << name << ":" << clockrate << ":" << bitrate
|
|
<< ":" << channels << "]";
|
|
return sb.str();
|
|
}
|
|
|
|
webrtc::RtpCodecParameters AudioCodec::ToCodecParameters() const {
|
|
webrtc::RtpCodecParameters codec_params = Codec::ToCodecParameters();
|
|
codec_params.num_channels = static_cast<int>(channels);
|
|
codec_params.kind = MEDIA_TYPE_AUDIO;
|
|
return codec_params;
|
|
}
|
|
|
|
std::string VideoCodec::ToString() const {
|
|
char buf[256];
|
|
rtc::SimpleStringBuilder sb(buf);
|
|
sb << "VideoCodec[" << id << ":" << name;
|
|
if (packetization.has_value()) {
|
|
sb << ":" << *packetization;
|
|
}
|
|
sb << "]";
|
|
return sb.str();
|
|
}
|
|
|
|
webrtc::RtpCodecParameters VideoCodec::ToCodecParameters() const {
|
|
webrtc::RtpCodecParameters codec_params = Codec::ToCodecParameters();
|
|
codec_params.kind = MEDIA_TYPE_VIDEO;
|
|
return codec_params;
|
|
}
|
|
|
|
VideoCodec::VideoCodec(int id, const std::string& name)
|
|
: Codec(id, name, kVideoCodecClockrate) {
|
|
SetDefaultParameters();
|
|
}
|
|
|
|
VideoCodec::VideoCodec(const std::string& name) : VideoCodec(0 /* id */, name) {
|
|
SetDefaultParameters();
|
|
}
|
|
|
|
VideoCodec::VideoCodec() : Codec() {
|
|
clockrate = kVideoCodecClockrate;
|
|
}
|
|
|
|
VideoCodec::VideoCodec(const webrtc::SdpVideoFormat& c)
|
|
: Codec(0 /* id */, c.name, kVideoCodecClockrate) {
|
|
params = c.parameters;
|
|
scalability_modes = c.scalability_modes;
|
|
}
|
|
|
|
VideoCodec::VideoCodec(const VideoCodec& c) = default;
|
|
VideoCodec::VideoCodec(VideoCodec&& c) = default;
|
|
VideoCodec& VideoCodec::operator=(const VideoCodec& c) = default;
|
|
VideoCodec& VideoCodec::operator=(VideoCodec&& c) = default;
|
|
|
|
void VideoCodec::SetDefaultParameters() {
|
|
if (absl::EqualsIgnoreCase(kH264CodecName, name)) {
|
|
// This default is set for all H.264 codecs created because
|
|
// that was the default before packetization mode support was added.
|
|
// TODO(hta): Move this to the places that create VideoCodecs from
|
|
// SDP or from knowledge of implementation capabilities.
|
|
SetParam(kH264FmtpPacketizationMode, "1");
|
|
}
|
|
}
|
|
|
|
bool VideoCodec::operator==(const VideoCodec& c) const {
|
|
return Codec::operator==(c) && packetization == c.packetization;
|
|
}
|
|
|
|
bool VideoCodec::Matches(const VideoCodec& other,
|
|
const webrtc::FieldTrialsView* field_trials) const {
|
|
return Codec::Matches(other, field_trials) &&
|
|
IsSameCodecSpecific(name, params, other.name, other.params);
|
|
}
|
|
|
|
absl::optional<std::string> VideoCodec::IntersectPacketization(
|
|
const VideoCodec& local_codec,
|
|
const VideoCodec& remote_codec) {
|
|
if (local_codec.packetization == remote_codec.packetization) {
|
|
return local_codec.packetization;
|
|
}
|
|
return absl::nullopt;
|
|
}
|
|
|
|
VideoCodec VideoCodec::CreateRtxCodec(int rtx_payload_type,
|
|
int associated_payload_type) {
|
|
VideoCodec rtx_codec(rtx_payload_type, kRtxCodecName);
|
|
rtx_codec.SetParam(kCodecParamAssociatedPayloadType, associated_payload_type);
|
|
return rtx_codec;
|
|
}
|
|
|
|
VideoCodec::CodecType VideoCodec::GetCodecType() const {
|
|
if (absl::EqualsIgnoreCase(name, kRedCodecName)) {
|
|
return CODEC_RED;
|
|
}
|
|
if (absl::EqualsIgnoreCase(name, kUlpfecCodecName)) {
|
|
return CODEC_ULPFEC;
|
|
}
|
|
if (absl::EqualsIgnoreCase(name, kFlexfecCodecName)) {
|
|
return CODEC_FLEXFEC;
|
|
}
|
|
if (absl::EqualsIgnoreCase(name, kRtxCodecName)) {
|
|
return CODEC_RTX;
|
|
}
|
|
|
|
return CODEC_VIDEO;
|
|
}
|
|
|
|
bool VideoCodec::ValidateCodecFormat() const {
|
|
if (id < 0 || id > 127) {
|
|
RTC_LOG(LS_ERROR) << "Codec with invalid payload type: " << ToString();
|
|
return false;
|
|
}
|
|
if (GetCodecType() != CODEC_VIDEO) {
|
|
return true;
|
|
}
|
|
|
|
// Video validation from here on.
|
|
int min_bitrate = -1;
|
|
int max_bitrate = -1;
|
|
if (GetParam(kCodecParamMinBitrate, &min_bitrate) &&
|
|
GetParam(kCodecParamMaxBitrate, &max_bitrate)) {
|
|
if (max_bitrate < min_bitrate) {
|
|
RTC_LOG(LS_ERROR) << "Codec with max < min bitrate: " << ToString();
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool HasLntf(const Codec& codec) {
|
|
return codec.HasFeedbackParam(
|
|
FeedbackParam(kRtcpFbParamLntf, kParamValueEmpty));
|
|
}
|
|
|
|
bool HasNack(const Codec& codec) {
|
|
return codec.HasFeedbackParam(
|
|
FeedbackParam(kRtcpFbParamNack, kParamValueEmpty));
|
|
}
|
|
|
|
bool HasRemb(const Codec& codec) {
|
|
return codec.HasFeedbackParam(
|
|
FeedbackParam(kRtcpFbParamRemb, kParamValueEmpty));
|
|
}
|
|
|
|
bool HasRrtr(const Codec& codec) {
|
|
return codec.HasFeedbackParam(
|
|
FeedbackParam(kRtcpFbParamRrtr, kParamValueEmpty));
|
|
}
|
|
|
|
bool HasTransportCc(const Codec& codec) {
|
|
return codec.HasFeedbackParam(
|
|
FeedbackParam(kRtcpFbParamTransportCc, kParamValueEmpty));
|
|
}
|
|
|
|
const VideoCodec* FindMatchingCodec(
|
|
const std::vector<VideoCodec>& supported_codecs,
|
|
const VideoCodec& codec) {
|
|
webrtc::SdpVideoFormat sdp_video_format{codec.name, codec.params};
|
|
for (const VideoCodec& supported_codec : supported_codecs) {
|
|
if (sdp_video_format.IsSameCodec(
|
|
{supported_codec.name, supported_codec.params})) {
|
|
return &supported_codec;
|
|
}
|
|
}
|
|
return nullptr;
|
|
}
|
|
|
|
// If a decoder supports any H264 profile, it is implicitly assumed to also
|
|
// support constrained base line even though it's not explicitly listed.
|
|
void AddH264ConstrainedBaselineProfileToSupportedFormats(
|
|
std::vector<webrtc::SdpVideoFormat>* supported_formats) {
|
|
std::vector<webrtc::SdpVideoFormat> cbr_supported_formats;
|
|
|
|
// For any H264 supported profile, add the corresponding constrained baseline
|
|
// profile.
|
|
for (auto it = supported_formats->cbegin(); it != supported_formats->cend();
|
|
++it) {
|
|
if (it->name == cricket::kH264CodecName) {
|
|
const absl::optional<webrtc::H264ProfileLevelId> profile_level_id =
|
|
webrtc::ParseSdpForH264ProfileLevelId(it->parameters);
|
|
if (profile_level_id &&
|
|
profile_level_id->profile !=
|
|
webrtc::H264Profile::kProfileConstrainedBaseline) {
|
|
webrtc::SdpVideoFormat cbp_format = *it;
|
|
webrtc::H264ProfileLevelId cbp_profile = *profile_level_id;
|
|
cbp_profile.profile = webrtc::H264Profile::kProfileConstrainedBaseline;
|
|
cbp_format.parameters[cricket::kH264FmtpProfileLevelId] =
|
|
*webrtc::H264ProfileLevelIdToString(cbp_profile);
|
|
cbr_supported_formats.push_back(cbp_format);
|
|
}
|
|
}
|
|
}
|
|
|
|
size_t original_size = supported_formats->size();
|
|
// ...if it's not already in the list.
|
|
std::copy_if(cbr_supported_formats.begin(), cbr_supported_formats.end(),
|
|
std::back_inserter(*supported_formats),
|
|
[supported_formats](const webrtc::SdpVideoFormat& format) {
|
|
return !format.IsCodecInList(*supported_formats);
|
|
});
|
|
|
|
if (supported_formats->size() > original_size) {
|
|
RTC_LOG(LS_WARNING) << "Explicitly added H264 constrained baseline to list "
|
|
"of supported formats.";
|
|
}
|
|
}
|
|
|
|
} // namespace cricket
|