6bf20cc76a
For now, the run-time check will only be enabled if the rtc_strict_field_trials GN arg is set. In order to allow testing with imaginary field trial keys, two test helpers have been added. It's a bit awkward to test these since the field trial string is already global, hence the helpers are also modifying global state. Tests must make sure this global state is reset between runs. Things won't be an issue anymore when [1] has removed the global string. [1] https://crbug.com/webrtc/10335 Bug: webrtc:14154 Change-Id: Ida44cc817079d7177325e2228cf1f1d242b799e2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276269 Commit-Queue: Emil Lundmark <lndmrk@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38447}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.