edab3011fa
This is done to solve a problem where a string literal is implicitly cast to a temporary std::string when calling webrtc::test::InitFieldTrialsFromString which passes a pointer to the internal representation to webrtc::field_trial::InitFieldTrialFromString(char*). This pointer is stored for later use, but the temporary std::string is destroyed as soon as the function returns. Using webrtc::field_trial::InitFieldTrialFromString(char*) instead, avoids the implicit casts (but the caller still needs to ensure that the char* outlives the program). The validation previously done by webrtc::test::InitFieldTrialsFromString can now be done by manually calling webrtc::test::ValidateFieldTrialsStringOrDie(const std::string&). Add system_wrappers:field_trial_default as a direct dependency to various targets to allow including the field_trials_default.h header. Bug: webrtc:8812 Change-Id: Ib5a641ea255b1c16a8f7f35e1fe67f6c38a61da6 Reviewed-on: https://webrtc-review.googlesource.com/46141 Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21856}
50 lines
1.7 KiB
C++
50 lines
1.7 KiB
C++
/*
|
|
* Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef TEST_FIELD_TRIAL_H_
|
|
#define TEST_FIELD_TRIAL_H_
|
|
|
|
#include <string>
|
|
#include <map>
|
|
|
|
namespace webrtc {
|
|
namespace test {
|
|
|
|
// Parses enabled field trials from a string config, such as the one passed
|
|
// to chrome's argument --force-fieldtrials and initializes webrtc::field_trial
|
|
// with such a config.
|
|
// E.g.:
|
|
// "WebRTC-experimentFoo/Enabled/WebRTC-experimentBar/Enabled100kbps/"
|
|
// Assigns the process to group "Enabled" on WebRTCExperimentFoo trial
|
|
// and to group "Enabled100kbps" on WebRTCExperimentBar.
|
|
//
|
|
// E.g. invalid config:
|
|
// "WebRTC-experiment1/Enabled" (note missing / separator at the end).
|
|
//
|
|
// Note: This method crashes with an error message if an invalid config is
|
|
// passed to it. That can be used to find out if a binary is parsing the flags.
|
|
void ValidateFieldTrialsStringOrDie(const std::string& config);
|
|
|
|
// This class is used to override field-trial configs within specific tests.
|
|
// After this class goes out of scope previous field trials will be restored.
|
|
class ScopedFieldTrials {
|
|
public:
|
|
explicit ScopedFieldTrials(const std::string& config);
|
|
~ScopedFieldTrials();
|
|
private:
|
|
std::string current_field_trials_;
|
|
const char* previous_field_trials_;
|
|
};
|
|
|
|
} // namespace test
|
|
} // namespace webrtc
|
|
|
|
#endif // TEST_FIELD_TRIAL_H_
|