Guido Urdaneta
ff7913204c
Revert "Reland "Replace sigslot usages with robocaller library.""
This reverts commit c5f71087589b18bb4df1b78f2c452c4083edf2d9.
Reason for revert: Causes Chromium WPT Tests to fail, preventing rolls.
Sample failed run:
https://ci.chromium.org/p/chromium/builders/try/linux-rel/511995?
Sample logs:
STDERR: # Fatal error in: ../../third_party/webrtc/pc/peer_connection.cc, line 575
STDERR: # last system error: 0
STDERR: # Check failed: (signaling_thread())->IsCurrent()
STDERR: # Received signal 6
STDERR: #0 0x7f81d39e3de9 base::debug::CollectStackTrace()
STDERR: #1 0x7f81d38f9ca3 base::debug::StackTrace::StackTrace()
STDERR: #2 0x7f81d39e393b base::debug::(anonymous namespace)::StackDumpSignalHandler()
STDERR: #3 0x7f81c9054140 (/lib/x86_64-linux-gnu/libpthread-2.31.so+0x1413f)
STDERR: #4 0x7f81c8d72db1 gsignal
STDERR: #5 0x7f81c8d5c537 abort
STDERR: #6 0x7f81c7344032 rtc::webrtc_checks_impl::FatalLog()
STDERR: #7 0x7f81c722e5c0 webrtc::webrtc_function_impl::CallHelpers<>::CallInlineStorage<>()
STDERR: #8 0x7f81c7348d99 webrtc::robo_caller_impl::RoboCallerReceivers::Foreach()
STDERR: #9 0x7f81c72d6e8e webrtc::webrtc_function_impl::CallHelpers<>::CallInlineStorage<>()
STDERR: #10 0x7f81c7348d99 webrtc::robo_caller_impl::RoboCallerReceivers::Foreach()
STDERR: #11 0x7f81c71c6df3 webrtc::webrtc_function_impl::CallHelpers<>::CallInlineStorage<>()
STDERR: #12 0x7f81c7348d99 webrtc::robo_caller_impl::RoboCallerReceivers::Foreach()
STDERR: #13 0x7f81c73135bc rtc::OpenSSLStreamAdapter::ContinueSSL()
STDERR: #14 0x7f81c7312fd4 rtc::OpenSSLStreamAdapter::OnEvent()
STDERR: #15 0x7f81c71c30d9 cricket::StreamInterfaceChannel::OnPacketReceived()
STDERR: #16 0x7f81c71c640a cricket::DtlsTransport::OnReadPacket()
STDERR: #17 0x7f81c71cad61 cricket::P2PTransportChannel::OnReadPacket()
STDERR: #18 0x7f81c71bc90f cricket::Connection::OnReadPacket()
STDERR: #19 0x7f81c71e6255 cricket::UDPPort::HandleIncomingPacket()
STDERR: #20 0x7f81cd1f1bff blink::(anonymous namespace)::IpcPacketSocket::OnDataReceived()
STDERR: #21 0x7f81cd1f645d blink::P2PSocketClientImpl::DataReceived()
STDERR: #22 0x7f81cd50a16b network::mojom::blink::P2PSocketClientStubDispatch::Accept()
STDERR: #23 0x7f81d2b4f642 mojo::InterfaceEndpointClient::HandleValidatedMessage()
STDERR: #24 0x7f81d2b5304b mojo::MessageDispatcher::Accept()
STDERR: #25 0x7f81d2b50bb1 mojo::InterfaceEndpointClient::HandleIncomingMessage()
STDERR: #26 0x7f81d2b58a3a mojo::internal::MultiplexRouter::ProcessIncomingMessage()
STDERR: #27 0x7f81d2b57f7f mojo::internal::MultiplexRouter::Accept()
STDERR: #28 0x7f81d2b5304b mojo::MessageDispatcher::Accept()
STDERR: #29 0x7f81d2b48851 mojo::Connector::DispatchMessage()
STDERR: #30 0x7f81d2b492e7 mojo::Connector::ReadAllAvailableMessages()
STDERR: #31 0x7f81d2b490a3 mojo::Connector::OnHandleReadyInternal()
STDERR: #32 0x7f81d2b498f0 mojo::SimpleWatcher::DiscardReadyState()
STDERR: #33 0x7f81d2d0e67a mojo::SimpleWatcher::OnHandleReady()
STDERR: #34 0x7f81d2d0eb2b base::internal::Invoker<>::RunOnce()
STDERR: #35 0x7f81d397f85b base::TaskAnnotator::RunTask()
STDERR: #36 0x7f81d399a04c base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
STDERR: #37 0x7f81d3999c78 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
STDERR: #38 0x7f81d391fe64 base::MessagePumpDefault::Run()
STDERR: #39 0x7f81d399a8dc base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
STDERR: #40 0x7f81d395ae55 base::RunLoop::Run()
STDERR: #41 0x7f81d39c87f2 base::Thread::Run()
Original change's description:
> Reland "Replace sigslot usages with robocaller library."
>
> This is a reland of 40261c3663fe316cfe40262c59cee993165ccf63
>
> Note: Instead of changing the type of JsepTransportController->SignalSSLHandshakeError
> added a new member with a different name and used it in webrtc code.
> After this change do two more follow up CLs to completely remove the old code
> from google3.
>
> Original change's description:
> > Replace sigslot usages with robocaller library.
> >
> > - Replace all the top level signals from jsep_transport_controller.
> > - There are still sigslot usages in this file so keep the inheritance
> > and that is the reason for not having a binary size gain in this CL.
> >
> > Bug: webrtc:11943
> > Change-Id: I249d3b9710783aef70ba273e082ceeafe3056898
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185540
> > Commit-Queue: Lahiru Ginnaliya Gamathige <glahiru@webrtc.org>
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#32321}
>
> Bug: webrtc:11943
> Change-Id: Ia07394ee395f94836f6b576c3a97d119a7678e1a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186946
> Commit-Queue: Lahiru Ginnaliya Gamathige <glahiru@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32359}
TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,glahiru@webrtc.org
Change-Id: I6bce1775d10758ac4a9d05b855f473dd70bd9815
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11943
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187487
Reviewed-by: Guido Urdaneta <guidou@webrtc.org>
Commit-Queue: Guido Urdaneta <guidou@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32372}
2020-10-09 18:07:56 +00:00
..
2020-09-29 10:19:20 +00:00
2020-09-22 07:26:26 +00:00
2019-11-27 12:52:48 +00:00
2020-10-05 13:46:03 +00:00
2020-06-08 12:59:40 +00:00
2020-09-18 17:42:53 +00:00
2020-05-26 20:27:34 +00:00
2020-09-30 14:47:04 +00:00
2020-10-07 07:37:01 +00:00
2020-10-07 07:37:01 +00:00
2020-01-21 12:13:11 +00:00
2020-01-21 12:13:11 +00:00
2020-04-02 09:54:27 +00:00
2020-10-02 07:29:31 +00:00
2020-07-16 13:52:28 +00:00
2020-07-08 10:46:20 +00:00
2020-09-07 12:57:15 +00:00
2020-03-02 11:36:58 +00:00
2020-01-28 19:16:18 +00:00
2019-02-20 16:02:59 +00:00
2019-10-15 09:07:44 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2020-02-03 21:19:57 +00:00
2020-02-03 21:19:57 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:05:20 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-11-27 19:34:54 +00:00
2019-11-27 19:34:54 +00:00
2020-07-08 11:41:20 +00:00
2020-07-08 11:41:20 +00:00
2019-07-03 13:30:01 +00:00
2020-03-02 20:55:28 +00:00
2020-03-02 20:55:28 +00:00
2020-03-02 20:55:28 +00:00
2019-01-11 17:11:39 +00:00
2020-09-29 12:57:20 +00:00
2020-10-07 07:37:01 +00:00
2020-05-26 20:27:34 +00:00
2020-05-29 11:42:06 +00:00
2020-10-09 18:07:56 +00:00
2019-11-15 11:48:42 +00:00
2019-11-15 11:48:42 +00:00
2019-11-15 11:48:42 +00:00
2019-07-08 13:45:15 +00:00
2019-03-31 11:55:09 +00:00
2019-01-11 17:11:39 +00:00
2019-01-25 20:29:58 +00:00
2019-01-25 20:29:58 +00:00
2020-05-26 20:27:34 +00:00
2019-11-28 17:51:00 +00:00
2020-06-12 14:12:54 +00:00
2020-09-29 10:19:20 +00:00
2019-09-26 09:48:07 +00:00
2019-09-26 09:48:07 +00:00
2019-10-15 09:07:44 +00:00
2020-01-15 13:36:58 +00:00
2019-01-11 17:11:39 +00:00
2018-11-28 18:25:07 +00:00
2019-05-15 23:54:07 +00:00
2019-05-10 07:07:19 +00:00
2019-05-10 07:07:19 +00:00
2018-11-28 18:25:07 +00:00
2019-10-15 09:07:44 +00:00
2020-06-04 09:55:12 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2018-11-28 18:25:07 +00:00
2019-04-11 16:35:18 +00:00
2019-04-11 16:35:18 +00:00
2020-02-10 12:21:17 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2019-03-02 10:18:01 +00:00
2020-09-07 12:57:15 +00:00
2020-04-16 14:21:41 +00:00
2020-04-16 14:21:41 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2019-08-08 08:29:18 +00:00
2018-12-17 17:33:06 +00:00
2020-02-10 12:21:17 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-10-15 09:07:44 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:05:20 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-04-24 20:57:20 +00:00
2020-03-02 11:36:58 +00:00
2020-03-02 11:36:58 +00:00
2019-01-25 20:29:58 +00:00
2019-12-03 19:43:12 +00:00
2020-09-30 13:58:29 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2020-09-21 20:42:59 +00:00
2020-09-21 20:42:59 +00:00
2020-09-22 12:08:38 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-10-25 12:07:32 +00:00
2019-10-25 12:07:32 +00:00
2018-11-28 18:25:07 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2020-09-25 11:44:02 +00:00
2020-09-25 11:44:02 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2020-01-10 19:03:12 +00:00
2020-01-10 19:03:12 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-09-17 15:47:29 +00:00
2020-03-02 11:36:58 +00:00
2020-03-02 11:36:58 +00:00
2020-05-26 20:07:14 +00:00
2020-10-07 07:37:01 +00:00
2020-04-02 07:48:36 +00:00
2020-04-02 07:48:36 +00:00
2020-08-13 20:50:23 +00:00
2020-08-13 20:50:23 +00:00
2020-09-11 18:22:14 +00:00
2020-09-11 18:22:14 +00:00
2020-03-24 11:48:42 +00:00
2020-03-24 11:48:42 +00:00
2020-03-30 13:02:46 +00:00
2020-09-11 18:22:14 +00:00
2020-08-20 21:46:18 +00:00
2020-09-07 12:57:15 +00:00
2020-09-07 12:57:15 +00:00
2019-07-08 13:45:15 +00:00
2020-05-06 20:19:49 +00:00
2019-01-11 17:11:39 +00:00
2020-07-08 20:38:54 +00:00
2020-05-14 19:33:26 +00:00
2020-04-14 11:00:49 +00:00
2020-09-07 12:57:15 +00:00
2019-09-17 15:47:29 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2020-04-16 20:56:25 +00:00
2020-04-16 20:56:25 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2020-10-09 18:07:56 +00:00
2020-10-05 13:46:03 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2020-08-25 16:11:22 +00:00
2020-10-06 14:10:36 +00:00
2020-10-07 07:37:01 +00:00
2020-02-19 14:05:46 +00:00
2020-08-31 20:26:37 +00:00
2020-08-31 20:26:37 +00:00
2020-08-31 20:26:37 +00:00
2020-05-17 17:22:01 +00:00
2019-03-04 12:42:10 +00:00
2019-05-03 08:35:42 +00:00
2019-07-08 13:45:15 +00:00
2019-05-06 07:34:09 +00:00
2019-02-16 11:11:45 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-09-17 15:47:29 +00:00
2019-03-28 13:33:30 +00:00
2019-07-08 13:45:15 +00:00
2018-10-23 11:32:56 +00:00
2020-09-18 17:42:53 +00:00
2020-09-29 10:19:20 +00:00
2019-07-08 13:45:15 +00:00
2020-07-08 20:38:54 +00:00
2020-09-29 10:19:20 +00:00
2020-01-15 13:46:38 +00:00
2020-05-25 12:14:44 +00:00
2020-05-25 12:14:44 +00:00
2020-01-15 13:46:38 +00:00
2020-01-15 13:46:38 +00:00
2020-01-15 13:46:38 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-11-26 14:05:20 +00:00
2020-10-07 01:26:06 +00:00
2020-09-30 06:59:44 +00:00
2020-09-30 06:59:44 +00:00
2019-07-08 13:45:15 +00:00
2020-09-18 17:42:53 +00:00
2020-04-15 09:30:07 +00:00
2020-09-14 14:48:39 +00:00
2019-10-15 09:07:44 +00:00
2020-03-21 18:53:46 +00:00
2020-03-21 18:53:46 +00:00
2019-10-15 09:07:44 +00:00
2018-11-28 18:25:07 +00:00
2018-11-26 19:20:27 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2020-05-28 07:52:53 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-04-09 17:18:20 +00:00
2019-01-11 17:11:39 +00:00
2019-12-10 08:32:10 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2020-01-03 18:42:32 +00:00
2019-10-15 09:07:44 +00:00
2019-01-11 17:11:39 +00:00
2020-01-10 19:03:12 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2020-09-07 12:57:15 +00:00
2020-08-31 20:26:37 +00:00
2019-07-08 13:45:15 +00:00
2020-01-07 09:54:44 +00:00
2020-05-14 19:33:26 +00:00
2019-01-11 17:11:39 +00:00
2020-04-14 11:00:49 +00:00
2019-09-17 15:47:29 +00:00
2019-10-15 09:07:44 +00:00
2019-09-17 15:47:29 +00:00
2019-10-15 09:07:44 +00:00
2020-03-21 18:53:46 +00:00
2020-04-16 14:21:41 +00:00
2020-04-16 20:56:25 +00:00
2020-09-03 14:18:18 +00:00
2020-10-05 13:46:03 +00:00
2020-03-21 18:53:46 +00:00
2020-10-09 18:07:56 +00:00
2020-10-05 13:46:03 +00:00
2020-10-05 13:46:03 +00:00
2019-07-08 13:45:15 +00:00
2019-08-29 14:16:23 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2018-10-23 11:32:56 +00:00
2019-07-30 19:35:37 +00:00
2020-09-17 13:18:25 +00:00
2020-09-17 13:18:25 +00:00
2020-05-26 20:27:34 +00:00
2020-09-16 14:08:55 +00:00
2019-03-19 18:11:52 +00:00
2020-05-04 13:47:35 +00:00
2020-03-18 16:06:09 +00:00
2019-02-20 17:08:53 +00:00
2020-07-08 20:38:54 +00:00
2019-02-12 10:58:36 +00:00
2020-07-08 20:38:54 +00:00
2019-02-21 14:36:07 +00:00
2019-03-26 14:42:49 +00:00
2020-07-08 20:38:54 +00:00
2019-02-21 09:33:42 +00:00
2019-04-10 10:27:07 +00:00
2019-09-17 15:47:29 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-09-17 15:47:29 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-04-08 16:58:07 +00:00
2020-01-20 14:07:16 +00:00
2020-09-07 12:57:15 +00:00
2020-09-25 11:44:02 +00:00
2020-10-01 16:38:09 +00:00
2020-02-10 12:21:17 +00:00
2020-07-01 17:21:02 +00:00
2020-01-28 19:16:18 +00:00
2020-03-10 17:22:54 +00:00
2020-03-10 17:22:54 +00:00
2020-03-10 17:22:54 +00:00
2019-11-28 15:58:24 +00:00
2019-07-08 13:45:15 +00:00
2019-02-09 00:55:14 +00:00
2019-02-09 00:55:14 +00:00
2020-10-07 01:26:06 +00:00
2020-10-07 01:26:06 +00:00
2020-07-17 09:19:50 +00:00
2020-09-07 12:57:15 +00:00
2020-09-07 12:57:15 +00:00
2019-10-15 09:17:36 +00:00
2019-04-09 12:28:04 +00:00
2020-10-07 07:37:01 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2020-07-08 20:38:54 +00:00
2020-07-08 20:38:54 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2019-10-22 16:15:56 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-05-22 10:32:25 +00:00
2018-11-28 18:25:07 +00:00
2019-07-08 13:45:15 +00:00