
Macro incorrectly displays DISABLED_ON_ANDROID in test names for parameterized tests under --gtest_list_tests, causing tests to be disabled on all platforms since they contain the DISABLED_ prefix rather than their expanded variants. This expands the macro variants to inline if they're disabled or not, and removes building some tests under configurations where they should fail, instead of building them but disabling them by default. The change also removes gtest_disable.h as an unused include from many other files. BUG=webrtc:5387, webrtc:5400 R=kjellander@webrtc.org, phoglund@webrtc.org TBR=henrik.lundin@webrtc.org Review URL: https://codereview.webrtc.org/1547343002 . Cr-Commit-Position: refs/heads/master@{#11150}
250 lines
9.0 KiB
C++
250 lines
9.0 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "webrtc/modules/audio_coding/neteq/decoder_database.h"
|
|
|
|
#include <assert.h>
|
|
#include <stdlib.h>
|
|
|
|
#include <string>
|
|
|
|
#include "testing/gmock/include/gmock/gmock.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
#include "webrtc/modules/audio_coding/neteq/mock/mock_audio_decoder.h"
|
|
|
|
namespace webrtc {
|
|
|
|
TEST(DecoderDatabase, CreateAndDestroy) {
|
|
DecoderDatabase db;
|
|
EXPECT_EQ(0, db.Size());
|
|
EXPECT_TRUE(db.Empty());
|
|
}
|
|
|
|
TEST(DecoderDatabase, InsertAndRemove) {
|
|
DecoderDatabase db;
|
|
const uint8_t kPayloadType = 0;
|
|
const std::string kCodecName = "Robert\'); DROP TABLE Students;";
|
|
EXPECT_EQ(
|
|
DecoderDatabase::kOK,
|
|
db.RegisterPayload(kPayloadType, NetEqDecoder::kDecoderPCMu, kCodecName));
|
|
EXPECT_EQ(1, db.Size());
|
|
EXPECT_FALSE(db.Empty());
|
|
EXPECT_EQ(DecoderDatabase::kOK, db.Remove(kPayloadType));
|
|
EXPECT_EQ(0, db.Size());
|
|
EXPECT_TRUE(db.Empty());
|
|
}
|
|
|
|
TEST(DecoderDatabase, GetDecoderInfo) {
|
|
DecoderDatabase db;
|
|
const uint8_t kPayloadType = 0;
|
|
const std::string kCodecName = "Robert\'); DROP TABLE Students;";
|
|
EXPECT_EQ(
|
|
DecoderDatabase::kOK,
|
|
db.RegisterPayload(kPayloadType, NetEqDecoder::kDecoderPCMu, kCodecName));
|
|
const DecoderDatabase::DecoderInfo* info;
|
|
info = db.GetDecoderInfo(kPayloadType);
|
|
ASSERT_TRUE(info != NULL);
|
|
EXPECT_EQ(NetEqDecoder::kDecoderPCMu, info->codec_type);
|
|
EXPECT_EQ(NULL, info->decoder);
|
|
EXPECT_EQ(8000, info->fs_hz);
|
|
EXPECT_EQ(kCodecName, info->name);
|
|
EXPECT_FALSE(info->external);
|
|
info = db.GetDecoderInfo(kPayloadType + 1); // Other payload type.
|
|
EXPECT_TRUE(info == NULL); // Should not be found.
|
|
}
|
|
|
|
TEST(DecoderDatabase, GetRtpPayloadType) {
|
|
DecoderDatabase db;
|
|
const uint8_t kPayloadType = 0;
|
|
const std::string kCodecName = "Robert\'); DROP TABLE Students;";
|
|
EXPECT_EQ(
|
|
DecoderDatabase::kOK,
|
|
db.RegisterPayload(kPayloadType, NetEqDecoder::kDecoderPCMu, kCodecName));
|
|
EXPECT_EQ(kPayloadType, db.GetRtpPayloadType(NetEqDecoder::kDecoderPCMu));
|
|
const uint8_t expected_value = DecoderDatabase::kRtpPayloadTypeError;
|
|
EXPECT_EQ(expected_value,
|
|
db.GetRtpPayloadType(
|
|
NetEqDecoder::kDecoderISAC)); // iSAC is not registered.
|
|
}
|
|
|
|
TEST(DecoderDatabase, GetDecoder) {
|
|
DecoderDatabase db;
|
|
const uint8_t kPayloadType = 0;
|
|
const std::string kCodecName = "Robert\'); DROP TABLE Students;";
|
|
EXPECT_EQ(DecoderDatabase::kOK,
|
|
db.RegisterPayload(kPayloadType, NetEqDecoder::kDecoderPCM16B,
|
|
kCodecName));
|
|
AudioDecoder* dec = db.GetDecoder(kPayloadType);
|
|
ASSERT_TRUE(dec != NULL);
|
|
}
|
|
|
|
TEST(DecoderDatabase, TypeTests) {
|
|
DecoderDatabase db;
|
|
const uint8_t kPayloadTypePcmU = 0;
|
|
const uint8_t kPayloadTypeCng = 13;
|
|
const uint8_t kPayloadTypeDtmf = 100;
|
|
const uint8_t kPayloadTypeRed = 101;
|
|
const uint8_t kPayloadNotUsed = 102;
|
|
// Load into database.
|
|
EXPECT_EQ(
|
|
DecoderDatabase::kOK,
|
|
db.RegisterPayload(kPayloadTypePcmU, NetEqDecoder::kDecoderPCMu, "pcmu"));
|
|
EXPECT_EQ(DecoderDatabase::kOK,
|
|
db.RegisterPayload(kPayloadTypeCng, NetEqDecoder::kDecoderCNGnb,
|
|
"cng-nb"));
|
|
EXPECT_EQ(
|
|
DecoderDatabase::kOK,
|
|
db.RegisterPayload(kPayloadTypeDtmf, NetEqDecoder::kDecoderAVT, "avt"));
|
|
EXPECT_EQ(
|
|
DecoderDatabase::kOK,
|
|
db.RegisterPayload(kPayloadTypeRed, NetEqDecoder::kDecoderRED, "red"));
|
|
EXPECT_EQ(4, db.Size());
|
|
// Test.
|
|
EXPECT_FALSE(db.IsComfortNoise(kPayloadNotUsed));
|
|
EXPECT_FALSE(db.IsDtmf(kPayloadNotUsed));
|
|
EXPECT_FALSE(db.IsRed(kPayloadNotUsed));
|
|
EXPECT_FALSE(db.IsComfortNoise(kPayloadTypePcmU));
|
|
EXPECT_FALSE(db.IsDtmf(kPayloadTypePcmU));
|
|
EXPECT_FALSE(db.IsRed(kPayloadTypePcmU));
|
|
EXPECT_FALSE(db.IsType(kPayloadTypePcmU, NetEqDecoder::kDecoderISAC));
|
|
EXPECT_TRUE(db.IsType(kPayloadTypePcmU, NetEqDecoder::kDecoderPCMu));
|
|
EXPECT_TRUE(db.IsComfortNoise(kPayloadTypeCng));
|
|
EXPECT_TRUE(db.IsDtmf(kPayloadTypeDtmf));
|
|
EXPECT_TRUE(db.IsRed(kPayloadTypeRed));
|
|
}
|
|
|
|
TEST(DecoderDatabase, ExternalDecoder) {
|
|
DecoderDatabase db;
|
|
const uint8_t kPayloadType = 0;
|
|
const std::string kCodecName = "Robert\'); DROP TABLE Students;";
|
|
MockAudioDecoder decoder;
|
|
// Load into database.
|
|
EXPECT_EQ(DecoderDatabase::kOK,
|
|
db.InsertExternal(kPayloadType, NetEqDecoder::kDecoderPCMu,
|
|
kCodecName, 8000, &decoder));
|
|
EXPECT_EQ(1, db.Size());
|
|
// Get decoder and make sure we get the external one.
|
|
EXPECT_EQ(&decoder, db.GetDecoder(kPayloadType));
|
|
// Get the decoder info struct and check it too.
|
|
const DecoderDatabase::DecoderInfo* info;
|
|
info = db.GetDecoderInfo(kPayloadType);
|
|
ASSERT_TRUE(info != NULL);
|
|
EXPECT_EQ(NetEqDecoder::kDecoderPCMu, info->codec_type);
|
|
EXPECT_EQ(kCodecName, info->name);
|
|
EXPECT_EQ(&decoder, info->decoder);
|
|
EXPECT_EQ(8000, info->fs_hz);
|
|
EXPECT_TRUE(info->external);
|
|
// Expect not to delete the decoder when removing it from the database, since
|
|
// it was declared externally.
|
|
EXPECT_CALL(decoder, Die()).Times(0);
|
|
EXPECT_EQ(DecoderDatabase::kOK, db.Remove(kPayloadType));
|
|
EXPECT_TRUE(db.Empty());
|
|
|
|
EXPECT_CALL(decoder, Die()).Times(1); // Will be called when |db| is deleted.
|
|
}
|
|
|
|
TEST(DecoderDatabase, CheckPayloadTypes) {
|
|
DecoderDatabase db;
|
|
// Load a number of payloads into the database. Payload types are 0, 1, ...,
|
|
// while the decoder type is the same for all payload types (this does not
|
|
// matter for the test).
|
|
const int kNumPayloads = 10;
|
|
for (uint8_t payload_type = 0; payload_type < kNumPayloads; ++payload_type) {
|
|
EXPECT_EQ(
|
|
DecoderDatabase::kOK,
|
|
db.RegisterPayload(payload_type, NetEqDecoder::kDecoderArbitrary, ""));
|
|
}
|
|
PacketList packet_list;
|
|
for (int i = 0; i < kNumPayloads + 1; ++i) {
|
|
// Create packet with payload type |i|. The last packet will have a payload
|
|
// type that is not registered in the decoder database.
|
|
Packet* packet = new Packet;
|
|
packet->header.payloadType = i;
|
|
packet_list.push_back(packet);
|
|
}
|
|
|
|
// Expect to return false, since the last packet is of an unknown type.
|
|
EXPECT_EQ(DecoderDatabase::kDecoderNotFound,
|
|
db.CheckPayloadTypes(packet_list));
|
|
|
|
delete packet_list.back();
|
|
packet_list.pop_back(); // Remove the unknown one.
|
|
|
|
EXPECT_EQ(DecoderDatabase::kOK, db.CheckPayloadTypes(packet_list));
|
|
|
|
// Delete all packets.
|
|
PacketList::iterator it = packet_list.begin();
|
|
while (it != packet_list.end()) {
|
|
delete packet_list.front();
|
|
it = packet_list.erase(it);
|
|
}
|
|
}
|
|
|
|
#if defined(WEBRTC_CODEC_ISAC) || defined(WEBRTC_CODEC_ISACFX)
|
|
#define IF_ISAC(x) x
|
|
#else
|
|
#define IF_ISAC(x) DISABLED_##x
|
|
#endif
|
|
|
|
// Test the methods for setting and getting active speech and CNG decoders.
|
|
TEST(DecoderDatabase, IF_ISAC(ActiveDecoders)) {
|
|
DecoderDatabase db;
|
|
// Load payload types.
|
|
ASSERT_EQ(DecoderDatabase::kOK,
|
|
db.RegisterPayload(0, NetEqDecoder::kDecoderPCMu, "pcmu"));
|
|
ASSERT_EQ(DecoderDatabase::kOK,
|
|
db.RegisterPayload(103, NetEqDecoder::kDecoderISAC, "isac"));
|
|
ASSERT_EQ(DecoderDatabase::kOK,
|
|
db.RegisterPayload(13, NetEqDecoder::kDecoderCNGnb, "cng-nb"));
|
|
// Verify that no decoders are active from the start.
|
|
EXPECT_EQ(NULL, db.GetActiveDecoder());
|
|
EXPECT_EQ(NULL, db.GetActiveCngDecoder());
|
|
|
|
// Set active speech codec.
|
|
bool changed; // Should be true when the active decoder changed.
|
|
EXPECT_EQ(DecoderDatabase::kOK, db.SetActiveDecoder(0, &changed));
|
|
EXPECT_TRUE(changed);
|
|
AudioDecoder* decoder = db.GetActiveDecoder();
|
|
ASSERT_FALSE(decoder == NULL); // Should get a decoder here.
|
|
|
|
// Set the same again. Expect no change.
|
|
EXPECT_EQ(DecoderDatabase::kOK, db.SetActiveDecoder(0, &changed));
|
|
EXPECT_FALSE(changed);
|
|
decoder = db.GetActiveDecoder();
|
|
ASSERT_FALSE(decoder == NULL); // Should get a decoder here.
|
|
|
|
// Change active decoder.
|
|
EXPECT_EQ(DecoderDatabase::kOK, db.SetActiveDecoder(103, &changed));
|
|
EXPECT_TRUE(changed);
|
|
decoder = db.GetActiveDecoder();
|
|
ASSERT_FALSE(decoder == NULL); // Should get a decoder here.
|
|
|
|
// Remove the active decoder, and verify that the active becomes NULL.
|
|
EXPECT_EQ(DecoderDatabase::kOK, db.Remove(103));
|
|
EXPECT_EQ(NULL, db.GetActiveDecoder());
|
|
|
|
// Set active CNG codec.
|
|
EXPECT_EQ(DecoderDatabase::kOK, db.SetActiveCngDecoder(13));
|
|
decoder = db.GetActiveCngDecoder();
|
|
ASSERT_FALSE(decoder == NULL); // Should get a decoder here.
|
|
|
|
// Remove the active CNG decoder, and verify that the active becomes NULL.
|
|
EXPECT_EQ(DecoderDatabase::kOK, db.Remove(13));
|
|
EXPECT_EQ(NULL, db.GetActiveCngDecoder());
|
|
|
|
// Try to set non-existing codecs as active.
|
|
EXPECT_EQ(DecoderDatabase::kDecoderNotFound,
|
|
db.SetActiveDecoder(17, &changed));
|
|
EXPECT_EQ(DecoderDatabase::kDecoderNotFound,
|
|
db.SetActiveCngDecoder(17));
|
|
}
|
|
} // namespace webrtc
|