f5ecb5f22e
This reverts commit 9cad4dccc96f09d76dce3766a076052df7d75ab8. Reason for revert: Breaks downstream tests. Original change's description: > Reland "Reland "Reland "Distinguish between send and receive video codecs""" > > This is a reland of 4e64e605894df287178c5a1b537fbe859b7d420c > > This CL lands all code except the code that activates the change, > see media/engine/webrtc_video_engine.cc > Once downstream projects are fixed, there will be a one-line change to > activate the change to distinguish between send and receive video codecs. > > Original change's description: > > Reland "Reland "Distinguish between send and receive video codecs"" > > > > This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228 > > > > Original change's description: > > > Reland "Distinguish between send and receive video codecs" > > > > > > This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03. > > > > > > Reason for revert: Downstream test updated. > > > > > > Original change's description: > > > > Revert "Reland "Distinguish between send and receive video codecs"" > > > > > > > > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145. > > > > > > > > Reason for revert: Breaks another downstream test. > > > > > > > > Original change's description: > > > > > Reland "Distinguish between send and receive video codecs" > > > > > > > > > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d. > > > > > > > > > > Reason for revert: Downstream tests have been updated. > > > > > > > > > > Original change's description: > > > > > > Revert "Distinguish between send and receive video codecs" > > > > > > > > > > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba. > > > > > > > > > > > > Reason for revert: Breaks downstream test. > > > > > > > > > > > > Original change's description: > > > > > > > Distinguish between send and receive video codecs > > > > > > > > > > > > > > Even though send and receive codecs are the same, > > > > > > > they might have different support in HW. > > > > > > > Distinguish between send and receive codecs to be able to keep > > > > > > > track of which codecs have HW support. > > > > > > > > > > > > > > Bug: chromium:1029737 > > > > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306 > > > > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org> > > > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org> > > > > > > > Cr-Commit-Position: refs/heads/master@{#30041} > > > > > > > > > > > > TBR=steveanton@webrtc.org,andersc@webrtc.org,kron@webrtc.org > > > > > > > > > > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd > > > > > > No-Presubmit: true > > > > > > No-Tree-Checks: true > > > > > > No-Try: true > > > > > > Bug: chromium:1029737 > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662 > > > > > > Reviewed-by: Johannes Kron <kron@webrtc.org> > > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#30042} > > > > > > > > > > TBR=steveanton@webrtc.org,andersc@webrtc.org,kron@webrtc.org > > > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > > > Bug: chromium:1029737 > > > > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734 > > > > > Reviewed-by: Johannes Kron <kron@webrtc.org> > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org> > > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#30078} > > > > > > > > TBR=steveanton@webrtc.org,andersc@webrtc.org,kron@webrtc.org > > > > > > > > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: chromium:1029737 > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140 > > > > Reviewed-by: Johannes Kron <kron@webrtc.org> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#30079} > > > > > > TBR=steveanton@webrtc.org,andersc@webrtc.org,kron@webrtc.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: chromium:1029737 > > > Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8 > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186 > > > Reviewed-by: Johannes Kron <kron@webrtc.org> > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org> > > > Commit-Queue: Johannes Kron <kron@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#30097} > > > > Bug: chromium:1029737 > > Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483 > > Reviewed-by: Steve Anton <steveanton@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Commit-Queue: Johannes Kron <kron@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#30120} > > Bug: chromium:1029737 > Change-Id: Id4f1c6f6f0cf7b96fe93dd22d14310d286af31f3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165682 > Reviewed-by: Steve Anton <steveanton@webrtc.org> > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Commit-Queue: Johannes Kron <kron@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#30219} TBR=steveanton@webrtc.org,andersc@webrtc.org,kron@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1029737 Change-Id: I377f82866e56862f57383f96a3b96719344eef9e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165780 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30225}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.