zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
7ef8093f2e8fd795a5977d6d93ab89e953c7619f
platform-external-webrtc/modules/video_coding
History
Guido Urdaneta 7ef8093f2e Revert "NV12 support for VP8 simulcast" 
This reverts commit 76d3e7a8d1539483a8465d6502cc8259e74ccebf.

Reason for revert: Causes multiple Chromium WPT tests to crash, preventing rolls.

Sample failed run:
https://ci.chromium.org/p/chromium/builders/try/win10_chromium_x64_rel_ng/685757?

Sample stack trace:
#0 0x7ff8623fbde9 base::debug::CollectStackTrace()
STDERR: #1 0x7ff862311ca3 [2665012:17:1009/162250.249660:WARNING:timestamp_aligner.cc(131)] too short translated timestamp interval: system time (us) = 3042652370324, interval (us) = 834
STDERR: base::debug::StackTrace::StackTrace()
STDERR: #2 0x7ff8623fb93b base::debug::(anonymous namespace)::StackDumpSignalHandler()
STDERR: #3 0x7ff857a70140 [2665012:17:1009/162250.249947:WARNING:timestamp_aligner.cc(131)] too short translated timestamp interval: system time (us) = 3042652370634, interval (us) = 742
STDERR: (/lib/x86_64-linux-gnu/libpthread-2.31.so+0x1413f)
STDERR: #4 0x7ff85778edb1 gsignal
STDERR: #5 0x7ff857778537 abort
STDERR: #6 0x7ff855d5eee2 [2665012:17:1009/162250.250342:WARNING:timestamp_aligner.cc(131)] too short translated timestamp interval: system time (us) = 3042652371030, interval (us) = 706
STDERR: [2665012:17:1009/162250.250514:WARNING:timestamp_aligner.cc(131)] too short translated timestamp interval: system time (us) = 3042652371204, interval (us) = 963
STDERR: rtc::webrtc_checks_impl::FatalLog()
STDERR: #7 0x7ff855f14e62 webrtc::LibvpxVp8Encoder::PrepareRawImagesForEncoding()
STDERR: #8 0x7ff855f14412 webrtc::LibvpxVp8Encoder::Encode()
STDERR: #9 0x7ff855bae765 webrtc::SimulcastEncoderAdapter::Encode()
STDERR: #10 0x7ff85607d598 webrtc::VideoStreamEncoder::EncodeVideoFrame()
STDERR: #11 0x7ff85607c60d webrtc::VideoStreamEncoder::MaybeEncodeVideoFrame()
STDERR: #12 0x7ff8560816f5 webrtc::webrtc_new_closure_impl::ClosureTask<>::Run()
STDERR: #13 0x7ff855b352b5 (anonymous namespace)::WebrtcTaskQueue::RunTask()
STDERR: #14 0x7ff855b3531e base::internal::Invoker<>::RunOnce()
STDERR: #15 0x7ff86239785b base::TaskAnnotator::RunTask()
STDERR: #16 0x7ff8623c8557 base::internal::TaskTracker::RunSkipOnShutdown()
STDERR: #17 0x7ff8623c7d92 base::internal::TaskTracker::RunTask()
STDERR: #18 0x7ff862415a06 base::internal::TaskTrackerPosix::RunTask()
STDERR: #19 0x7ff8623c75e6 base::internal::TaskTracker::RunAndPopNextTask()
STDERR: #20 0x7ff8623d3a8d base::internal::WorkerThread::RunWorker()
STDERR: #21 0x7ff8623d368d base::internal::WorkerThread::RunPooledWorker()
STDERR: #22 0x7ff862416509 base::(anonymous namespace)::ThreadFunc()
STDERR: #23 0x7ff857a64ea7 start_thread 

Original change's description:
> NV12 support for VP8 simulcast
>
> Tested using video_loopback with generated NV12 frames.
>
> Bug: webrtc:11635, webrtc:11975
> Change-Id: I14b2d663c55a83d80e48e226fcf706cb18903193
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186722
> Commit-Queue: Evan Shrubsole <eshr@google.com>
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32325}

TBR=ilnik@webrtc.org,eshr@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:11635
Bug: webrtc:11975
Change-Id: I61c8aed1270bc9c2f7f0577fa5ca717a325f548a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187484
Reviewed-by: Guido Urdaneta <guidou@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Guido Urdaneta <guidou@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32369}
2020-10-09 15:32:33 +00:00
..
codecs
Revert "NV12 support for VP8 simulcast"
2020-10-09 15:32:33 +00:00
deprecated
Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 11:41:21 +00:00
include
Delete deprecated variant of VideoCodingModule::RegisterReceiveCodec
2020-08-11 08:44:50 +00:00
test
Include module_common_types.h only where needed
2019-09-24 08:22:38 +00:00
utility
Revert "Introduce RTC_NO_UNIQUE_ADDRESS."
2020-10-07 07:37:01 +00:00
BUILD.gn
Reland "Add scaling interface to VideoFrameBuffer"
2020-10-09 08:30:50 +00:00
chain_diff_calculator_unittest.cc
Introduce ChainDiffCalculator
2020-05-18 14:22:44 +00:00
chain_diff_calculator.cc
Introduce ChainDiffCalculator
2020-05-18 14:22:44 +00:00
chain_diff_calculator.h
Introduce ChainDiffCalculator
2020-05-18 14:22:44 +00:00
codec_timer.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
codec_timer.h
Include module_common_types.h only where needed
2019-09-24 08:22:38 +00:00
decoder_database.cc
Prepare for deleting VideoCodec::plType
2020-08-11 14:20:59 +00:00
decoder_database.h
Prepare for deleting VideoCodec::plType
2020-08-11 14:20:59 +00:00
decoding_state_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
decoding_state.cc
Concatenate string literals at compile time.
2020-01-14 14:47:48 +00:00
decoding_state.h
Delete root header file typedef.h.
2018-07-25 14:59:26 +00:00
DEPS
Add RTC_EXPORT to VCMEncodedFrame
2020-02-28 16:59:10 +00:00
encoded_frame.cc
Remove framemarking RTP extension.
2020-06-15 11:18:00 +00:00
encoded_frame.h
Rename PlayoutDelay --> VideoPlayoutDelay, move to api/video/video_timing.h
2020-09-07 08:37:14 +00:00
event_wrapper.cc
Move EventWrapper class to target video_coding_legacy.
2020-03-06 08:39:35 +00:00
event_wrapper.h
Move EventWrapper class to target video_coding_legacy.
2020-03-06 08:39:35 +00:00
fec_controller_default.cc
Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 11:41:21 +00:00
fec_controller_default.h
Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 11:41:21 +00:00
fec_controller_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
fec_rate_table.h
…
frame_buffer2_unittest.cc
Rename PlayoutDelay --> VideoPlayoutDelay, move to api/video/video_timing.h
2020-09-07 08:37:14 +00:00
frame_buffer2.cc
Removed FrameBuffer::Start function.
2020-07-30 11:15:56 +00:00
frame_buffer2.h
Revert "Introduce RTC_NO_UNIQUE_ADDRESS."
2020-10-07 07:37:01 +00:00
frame_buffer.cc
Reland "Delete the non-const version of the EncodedImage::data() method."
2020-09-28 13:51:51 +00:00
frame_buffer.h
Refactor legacy FrameBuffer to use EncodedImageBuffer::Realloc
2019-09-30 09:48:26 +00:00
frame_dependencies_calculator_unittest.cc
Add helper to calculate frame dependencies based on encoder buffer usage
2020-02-05 16:19:10 +00:00
frame_dependencies_calculator.cc
Populate generic descriptor based on GenericFrameInfo when available.
2020-02-12 10:55:41 +00:00
frame_dependencies_calculator.h
Populate generic descriptor based on GenericFrameInfo when available.
2020-02-12 10:55:41 +00:00
frame_object.cc
Reland "Delete the non-const version of the EncodedImage::data() method."
2020-09-28 13:51:51 +00:00
frame_object.h
Reland "Delete the non-const version of the EncodedImage::data() method."
2020-09-28 13:51:51 +00:00
generic_decoder_unittest.cc
Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 11:41:21 +00:00
generic_decoder.cc
Set processing time according to the decode time if provided by the decoder.
2020-10-02 13:55:09 +00:00
generic_decoder.h
Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 11:41:21 +00:00
h264_sprop_parameter_sets_unittest.cc
Fully qualify googletest symbols.
2019-04-09 17:18:20 +00:00
h264_sprop_parameter_sets.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
h264_sprop_parameter_sets.h
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
h264_sps_pps_tracker_unittest.cc
in PacketBuffer::Packet pass payload using smart buffer
2019-12-03 14:55:54 +00:00
h264_sps_pps_tracker.cc
H264: Fix stap-a-to-annex-b loop over-read
2020-06-24 21:54:45 +00:00
h264_sps_pps_tracker.h
in PacketBuffer::Packet pass payload using smart buffer
2019-12-03 14:55:54 +00:00
histogram_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
histogram.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
histogram.h
…
inter_frame_delay.cc
Remove unused method in VCMInterFrameDelay.
2019-04-03 07:35:28 +00:00
inter_frame_delay.h
Remove unused method in VCMInterFrameDelay.
2019-04-03 07:35:28 +00:00
internal_defines.h
Remove unused defines and methods in internal_defines.h
2019-01-28 10:31:40 +00:00
jitter_buffer_common.h
Format almost everything.
2019-07-08 13:45:15 +00:00
jitter_buffer_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
jitter_buffer.cc
Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 11:41:21 +00:00
jitter_buffer.h
Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 11:41:21 +00:00
jitter_estimator_tests.cc
Add option to disable reduced jitter delay through field trial.
2020-05-19 11:51:29 +00:00
jitter_estimator.cc
Add option to disable reduced jitter delay through field trial.
2020-05-19 11:51:29 +00:00
jitter_estimator.h
Add option to disable reduced jitter delay through field trial.
2020-05-19 11:51:29 +00:00
loss_notification_controller_unittest.cc
Detach LossNotificationController from RtpGenericFrameDescriptor
2020-01-24 11:53:28 +00:00
loss_notification_controller.cc
Detach LossNotificationController from RtpGenericFrameDescriptor
2020-01-24 11:53:28 +00:00
loss_notification_controller.h
Revert "Introduce RTC_NO_UNIQUE_ADDRESS."
2020-10-07 07:37:01 +00:00
media_opt_util.cc
Stop checking VP8BaseHeavyTl3RateAllocation field trial on every frame.
2019-11-04 13:50:59 +00:00
media_opt_util.h
Stop checking VP8BaseHeavyTl3RateAllocation field trial on every frame.
2019-11-04 13:50:59 +00:00
nack_module2_unittest.cc
Remove locks and dependency on ProcessThread+Module from NackModule2.
2020-05-27 14:20:34 +00:00
nack_module2.cc
Remove locks and dependency on ProcessThread+Module from NackModule2.
2020-05-27 14:20:34 +00:00
nack_module2.h
Remove locks and dependency on ProcessThread+Module from NackModule2.
2020-05-27 14:20:34 +00:00
nack_module_unittest.cc
Deprecate webrtc::NackModule.
2020-05-30 16:34:44 +00:00
OWNERS
Remove wildcard ownership for build files.
2020-02-19 14:05:46 +00:00
packet_buffer_unittest.cc
Add new fmtp parameter for H.264
2020-08-07 10:32:41 +00:00
packet_buffer.cc
Add new fmtp parameter for H.264
2020-08-07 10:32:41 +00:00
packet_buffer.h
Move ABSL_MUST_USE_RESULT at the beginning of the method decl.
2020-08-31 08:19:29 +00:00
packet.cc
Add plumbing of RtpPacketInfos to each VideoFrame as input for SourceTracker.
2019-06-20 10:24:29 +00:00
packet.h
Add plumbing of RtpPacketInfos to each VideoFrame as input for SourceTracker.
2019-06-20 10:24:29 +00:00
receiver_unittest.cc
Move EventWrapper class to target video_coding_legacy.
2020-03-06 08:39:35 +00:00
receiver.cc
Concatenate string literals at compile time.
2020-01-14 14:47:48 +00:00
receiver.h
Remove unused critical section includes.
2020-07-16 13:52:28 +00:00
rtp_frame_reference_finder_unittest.cc
Remove framemarking RTP extension.
2020-06-15 11:18:00 +00:00
rtp_frame_reference_finder.cc
Remove framemarking RTP extension.
2020-06-15 11:18:00 +00:00
rtp_frame_reference_finder.h
Remove unused critical section includes.
2020-07-16 13:52:28 +00:00
rtt_filter.cc
Fix typo in VCMRttFilter
2018-01-26 10:59:56 +00:00
rtt_filter.h
Delete root header file typedef.h.
2018-07-25 14:59:26 +00:00
session_info_unittest.cc
Include module_common_types.h only where needed
2019-09-24 08:22:38 +00:00
session_info.cc
Remove framemarking RTP extension.
2020-06-15 11:18:00 +00:00
session_info.h
Format almost everything.
2019-07-08 13:45:15 +00:00
timestamp_map.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
timestamp_map.h
Remove unimplemented function declarations VCMGenericDecoder::External and VCMTimestampMap::Reset.
2018-09-06 09:05:30 +00:00
timing_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
timing.cc
Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 11:41:21 +00:00
timing.h
Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 11:41:21 +00:00
unique_timestamp_counter_unittest.cc
Split out counting unique rtp timestamps from packet_buffer
2019-10-30 15:27:48 +00:00
unique_timestamp_counter.cc
Split out counting unique rtp timestamps from packet_buffer
2019-10-30 15:27:48 +00:00
unique_timestamp_counter.h
Split out counting unique rtp timestamps from packet_buffer
2019-10-30 15:27:48 +00:00
video_codec_initializer_unittest.cc
Make VP9 correctly accept middle-layer singlecast
2020-09-22 16:09:53 +00:00
video_codec_initializer.cc
Make VP9 correctly accept middle-layer singlecast
2020-09-22 16:09:53 +00:00
video_coding_defines.cc
Fix frames dropped statistics
2019-08-27 07:43:01 +00:00
video_coding_impl.cc
Delete deprecated variant of VideoCodingModule::RegisterReceiveCodec
2020-08-11 08:44:50 +00:00
video_coding_impl.h
Add a VideoCoding::RegisterReceiveCodec method with payload_type
2020-08-10 11:08:52 +00:00
video_receiver2.cc
Add a VideoCoding::RegisterReceiveCodec method with payload_type
2020-08-10 11:08:52 +00:00
video_receiver2.h
Add a VideoCoding::RegisterReceiveCodec method with payload_type
2020-08-10 11:08:52 +00:00
video_receiver_unittest.cc
Prepare for deleting VideoCodec::plType
2020-08-11 14:20:59 +00:00
video_receiver.cc
Remove RTPFragmentationHeader creation and propagation through webrtc
2020-08-17 16:37:33 +00:00