
functionalities doing sample-rate conversions: -The implicit resampling done in the AudioBuffer CopyTo, CopyFrom, InterleaveTo and DeinterleaveFrom methods. -The multi-band splitting scheme. The selection of rates in these have been difficult and complicated, partly due to that the APM API which allows for activating the APM submodules without notifying the APM. This CL adds functionality that for each capture frame polls all submodules for whether they are active or not and compares this against a cached result. Furthermore, new functionality is added that based on the results of the comparison do a reinitialization of the APM. This has several advantages -The code deciding on whether to analysis and synthesis is needed for the bandsplitting can be much simplified and centralized. -The selection of the processing rate can be done such as to avoid the implicit resampling that was in some cases unnecessarily done. -The optimization for whether an output copy is needed that was done to improve performance due to the implicit resampling is no longer needed, which simplifies the code and makes it less error-prone in the sense that is no longer neccessary to keep track of whether any module has changed the signal. Finally, it should be noted that the polling of the state for all the submodules was done previously as well, but in a less obvious and distributed manner. BUG=webrtc:6181, webrtc:6220, webrtc:5298, webrtc:6296, webrtc:6298, webrtc:6297 Review-Url: https://codereview.webrtc.org/2304123002 Cr-Commit-Position: refs/heads/master@{#14175}
94 lines
3.1 KiB
C++
94 lines
3.1 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CONTROL_MOBILE_IMPL_H_
|
|
#define WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CONTROL_MOBILE_IMPL_H_
|
|
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include "webrtc/base/constructormagic.h"
|
|
#include "webrtc/base/criticalsection.h"
|
|
#include "webrtc/base/swap_queue.h"
|
|
#include "webrtc/modules/audio_processing/include/audio_processing.h"
|
|
#include "webrtc/modules/audio_processing/render_queue_item_verifier.h"
|
|
|
|
namespace webrtc {
|
|
|
|
class AudioBuffer;
|
|
|
|
class EchoControlMobileImpl : public EchoControlMobile {
|
|
public:
|
|
EchoControlMobileImpl(rtc::CriticalSection* crit_render,
|
|
rtc::CriticalSection* crit_capture);
|
|
|
|
~EchoControlMobileImpl() override;
|
|
|
|
int ProcessRenderAudio(const AudioBuffer* audio);
|
|
int ProcessCaptureAudio(AudioBuffer* audio, int stream_delay_ms);
|
|
|
|
// EchoControlMobile implementation.
|
|
bool is_enabled() const override;
|
|
RoutingMode routing_mode() const override;
|
|
bool is_comfort_noise_enabled() const override;
|
|
|
|
void Initialize(int sample_rate_hz,
|
|
size_t num_reverse_channels,
|
|
size_t num_output_channels);
|
|
|
|
// Reads render side data that has been queued on the render call.
|
|
void ReadQueuedRenderData();
|
|
|
|
private:
|
|
class Canceller;
|
|
struct StreamProperties;
|
|
|
|
// EchoControlMobile implementation.
|
|
int Enable(bool enable) override;
|
|
int set_routing_mode(RoutingMode mode) override;
|
|
int enable_comfort_noise(bool enable) override;
|
|
int SetEchoPath(const void* echo_path, size_t size_bytes) override;
|
|
int GetEchoPath(void* echo_path, size_t size_bytes) const override;
|
|
|
|
size_t num_handles_required() const;
|
|
|
|
void AllocateRenderQueue();
|
|
int Configure();
|
|
|
|
rtc::CriticalSection* const crit_render_ ACQUIRED_BEFORE(crit_capture_);
|
|
rtc::CriticalSection* const crit_capture_;
|
|
|
|
bool enabled_ = false;
|
|
|
|
RoutingMode routing_mode_ GUARDED_BY(crit_capture_);
|
|
bool comfort_noise_enabled_ GUARDED_BY(crit_capture_);
|
|
unsigned char* external_echo_path_ GUARDED_BY(crit_render_)
|
|
GUARDED_BY(crit_capture_);
|
|
|
|
size_t render_queue_element_max_size_ GUARDED_BY(crit_render_)
|
|
GUARDED_BY(crit_capture_);
|
|
|
|
std::vector<int16_t> render_queue_buffer_ GUARDED_BY(crit_render_);
|
|
std::vector<int16_t> capture_queue_buffer_ GUARDED_BY(crit_capture_);
|
|
|
|
// Lock protection not needed.
|
|
std::unique_ptr<
|
|
SwapQueue<std::vector<int16_t>, RenderQueueItemVerifier<int16_t>>>
|
|
render_signal_queue_;
|
|
|
|
std::vector<std::unique_ptr<Canceller>> cancellers_;
|
|
std::unique_ptr<StreamProperties> stream_properties_;
|
|
|
|
RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(EchoControlMobileImpl);
|
|
};
|
|
} // namespace webrtc
|
|
|
|
#endif // WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CONTROL_MOBILE_IMPL_H_
|