822a16f64c
Reason for revert: Fix backward compatibility support Original issue's description: > Revert of Unify rtcp packet setters (patchset #8 id:130001 of https://codereview.webrtc.org/2348623003/ ) > > Reason for revert: > Breaks compilation of internal downstream project. > > Original issue's description: > > Unify rtcp packet setters > > Renamed setters in rtcp classes > > from WithField to SetField > > from WithItem to AddItem or SetItems > > from From to SetSenderSsrc > > from To to SetMediaSsrc > > Some redundant or unsued setters removed. > > Pass-by-const& replaced with pass-by-value when appropriate. > > > > BUG=webrtc:5260 > > > > Committed: https://crrev.com/20e77c7b8a9f19942ef3c3c4f1fa3888b2cd54ea > > Cr-Commit-Position: refs/heads/master@{#14393} > > TBR=sprang@webrtc.org,stefan@webrtc.org,danilchap@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5260 > > Committed: https://crrev.com/efc6e41866662e0922858fbce1d9ee3bdd0637ed > Cr-Commit-Position: refs/heads/master@{#14400} TBR=sprang@webrtc.org,stefan@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5260 Review-Url: https://codereview.webrtc.org/2370313002 Cr-Commit-Position: refs/heads/master@{#14402}
44 lines
1.4 KiB
C++
44 lines
1.4 KiB
C++
/*
|
|
* Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "testing/gmock/include/gmock/gmock.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h"
|
|
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h"
|
|
|
|
using webrtc::rtcp::ReceiverReport;
|
|
using webrtc::rtcp::ReportBlock;
|
|
|
|
namespace webrtc {
|
|
|
|
const uint32_t kSenderSsrc = 0x12345678;
|
|
|
|
TEST(RtcpPacketTest, BuildWithTooSmallBuffer) {
|
|
ReportBlock rb;
|
|
ReceiverReport rr;
|
|
rr.SetSenderSsrc(kSenderSsrc);
|
|
EXPECT_TRUE(rr.AddReportBlock(rb));
|
|
|
|
const size_t kRrLength = 8;
|
|
const size_t kReportBlockLength = 24;
|
|
|
|
// No packet.
|
|
class Verifier : public rtcp::RtcpPacket::PacketReadyCallback {
|
|
void OnPacketReady(uint8_t* data, size_t length) override {
|
|
ADD_FAILURE() << "Packet should not fit within max size.";
|
|
}
|
|
} verifier;
|
|
const size_t kBufferSize = kRrLength + kReportBlockLength - 1;
|
|
uint8_t buffer[kBufferSize];
|
|
EXPECT_FALSE(rr.BuildExternalBuffer(buffer, kBufferSize, &verifier));
|
|
}
|
|
} // namespace webrtc
|