86ee89f73e
On a 32bit system, this reduces the allocation size of the flag down from 12 bytes to 8, and removes the need for a vtable (the extra 4 bytes are the vtable pointer). The downside is that this change makes the binary layout of the flag, less compatible with RefCountedObject<> based reference counting objects and thus we don't immediately get the benefits of identical COMDAT folding and subsequently there's a slight binary size increase. With wider use, the binary size benefits will come. Bug: none Change-Id: I04129771790a3258d6accaf0ab1258b7a798a55e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215681 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33793}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.