895556e19c
This needs to be done still for kNative frames, but all other frame types can be passed in. I have checked all VideoEncoder implementations in Chromium and confirmed they either convert the frame to their preferred pixel format, or just forward the frame to a delegate encoder. Tested: - video_loopback with NV12 generated frames for VP9, the only codec supporting NV12, as well as VP8 which only accepts I420 frames. - internal_tests tryrun Bug: webrtc:11976,webrtc:11635 Change-Id: If39a815fb0c5636fceb1040c8946c3db2fb350a1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185803 Commit-Queue: Evan Shrubsole <eshr@google.com> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32306}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.