8b3db59b6e
This reverts commit 5341aaccdb64e3336abf5875e8828222446adffa. Reason for revert: Order of initialization of global static strings. Original change's description: > Reland of https://webrtc-review.googlesource.com/c/src/+/114883 > > The difference to the original is new bitexactness strings AND > global static file string constants. The reason for reland is breaking > downstream projects. > > Original CL description: > > Tests for multi-stream Opus. > > This CL (mainly) adds bit-exactness tests for multi-stream Opus. The > tests are in audio_coding_unittest.cc. Some refactoring of > AcmSendTestOldApi, AcmSenderBitExactnessOldApi is done to make it > possible. A few checks for "channels \in {1, 2}" are replaced with > "channels \in {1, 2, 4, 6, 8}" in the WebRTC Opus codec wrapper. A few > other changes are made to be able to write and read multi-channel WAV > files. > > The SDP changes are NOT included; as of this CL there is no way to set > up a multi-stream opus en/de-coder from SDP strings. > > Bug: webrtc:8649 > Change-Id: I9fd47c790c241c1876c4a731b0840bec30b4f1b2 > Reviewed-on: https://webrtc-review.googlesource.com/c/123387 > Reviewed-by: Oskar Sundbom <ossu@webrtc.org> > Commit-Queue: Alex Loiko <aleloi@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26774} TBR=aleloi@webrtc.org,ossu@webrtc.org Change-Id: I88060f2050ccee83d6091b042a10f79b3c4edc47 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8649 Reviewed-on: https://webrtc-review.googlesource.com/c/123580 Reviewed-by: Alex Loiko <aleloi@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26777}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.