8b7cfa16aa
Since dependencies on Abseil need to be statically linked in case Chromium is built with is_component_build=true, this CL introduces a new parameter for C++ library rtc_* templates (rtc_library, rtc_source_set and rtc_static_library). This parameter (called "absl_deps") will result in a dependency on the Abseil component (//third_party/abseil-cpp:absl) when is_component_build=true or on the normal granular Abseil target when is_component_build=false. Bug: chromium:1046390 Change-Id: Iddca886926a7874488701bc9d79affb00cca72d0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176447 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31441}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.