zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
8b8d01ada30bd2a5ba810fe7f2bc8577f973f6fc
platform-external-webrtc/modules/remote_bitrate_estimator
History
Mirko Bonadei fc52b912a3 Implicitly suppress //build/config/clang:find_bad_constructs. 
Since there is no way to enable/disable these diagnostics at runtime,
this CL moves the suppression into the rtc_* templates in order to
remove the need to explicitly add the snippet of code needed to
suppress it (currently copy/pasted in 144 locations).

The diagnostic that causes the most problems is the one about "complex
class/struct explicit ctor/dtor" [1] because WebRTC doesn't find
it useful enough.

Other diagnostics are good (for example the one that warns about
using "virtual" instead of "override", but that will be covered by
this clang-tidy check [2]) while others are Chromium related so
they have never triggered.

[1] - https://cs.chromium.org/chromium/src/tools/clang/plugins/FindBadConstructsConsumer.cpp?l=147-167&rcl=b4bebe1aa15dba7ca5fcc6456a81a55665327c3a
[2] - https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html

Bug: webrtc:163
Change-Id: Icbf27efa5b369100a31e6a32df1a0913729b3b34
Reviewed-on: https://webrtc-review.googlesource.com/c/125088
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26918}
2019-03-01 10:18:17 +00:00
..
include
Cleanup AimdRateController and remove RateControlRegion enum.
2018-11-22 13:51:28 +00:00
test
Removes all const Clock*.
2019-01-30 13:03:37 +00:00
tools
[clang-tidy] Apply performance-faster-string-find fixes.
2019-01-28 11:31:53 +00:00
aimd_rate_control_unittest.cc
Using unit classes in AimdRateControl.
2018-11-20 08:04:11 +00:00
aimd_rate_control.cc
Extracts LinkCapacityEstimator from AimdRateControl.
2018-11-29 18:58:40 +00:00
aimd_rate_control.h
Extracts LinkCapacityEstimator from AimdRateControl.
2018-11-29 18:58:40 +00:00
BUILD.gn
Implicitly suppress //build/config/clang:find_bad_constructs.
2019-03-01 10:18:17 +00:00
bwe_defines.cc
Introduces common AudioAllocationSettings class.
2019-01-23 12:13:29 +00:00
bwe_simulations.cc
Stop using Googletest legacy APIs.
2019-01-31 13:23:33 +00:00
DEPS
Move remaining traces of VoiceEngine
2018-01-17 13:27:47 +00:00
inter_arrival_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
inter_arrival.cc
[Cleanup] Add missing #include. Remove useless ones.
2018-10-23 11:32:56 +00:00
inter_arrival.h
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
overuse_detector_unittest.cc
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 18:25:07 +00:00
overuse_detector.cc
Renamed a variable in overuse_detector.
2019-01-02 16:43:12 +00:00
overuse_detector.h
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
overuse_estimator.cc
[Cleanup] Add missing #include. Remove useless ones.
2018-10-23 11:32:56 +00:00
overuse_estimator.h
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
OWNERS
Adds srte to OWNERS in bitrate_controller and remote_bitrate_estimator.
2018-09-26 09:24:45 +00:00
remote_bitrate_estimator_abs_send_time_unittest.cc
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
remote_bitrate_estimator_abs_send_time.cc
Removes all const Clock*.
2019-01-30 13:03:37 +00:00
remote_bitrate_estimator_abs_send_time.h
Removes all const Clock*.
2019-01-30 13:03:37 +00:00
remote_bitrate_estimator_single_stream_unittest.cc
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
remote_bitrate_estimator_single_stream.cc
Removes all const Clock*.
2019-01-30 13:03:37 +00:00
remote_bitrate_estimator_single_stream.h
Removes all const Clock*.
2019-01-30 13:03:37 +00:00
remote_bitrate_estimator_unittest_helper.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
remote_bitrate_estimator_unittest_helper.h
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
remote_bitrate_estimators_test.cc
Stop using Googletest legacy APIs.
2019-01-31 13:23:33 +00:00
remote_estimator_proxy_unittest.cc
Extend RemoteEstimatorProxy to support feedback on sender request.
2019-02-19 13:56:44 +00:00
remote_estimator_proxy.cc
Extend RemoteEstimatorProxy to support feedback on sender request.
2019-02-19 13:56:44 +00:00
remote_estimator_proxy.h
Extend RemoteEstimatorProxy to support feedback on sender request.
2019-02-19 13:56:44 +00:00