9ad1f6feca
This is a reland of e2dfe74b0e29558ddea6473d0272bc38c838370c Downstream breakage has been fixed. Original change's description: > Delete PeerConnectionInterface::BitrateParameters > > Replaced by the api struct BitrateSettings, added in > https://webrtc-review.googlesource.com/74020 > > Bug: None > Change-Id: I8b50b32f5c7a8918fad675904d913a21fd905274 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177665 > Commit-Queue: Niels Moller <nisse@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Reviewed-by: Taylor <deadbeef@webrtc.org> > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31714} Tbr: kwiberg@webrtc.org Bug: None Change-Id: Ic039e51f9f842329525887a28d1cb9819addc74b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179282 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31728}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.