88799d9c1f
Fix an issue where using setNeedsDisplay on a GLKView which has a frame
with size zero will make GLKView/iOS output the following error:
Failed to bind EAGLDrawable: <CAEAGLLayer: 0x1742282e0> to
GL_RENDERBUFFER 1 Failed to make complete framebuffer object 8cd6
(The error code 8cd6 corresponds to
GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT.)
GLKView will internally setup it's render buffer when the delegate is
about to draw into it. Previously when enableSetNeedsDisplay was set to
YES (default), then GLKView would still attempt to setup it's internal
buffer even if it's frame size is zero and that would cause
GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT.
By using enableSetNeedsDisplay = NO, RTCEAGLVideoView can guard against
calling -[GLKView display] if it's current frame size is empty.
Review URL: https://codereview.webrtc.org/1347013002
Cr-Commit-Position: refs/heads/master@{#10076}
47 lines
1.3 KiB
Plaintext
47 lines
1.3 KiB
Plaintext
# Names should be added to this file like so:
|
|
# Name or Organization <email address>
|
|
|
|
Anil Kumar <an1kumar@gmail.com>
|
|
Ben Strong <bstrong@gmail.com>
|
|
Bob Withers <bwit@pobox.com>
|
|
Bridger Maxwell <bridgeyman@gmail.com>
|
|
Christophe Dumez <ch.dumez@samsung.com>
|
|
Colin Plumb
|
|
Eric Rescorla, RTFM Inc. <ekr@rtfm.com>
|
|
Giji Gangadharan <giji.g@samsung.com>
|
|
Graham Yoakum <gyoakum@skobalt.com>
|
|
Jake Hilton <jakehilton@gmail.com>
|
|
James H. Brown <jbrown@burgoyne.com>
|
|
Jiawei Ou <jiawei.ou@gmail.com>
|
|
Jie Mao <maojie0924@gmail.com>
|
|
Luke Weber <luke.weber@gmail.com>
|
|
Manish Jethani <manish.jethani@gmail.com>
|
|
Martin Storsjo <martin@martin.st>
|
|
Matthias Liebig <matthias.gcode@gmail.com>
|
|
Pali Rohar
|
|
Paul Kapustin <pkapustin@gmail.com>
|
|
Rafael Lopez Diez <rafalopezdiez@gmail.com>
|
|
Ralph Giles <giles@ghostscript.com>
|
|
Robert Nagy <robert.nagy@gmail.com>
|
|
Ryan Yoakum <ryoakum@skobalt.com>
|
|
Sarah Thompson <sarah@telergy.com>
|
|
Saul Kravitz <Saul.Kravitz@celera.com>
|
|
Silviu Caragea <silviu.cpp@gmail.com>
|
|
Steve Reid <sreid@sea-to-sky.net>
|
|
Vicken Simonian <vsimon@gmail.com>
|
|
Victor Costan <costan@gmail.com>
|
|
|
|
&yet LLC
|
|
ARM Holdings
|
|
BroadSoft Inc.
|
|
Google Inc.
|
|
Intel Corporation
|
|
MIPS Technologies
|
|
Mozilla Foundation
|
|
Opera Software ASA
|
|
Sinch AB
|
|
struktur AG
|
|
Telenor Digital AS
|
|
Temasys Communications
|
|
Vonage Holdings Corp.
|