13c0be44b3
As the exposure of power efficient stats to JavaScript are limited as to reduce the fingerprinting surface to getStats, a new RTCStatsMember derivation, RTCLimitedStatsMember, was added in this change. This sets the exposure criteria of the stat on the type, which keeps the size of the RTCStatsMember class the same and allows for extension in the future for new types of stat restrictions. Bug: webrtc:14483 Change-Id: Ib0303050a112441ba2416fd5f004dd8be26b47ca Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279021 Commit-Queue: Evan Shrubsole <eshr@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38576}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.