zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
9a78d22822880884f9fa495e4cbe33f5224296c4
platform-external-webrtc/webrtc/modules/rtp_rtcp/source
History
tommi 9a78d22822 Revert of Consolidate constructormagic macros with Chromium version and remove Chromium override. (patchset #4 id:60001 of https://codereview.webrtc.org/1316363005/ ) 
Reason for revert:
Had to revert since FYI bots stopped compiling.  Example failure:

[94/9470] CXX obj\third_party\webrtc\modules\video_processing\main\source\video_processing_sse2.content_analysis_sse2.obj
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\webrtc\modules\video_coding\codecs\h264\webrtc_h264.h264.obj.rsp /c ..\..\third_party\webrtc\modules\video_coding\codecs\h264\h264.cc /Foobj\third_party\webrtc\modules\video_coding\codecs\h264\webrtc_h264.h264.obj /Fdobj\third_party\webrtc\modules\webrtc_h264.cc.pdb
e:\b\build\slave\win\build\src\base\macros.h(28) : error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win\build\src\base\macros.h(28) : warning C4005: 'DISALLOW_COPY_AND_ASSIGN' : macro redefinition
        e:\b\build\slave\win\build\src\third_party\webrtc\base\constructormagic.h(27) : see previous definition of 'DISALLOW_COPY_AND_ASSIGN'
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\webrtc\base\rtc_base_approved.bitbuffer.obj.rsp /c ..\..\third_party\webrtc\base\bitbuffer.cc /Foobj\third_party\webrtc\base\rtc_base_approved.bitbuffer.obj /Fdobj\third_party\webrtc\base\rtc_base_approved.cc.pdb
e:\b\build\slave\win\build\src\base\macros.h(28) : error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win\build\src\base\macros.h(28) : warning C4005: 'DISALLOW_COPY_AND_ASSIGN' : macro redefinition
        e:\b\build\slave\win\build\src\third_party\webrtc\base\constructormagic.h(27) : see previous definition of 'DISALLOW_COPY_AND_ASSIGN'
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\webrtc\modules\audio_processing\logging\audio_processing.aec_logging_file_handling.obj.rsp /c ..\..\third_party\webrtc\modules\audio_processing\logging\aec_logging_file_handling.cc /Foobj\third_party\webrtc\modules\audio_processing\logging\audio_processing.aec_logging_file_handling.obj /Fdobj\third_party\webrtc\modules\audio_processing.cc.pdb
e:\b\build\slave\win\build\src\base\macros.h(28) : error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win\build\src\base\macros.h(28) : warning C4005: 'DISALLOW_COPY_AND_ASSIGN' : macro redefinition
        e:\b\build\slave\win\build\src\third_party\webrtc\base\constructormagic.h(27) : see previous definition of 'DISALLOW_COPY_AND_ASSIGN'
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\webrtc\modules\audio_processing\beamformer\audio_processing.nonlinear_beamformer.obj.rsp /c ..\..\third_party\webrtc\modules\audio_processing\beamformer\nonlinear_beamformer.cc /Foobj\third_party\webrtc\modules\audio_processing\beamformer\audio_processing.nonlinear_beamformer.obj /Fdobj\third_party\webrtc\modules\audio_processing.cc.pdb
e:\b\build\slave\win\build\src\base\macros.h(28) : error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win\build\src\base\macros.h(28) : warning C4005: 'DISALLOW_COPY_AND_ASSIGN' : macro redefinition
        e:\b\build\slave\win\build\src\third_party\webrtc\base\constructormagic.h(27) : see previous definition of 'DISALLOW_COPY_AND_ASSIGN'

Original issue's description:
> Consolidate constructormagic macros with Chromium version and remove Chromium override.
>
> Part of work removing dependency on Chromium's base.
>
> Only adds "= delete". From https://codereview.chromium.org/1151443003 :
> "This will guarantee the error to be at compile time, and not rely on the call visibility (private)."
>
> In consequence of that change, fixed an illegal copy and removed a bunch of unused variables.
>
> BUG=chromium:468375 (in particular comment #37)
> NOTRY=true
>
> Committed: https://crrev.com/0de8ff488d92e0bc6b7b65662898ff5e955cda93
> Cr-Commit-Position: refs/heads/master@{#9913}

TBR=andrew@webrtc.org,henrikg@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:468375 (in particular comment #37)

Review URL: https://codereview.webrtc.org/1330283002

Cr-Commit-Position: refs/heads/master@{#9914}
2015-09-10 08:42:03 +00:00
..
mock
Some refactoring inside rtp_rtcp/.
2014-07-08 12:10:51 +00:00
rtcp_packet
Add RemoteEstimatorProxy for capturing receive times
2015-09-08 20:25:20 +00:00
bitrate.cc
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
bitrate.h
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
byte_io_unittest.cc
Make sure ByteReader<T>::Read* is properly constified.
2015-01-28 12:38:16 +00:00
byte_io.h
Make sure ByteReader and ByteWriter classes (and their specializations) don't perform operations that have implementation-specific or undefined behavior.
2015-09-04 08:07:01 +00:00
dtmf_queue.cc
Remove potential deadlock in RTPSenderAudio.
2015-02-12 12:20:50 +00:00
dtmf_queue.h
Formatted dtmf_queue.
2013-05-08 10:04:06 +00:00
fec_private_tables_bursty.h
Include files from webrtc/.. paths in rtp_rtcp/
2013-05-29 14:27:38 +00:00
fec_private_tables_random.h
Include files from webrtc/.. paths in rtp_rtcp/
2013-05-29 14:27:38 +00:00
fec_receiver_impl.cc
Prevent OOB reads in FEC packets without complete RED headers.
2015-06-30 08:32:47 +00:00
fec_receiver_impl.h
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
fec_receiver_unittest.cc
Prevent heap overflows for incorrect FEC packet lengths.
2015-07-06 10:09:15 +00:00
fec_test_helper.cc
Use ByteReader/ByteWriter instead of rtputility and manual shift/add.
2015-03-17 16:44:54 +00:00
fec_test_helper.h
Misc. cleanup split out of https://webrtc-codereview.appspot.com/37699004/ :
2015-02-23 21:29:45 +00:00
forward_error_correction_internal.cc
Switch C++-style C headers with their C equivalents.
2013-08-05 16:22:53 +00:00
forward_error_correction_internal.h
Add include guards to forward_error_correction_internal.h
2013-12-24 05:06:12 +00:00
forward_error_correction.cc
Prevent heap overflows for incorrect FEC packet lengths.
2015-07-06 10:09:15 +00:00
forward_error_correction.h
Prevent heap overflows for incorrect FEC packet lengths.
2015-07-06 10:09:15 +00:00
h264_sps_parser_unittest.cc
Fixed incorrect RBSP parsing. The original version would eat 0x3 as an emulation byte in places where it shouldn't, whereas the real parsing is only supposed to eat 0x3 preceded by 0x0 0x0.
2015-04-29 00:55:43 +00:00
h264_sps_parser.cc
Avoid overflow in checking for emulation bytes in rbsp.
2015-07-14 17:45:07 +00:00
h264_sps_parser.h
Add h.264 AVC SPS parsing for resolution (re-land)
2015-04-24 11:56:44 +00:00
nack_rtx_unittest.cc
Support handling multiple RTX but only generate SDP with RTX associated with VP8.
2015-04-21 12:25:42 +00:00
OWNERS
Make everyone an OWNER for .gyp/.gypi add/delete purposes, non-talk/ edition.
2014-04-14 20:08:03 +00:00
packet_loss_stats_unittest.cc
Add statistics gathering for packet loss.
2015-07-11 01:10:08 +00:00
packet_loss_stats.cc
Add statistics gathering for packet loss.
2015-07-11 01:10:08 +00:00
packet_loss_stats.h
Add statistics gathering for packet loss.
2015-07-11 01:10:08 +00:00
producer_fec_unittest.cc
Reland "Avoid critsect for protection- and qm setting callbacks in
2015-04-14 19:28:03 +00:00
producer_fec.cc
Reland "Avoid critsect for protection- and qm setting callbacks in
2015-04-14 19:28:03 +00:00
producer_fec.h
Reland "Avoid critsect for protection- and qm setting callbacks in
2015-04-14 19:28:03 +00:00
receive_statistics_impl.cc
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
receive_statistics_impl.h
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
receive_statistics_unittest.cc
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
remote_ntp_time_estimator_unittest.cc
Use int64_t more consistently for times, in particular for RTT values.
2015-01-12 21:51:21 +00:00
remote_ntp_time_estimator.cc
Use int64_t more consistently for times, in particular for RTT values.
2015-01-12 21:51:21 +00:00
rtcp_format_remb_unittest.cc
Remove MimdRateControl and factories for RemoteBitrateEstimor.
2015-07-06 08:51:01 +00:00
rtcp_packet_unittest.cc
Add packetization and coding/decoding of feedback message format.
2015-07-29 08:47:04 +00:00
rtcp_packet.cc
Add packetization and coding/decoding of feedback message format.
2015-07-29 08:47:04 +00:00
rtcp_packet.h
Add packetization and coding/decoding of feedback message format.
2015-07-29 08:47:04 +00:00
rtcp_receiver_help.cc
Added support for sending and receiving RTCP XR packets:
2013-10-02 13:15:34 +00:00
rtcp_receiver_help.h
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
rtcp_receiver_unittest.cc
Remove MimdRateControl and factories for RemoteBitrateEstimor.
2015-07-06 08:51:01 +00:00
rtcp_receiver.cc
Removed extended jitter report from RtcpSender.
2015-07-24 07:58:29 +00:00
rtcp_receiver.h
Removed extended jitter report from RtcpSender.
2015-07-24 07:58:29 +00:00
rtcp_sender_unittest.cc
Use RtcpPacket to send APP in RtcpSender
2015-09-01 08:11:36 +00:00
rtcp_sender.cc
Add RemoteEstimatorProxy for capturing receive times
2015-09-08 20:25:20 +00:00
rtcp_sender.h
Add RemoteEstimatorProxy for capturing receive times
2015-09-08 20:25:20 +00:00
rtcp_utility_unittest.cc
Add stats for duplicate sent and received NACK requests.
2014-10-29 12:42:30 +00:00
rtcp_utility.cc
Refactor RTCP sender
2015-05-11 08:17:46 +00:00
rtcp_utility.h
Refactor RTCP sender
2015-05-11 08:17:46 +00:00
rtp_fec_unittest.cc
Use ByteReader/ByteWriter instead of rtputility and manual shift/add.
2015-03-17 16:44:54 +00:00
rtp_format_h264_unittest.cc
Prevent size_t underflow in H264 SPS parsing.
2015-07-01 10:00:20 +00:00
rtp_format_h264.cc
Revert of Consolidate constructormagic macros with Chromium version and remove Chromium override. (patchset #4 id:60001 of https://codereview.webrtc.org/1316363005/ )
2015-09-10 08:42:03 +00:00
rtp_format_h264.h
Revert of Consolidate constructormagic macros with Chromium version and remove Chromium override. (patchset #4 id:60001 of https://codereview.webrtc.org/1316363005/ )
2015-09-10 08:42:03 +00:00
rtp_format_video_generic.cc
Prevent OOB reads for zero-length H264 payloads.
2015-06-30 12:09:47 +00:00
rtp_format_video_generic.h
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
rtp_format_vp8_test_helper.cc
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
rtp_format_vp8_test_helper.h
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
rtp_format_vp8_unittest.cc
Prevent depacketizer OOB reads on zero-length VP8 payload.
2015-06-30 09:12:09 +00:00
rtp_format_vp8.cc
FEC protect H264 delta frames as well.
2015-07-30 12:44:34 +00:00
rtp_format_vp8.h
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
rtp_format_vp9_unittest.cc
Enabling spatial layers in VP9Impl. Filter layers in the loopback test.
2015-09-08 09:40:36 +00:00
rtp_format_vp9.cc
Enabling spatial layers in VP9Impl. Filter layers in the loopback test.
2015-09-08 09:40:36 +00:00
rtp_format_vp9.h
Add support for VP9 packetization/depacketization.
2015-07-28 11:02:58 +00:00
rtp_format.cc
Add support for VP9 packetization/depacketization.
2015-07-28 11:02:58 +00:00
rtp_format.h
Remove partially defined WebRtcRTPHeader from Parse().
2014-11-07 11:02:12 +00:00
rtp_header_extension_unittest.cc
Enable CVO by default through webrtc pipeline.
2015-04-01 22:33:15 +00:00
rtp_header_extension.cc
Enable CVO by default through webrtc pipeline.
2015-04-01 22:33:15 +00:00
rtp_header_extension.h
Enable CVO by default through webrtc pipeline.
2015-04-01 22:33:15 +00:00
rtp_header_parser.cc
Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro
2015-03-04 13:04:54 +00:00
rtp_packet_history_unittest.cc
Fixed potential crash if rtp packet history is completely full.
2015-02-02 13:08:14 +00:00
rtp_packet_history.cc
Fixed potential crash if rtp packet history is completely full.
2015-02-02 13:08:14 +00:00
rtp_packet_history.h
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
rtp_payload_registry_unittest.cc
Register sample rate of Audio RED in RTPPayloadRegistry.
2015-03-25 15:11:34 +00:00
rtp_payload_registry.cc
Integration of VP9 packetization.
2015-07-31 13:10:16 +00:00
rtp_receiver_audio.cc
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
rtp_receiver_audio.h
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
rtp_receiver_impl.cc
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
rtp_receiver_impl.h
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
rtp_receiver_strategy.cc
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
rtp_receiver_strategy.h
Remove ResetStatistics from RTP feedback.
2015-07-07 15:32:56 +00:00
rtp_receiver_video.cc
Fail RTP parsing on excessive padding length.
2015-07-01 12:35:56 +00:00
rtp_receiver_video.h
Removing private and unused method in RTPReceiver.
2015-03-09 11:54:45 +00:00
rtp_rtcp_config.h
Use int64_t for milliseconds more often, primarily for TimeUntilNextProcess.
2014-12-15 22:09:40 +00:00
rtp_rtcp_impl_unittest.cc
Add support for fragmentation in RtcpPacket.
2015-06-08 07:54:24 +00:00
rtp_rtcp_impl.cc
Add RemoteEstimatorProxy for capturing receive times
2015-09-08 20:25:20 +00:00
rtp_rtcp_impl.h
Add RemoteEstimatorProxy for capturing receive times
2015-09-08 20:25:20 +00:00
rtp_sender_audio.cc
Use ByteReader/ByteWriter instead of rtputility and manual shift/add.
2015-03-17 16:44:54 +00:00
rtp_sender_audio.h
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
rtp_sender_unittest.cc
Separating voice activity flag from audio level in RtpHeaderExtension.
2015-08-10 13:08:46 +00:00
rtp_sender_video.cc
Integration of VP9 packetization.
2015-07-31 13:10:16 +00:00
rtp_sender_video.h
Reland "Avoid critsect for protection- and qm setting callbacks in
2015-04-14 19:28:03 +00:00
rtp_sender.cc
Add support for transport wide sequence numbers
2015-08-03 11:38:48 +00:00
rtp_sender.h
Add support for transport wide sequence numbers
2015-08-03 11:38:48 +00:00
rtp_utility.cc
Separating voice activity flag from audio level in RtpHeaderExtension.
2015-08-10 13:08:46 +00:00
rtp_utility.h
Use ByteReader/ByteWriter instead of rtputility and manual shift/add.
2015-03-17 16:44:54 +00:00
ssrc_database.cc
Remove remains of WEBRTC_NO_STL.
2014-07-22 06:48:58 +00:00
ssrc_database.h
Remove remains of WEBRTC_NO_STL.
2014-07-22 06:48:58 +00:00
tmmbr_help.cc
Landing pkasting's webrtc fixes for MSVC level 4 warnings in WebRTC.
2014-07-11 19:09:59 +00:00
tmmbr_help.h
Sorted headers under rtp_rtcp/.
2013-07-10 15:40:42 +00:00
video_codec_information.h
Proper spacing for end-of-namespace comments.
2013-07-03 15:12:26 +00:00
vp8_partition_aggregator_unittest.cc
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
vp8_partition_aggregator.cc
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
vp8_partition_aggregator.h
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00