dd87d580e8
When implementing ISOLATED_OUTDIR feature in WebRTC, I found two issues, 1. pathutils and flags are not accessible in testsupport. But both of them are useful for the feature. Pathname can help to combine path with filename, while a flag is needed to handle command line parameter. 2. rtc::File cannot accept an rtc::Pathname, which is a little bit inconvenient. After investigating bug webrtc:3806, flags, pathutils and urlencode are removed from rtc_base_approved because of the including of common.h. So I replaced common.h with checks.h, and ASSERT with RTC_DCHECK. flags, pathutils and urlencode pairs now can be placed into rtc_base_approved to unblock file.h to include pathutils.h. Please kindly let me know if you have other concerns about this change. BUG=webrtc:3806, webrtc:6732 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng;master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:linux_android_rel_ng Review-Url: https://codereview.webrtc.org/2533213005 Cr-Commit-Position: refs/heads/master@{#15451}
80 lines
1.6 KiB
C++
80 lines
1.6 KiB
C++
/*
|
|
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "webrtc/base/file.h"
|
|
|
|
#include <utility>
|
|
|
|
namespace rtc {
|
|
|
|
namespace {
|
|
|
|
std::string NormalizePathname(Pathname&& path) {
|
|
path.Normalize();
|
|
return path.pathname();
|
|
}
|
|
|
|
} // namespace
|
|
|
|
File::File(PlatformFile file) : file_(file) {}
|
|
|
|
File::File() : file_(kInvalidPlatformFileValue) {}
|
|
|
|
File::~File() {
|
|
Close();
|
|
}
|
|
|
|
// static
|
|
File File::Open(const std::string& path) {
|
|
return File(OpenPlatformFile(path));
|
|
}
|
|
|
|
// static
|
|
File File::Open(Pathname&& path) {
|
|
return Open(NormalizePathname(std::move(path)));
|
|
}
|
|
|
|
// static
|
|
File File::Open(const Pathname& path) {
|
|
return Open(Pathname(path));
|
|
}
|
|
|
|
// static
|
|
File File::Create(const std::string& path) {
|
|
return File(CreatePlatformFile(path));
|
|
}
|
|
|
|
// static
|
|
File File::Create(Pathname&& path) {
|
|
return Create(NormalizePathname(std::move(path)));
|
|
}
|
|
|
|
// static
|
|
File File::Create(const Pathname& path) {
|
|
return Create(Pathname(path));
|
|
}
|
|
|
|
File::File(File&& other) : file_(other.file_) {
|
|
other.file_ = kInvalidPlatformFileValue;
|
|
}
|
|
|
|
File& File::operator=(File&& other) {
|
|
Close();
|
|
file_ = other.file_;
|
|
other.file_ = kInvalidPlatformFileValue;
|
|
return *this;
|
|
}
|
|
|
|
bool File::IsOpen() {
|
|
return file_ != kInvalidPlatformFileValue;
|
|
}
|
|
|
|
} // namespace rtc
|