
We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition. Alternative solutions: * Check if we already have defined e.g. CHECK, and don't define them in that case. This makes us depend on include order in Chromium, which is not acceptable. * Don't allow using the macros in WebRTC headers. Error prone since if someone adds it there by mistake it may compile fine, but later break if a header in added or order is changed in Chromium. That will be confusing and hard to enforce. * Ensure that headers that are included by an embedder don't include our macros. This would require some heavy refactoring to be maintainable and enforcable. * Changes in Chromium for this is obviously not an option. BUG=chromium:468375 NOTRY=true Review URL: https://codereview.webrtc.org/1335923002 Cr-Commit-Position: refs/heads/master@{#9964}
65 lines
1.9 KiB
C++
65 lines
1.9 KiB
C++
/*
|
|
* Copyright 2015 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "webrtc/base/logsinks.h"
|
|
|
|
#include <iostream>
|
|
#include <string>
|
|
|
|
#include "webrtc/base/checks.h"
|
|
|
|
namespace rtc {
|
|
|
|
FileRotatingLogSink::FileRotatingLogSink(const std::string& log_dir_path,
|
|
const std::string& log_prefix,
|
|
size_t max_log_size,
|
|
size_t num_log_files)
|
|
: FileRotatingLogSink(new FileRotatingStream(log_dir_path,
|
|
log_prefix,
|
|
max_log_size,
|
|
num_log_files)) {
|
|
}
|
|
|
|
FileRotatingLogSink::FileRotatingLogSink(FileRotatingStream* stream)
|
|
: stream_(stream) {
|
|
RTC_DCHECK(stream);
|
|
}
|
|
|
|
FileRotatingLogSink::~FileRotatingLogSink() {
|
|
}
|
|
|
|
void FileRotatingLogSink::OnLogMessage(const std::string& message) {
|
|
if (stream_->GetState() != SS_OPEN) {
|
|
std::cerr << "Init() must be called before adding this sink." << std::endl;
|
|
return;
|
|
}
|
|
stream_->WriteAll(message.c_str(), message.size(), nullptr, nullptr);
|
|
}
|
|
|
|
bool FileRotatingLogSink::Init() {
|
|
return stream_->Open();
|
|
}
|
|
|
|
bool FileRotatingLogSink::DisableBuffering() {
|
|
return stream_->DisableBuffering();
|
|
}
|
|
|
|
CallSessionFileRotatingLogSink::CallSessionFileRotatingLogSink(
|
|
const std::string& log_dir_path,
|
|
size_t max_total_log_size)
|
|
: FileRotatingLogSink(
|
|
new CallSessionFileRotatingStream(log_dir_path, max_total_log_size)) {
|
|
}
|
|
|
|
CallSessionFileRotatingLogSink::~CallSessionFileRotatingLogSink() {
|
|
}
|
|
|
|
} // namespace rtc
|