2943f015b6
This CL is expected to lower goog_max_decode_ms and total_delay_incl_network/receiver_time for screenshare. Reason for revert: This CL did not cause the unexpected goog_encode_usage_percent and goog_avg_encode_ms perf changes. Original issue's description: > Revert of VCMCodecTimer: Change filter from max to 95th percentile (patchset #5 id:180001 of https://codereview.webrtc.org/1742323002/ ) > > Reason for revert: > Caused unexpected perf stats changes, see http://crbug/594575. > > Original issue's description: > > VCMCodecTimer: Change filter from max to 95th percentile > > > > The purpose with this change is to make the filter more robust against anomalies. googMaxDecodeMs is expected to drop a litte by this. > > > > BUG=b/27306053 > > > > Committed: https://crrev.com/4bf0c717740d1834e810ea5f32b3c4306c64235f > > Cr-Commit-Position: refs/heads/master@{#11952} > > TBR=stefan@webrtc.org,philipel@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=594575,b/27306053 > > Committed: https://crrev.com/c4a74e95b545f4752d4e72961ac03c1380d4bc1f > Cr-Commit-Position: refs/heads/master@{#12018} TBR=stefan@webrtc.org,philipel@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=594575,b/27306053 Review URL: https://codereview.webrtc.org/1824763003 Cr-Commit-Position: refs/heads/master@{#12087}
52 lines
1.5 KiB
C++
52 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_MODULES_VIDEO_CODING_CODEC_TIMER_H_
|
|
#define WEBRTC_MODULES_VIDEO_CODING_CODEC_TIMER_H_
|
|
|
|
#include <queue>
|
|
|
|
#include "webrtc/modules/include/module_common_types.h"
|
|
#include "webrtc/modules/video_coding/percentile_filter.h"
|
|
#include "webrtc/typedefs.h"
|
|
|
|
namespace webrtc {
|
|
|
|
class VCMCodecTimer {
|
|
public:
|
|
VCMCodecTimer();
|
|
|
|
// Add a new decode time to the filter.
|
|
void AddTiming(int64_t new_decode_time_ms, int64_t now_ms);
|
|
|
|
// Get the required decode time in ms. It is the 95th percentile observed
|
|
// decode time within a time window.
|
|
int64_t RequiredDecodeTimeMs() const;
|
|
|
|
private:
|
|
struct Sample {
|
|
Sample(int64_t decode_time_ms, int64_t sample_time_ms);
|
|
int64_t decode_time_ms;
|
|
int64_t sample_time_ms;
|
|
};
|
|
|
|
// The number of samples ignored so far.
|
|
int ignored_sample_count_;
|
|
// Queue with history of latest decode time values.
|
|
std::queue<Sample> history_;
|
|
// |filter_| contains the same values as |history_|, but in a data structure
|
|
// that allows efficient retrieval of the percentile value.
|
|
PercentileFilter filter_;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // WEBRTC_MODULES_VIDEO_CODING_CODEC_TIMER_H_
|