aa3d3b4793
This reverts commit 2978abb88c49362e296bdce3cb662f6255b17083. Reason for revert: Breaks ApmTest.Process. After trying to enable AVX2, we increased the amount of error we tolerate (kFloatNear) and this CL introduced a regression which makes the test fail after we reverted the enabling of AVX2 (restoring the old tolerance). With this CL: ../../modules/audio_processing/audio_processing_unittest.cc:1779: Failure The difference between test->rms_dbfs_average() and rms_dbfs_average is 0.00142669677734375, which exceeds kFloatNear, where test->rms_dbfs_average() evaluates to 52.907142639160156, rms_dbfs_average evaluates to 52.905715942382812, and kFloatNear evaluates to 0.00050000000000000001. [ FAILED ] ApmTest.Process (5347 ms) [----------] 1 test from ApmTest (5348 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (5350 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ApmTest.Process After reverting it: [ OK ] ApmTest.Process (5345 ms) [----------] 1 test from ApmTest (5347 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (5350 ms total) [ PASSED ] 1 test. Original change's description: > Reduce the amount of howling reduction in AEC3 > > This CL backs off the howling protection functionality in AEC3. > The effect is increased transparency in some cases. No negative effects > have been identified in the hands-on testing. > > > A kill-switch is added that can be used to turn off the functionality. > > Bug: b/150764764 > Change-Id: I604c569c76f911799556a60bc8fd2fb43bbfe196 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186082 > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> > Commit-Queue: Per Åhgren <peah@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32258} TBR=gustaf@webrtc.org,peah@webrtc.org Change-Id: I4723c5cd66e3046851089157ec586afab55c5ce8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/150764764 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186122 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32261}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.