ad2ec76387
This reverts commit 239f92ecf7fc8ca27e0376dd192b33ce33377b3c. Reason for revert: Breaks downstream projects. Original change's description: > introduce an unsupported content description type > > This carries around unsupported content descriptions > (i.e. things where webrtc does not understand the media type > or protocol) in a special data type so that a rejected content or > mediasection is added to the answer SDP. > > BUG=webrtc:3513 > > Change-Id: Ifc4168eae11e899f2504649de5e1eecb6801a9fb > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179082 > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> > Cr-Commit-Position: refs/heads/master@{#32410} TBR=kthelgason@webrtc.org,hta@webrtc.org,philipp.hancke@googlemail.com Change-Id: I055fe001fe2757d79be7c304eccc43a8e3104f69 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:3513 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/188581 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32411}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.