ada810aab2
This is a reland of e6ee8fab7eac915b2b6abc9b71b6d33ad086f3d1 Original change's description: > Deprecate microsecond timestamps in RTC event log. > > (Microsecond timestamps are only used in the legacy wire-format, > and the clocks only have microsecond resolution on some platforms.) > > Also convert structs on the parsing side to use a Timestamp instead > of a uint64_t to represent the log time. > > Bug: webrtc:11933 > Change-Id: Ide5a0217d99f13f2e243115b163f13e0525648c7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219467 > Commit-Queue: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> > Reviewed-by: Sebastian Jansson <srte@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#34097} Bug: webrtc:11933 Change-Id: I295be966ee96b50719ceb4690dad7e7ce958dbac Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/221361 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34321}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.