
Clang version changed 223108:230914
Details: e144d30..6fdb142
/tools/clang/scripts/update.sh
Removes the OVERRIDE macro defined in:
* webrtc/base/common.h
* webrtc/typedefs.h
The majority of the source changes were done by running this in src/:
perl -0pi -e "s/virtual\s([^({;]*(\([^({;]*\)[^({;]*))(OVERRIDE|override)/\1override/sg" `find {talk,webrtc} -name "*.h" -o -name "*.cc*" -o -name "*.mm*"`
which converted all:
virtual Foo() OVERRIDE
functions to:
Foo() override
Then I manually edited:
* talk/media/webrtc/fakewebrtccommon.h
* webrtc/test/fake_common.h
Remaining uses of OVERRIDE was fixed by search+replace.
Manual edits were done to fix virtual destructors that were
overriding inherited ones.
Finally a build error related to the pure virtual definitions of
Read, Write and Rewind in common_types.h required a bit of
refactoring in:
* webrtc/common_types.cc
* webrtc/common_types.h
* webrtc/system_wrappers/interface/file_wrapper.h
* webrtc/system_wrappers/source/file_impl.cc
This roll should make it possible for us to finally re-enable deadlock
detection for TSan on the buildbots.
BUG=4106
R=pbos@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41069004
Cr-Commit-Position: refs/heads/master@{#8596}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d
58 lines
1.3 KiB
C++
58 lines
1.3 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_VOICE_ENGINE_MONITOR_MODULE_H
|
|
#define WEBRTC_VOICE_ENGINE_MONITOR_MODULE_H
|
|
|
|
#include "webrtc/modules/interface/module.h"
|
|
#include "webrtc/typedefs.h"
|
|
#include "webrtc/voice_engine/voice_engine_defines.h"
|
|
|
|
class MonitorObserver
|
|
{
|
|
public:
|
|
virtual void OnPeriodicProcess() = 0;
|
|
protected:
|
|
virtual ~MonitorObserver() {}
|
|
};
|
|
|
|
|
|
namespace webrtc {
|
|
class CriticalSectionWrapper;
|
|
|
|
namespace voe {
|
|
|
|
class MonitorModule : public Module
|
|
{
|
|
public:
|
|
int32_t RegisterObserver(MonitorObserver& observer);
|
|
|
|
int32_t DeRegisterObserver();
|
|
|
|
MonitorModule();
|
|
|
|
virtual ~MonitorModule();
|
|
public: // module
|
|
int64_t TimeUntilNextProcess() override;
|
|
|
|
int32_t Process() override;
|
|
|
|
private:
|
|
MonitorObserver* _observerPtr;
|
|
CriticalSectionWrapper& _callbackCritSect;
|
|
int64_t _lastProcessTime;
|
|
};
|
|
|
|
} // namespace voe
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // VOICE_ENGINE_MONITOR_MODULE
|