0fcaf99b71
Enable cpplint and have it use a whitelist that also checks in subdirectories. Move the cpplint check so it runs before the pylint check since that one always run and increases the time to errors for cpplint. Fix all cpplint errors in webrtc/video_engine. BUG=webrtc:5149 TESTED=Fixed issues reported by: find webrtc/video_engine -type f -name *.cc -o -name *.h | xargs cpplint.py followed by 'git cl presubmit'. R=pbos@chromium.org, phoglund@chromium.org TBR=pbos@webrtc.org, phoglund@webrtc.org Review URL: https://codereview.webrtc.org/1481723003 . Cr-Commit-Position: refs/heads/master@{#10808}
251 lines
8.4 KiB
C++
251 lines
8.4 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
|
|
// This file includes unit tests for ViERemb.
|
|
|
|
#include <vector>
|
|
|
|
#include "testing/gmock/include/gmock/gmock.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
#include "webrtc/base/scoped_ptr.h"
|
|
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp.h"
|
|
#include "webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
|
|
#include "webrtc/modules/utility/include/mock/mock_process_thread.h"
|
|
#include "webrtc/system_wrappers/include/tick_util.h"
|
|
#include "webrtc/video_engine/vie_remb.h"
|
|
|
|
using ::testing::_;
|
|
using ::testing::AnyNumber;
|
|
using ::testing::NiceMock;
|
|
using ::testing::Return;
|
|
|
|
namespace webrtc {
|
|
|
|
class ViERembTest : public ::testing::Test {
|
|
protected:
|
|
virtual void SetUp() {
|
|
TickTime::UseFakeClock(12345);
|
|
process_thread_.reset(new NiceMock<MockProcessThread>);
|
|
vie_remb_.reset(new VieRemb());
|
|
}
|
|
rtc::scoped_ptr<MockProcessThread> process_thread_;
|
|
rtc::scoped_ptr<VieRemb> vie_remb_;
|
|
};
|
|
|
|
TEST_F(ViERembTest, OneModuleTestForSendingRemb) {
|
|
MockRtpRtcp rtp;
|
|
vie_remb_->AddReceiveChannel(&rtp);
|
|
vie_remb_->AddRembSender(&rtp);
|
|
|
|
const unsigned int bitrate_estimate = 456;
|
|
unsigned int ssrc = 1234;
|
|
std::vector<unsigned int> ssrcs(&ssrc, &ssrc + 1);
|
|
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
|
|
TickTime::AdvanceFakeClock(1000);
|
|
EXPECT_CALL(rtp, SetREMBData(bitrate_estimate, ssrcs))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
|
|
// Lower bitrate to send another REMB packet.
|
|
EXPECT_CALL(rtp, SetREMBData(bitrate_estimate - 100, ssrcs))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate - 100);
|
|
|
|
vie_remb_->RemoveReceiveChannel(&rtp);
|
|
vie_remb_->RemoveRembSender(&rtp);
|
|
}
|
|
|
|
TEST_F(ViERembTest, LowerEstimateToSendRemb) {
|
|
MockRtpRtcp rtp;
|
|
vie_remb_->AddReceiveChannel(&rtp);
|
|
vie_remb_->AddRembSender(&rtp);
|
|
|
|
unsigned int bitrate_estimate = 456;
|
|
unsigned int ssrc = 1234;
|
|
std::vector<unsigned int> ssrcs(&ssrc, &ssrc + 1);
|
|
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
// Call OnReceiveBitrateChanged twice to get a first estimate.
|
|
TickTime::AdvanceFakeClock(1000);
|
|
EXPECT_CALL(rtp, SetREMBData(bitrate_estimate, ssrcs))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
|
|
// Lower the estimate with more than 3% to trigger a call to SetREMBData right
|
|
// away.
|
|
bitrate_estimate = bitrate_estimate - 100;
|
|
EXPECT_CALL(rtp, SetREMBData(bitrate_estimate, ssrcs))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
}
|
|
|
|
TEST_F(ViERembTest, VerifyIncreasingAndDecreasing) {
|
|
MockRtpRtcp rtp_0;
|
|
MockRtpRtcp rtp_1;
|
|
vie_remb_->AddReceiveChannel(&rtp_0);
|
|
vie_remb_->AddRembSender(&rtp_0);
|
|
vie_remb_->AddReceiveChannel(&rtp_1);
|
|
|
|
unsigned int bitrate_estimate[] = { 456, 789 };
|
|
unsigned int ssrc[] = { 1234, 5678 };
|
|
std::vector<unsigned int> ssrcs(ssrc, ssrc + sizeof(ssrc) / sizeof(ssrc[0]));
|
|
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate[0]);
|
|
|
|
// Call OnReceiveBitrateChanged twice to get a first estimate.
|
|
EXPECT_CALL(rtp_0, SetREMBData(bitrate_estimate[0], ssrcs))
|
|
.Times(1);
|
|
TickTime::AdvanceFakeClock(1000);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate[0]);
|
|
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate[1] + 100);
|
|
|
|
// Lower the estimate to trigger a callback.
|
|
EXPECT_CALL(rtp_0, SetREMBData(bitrate_estimate[1], ssrcs))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate[1]);
|
|
|
|
vie_remb_->RemoveReceiveChannel(&rtp_0);
|
|
vie_remb_->RemoveRembSender(&rtp_0);
|
|
vie_remb_->RemoveReceiveChannel(&rtp_1);
|
|
}
|
|
|
|
TEST_F(ViERembTest, NoRembForIncreasedBitrate) {
|
|
MockRtpRtcp rtp_0;
|
|
MockRtpRtcp rtp_1;
|
|
vie_remb_->AddReceiveChannel(&rtp_0);
|
|
vie_remb_->AddRembSender(&rtp_0);
|
|
vie_remb_->AddReceiveChannel(&rtp_1);
|
|
|
|
unsigned int bitrate_estimate = 456;
|
|
unsigned int ssrc[] = { 1234, 5678 };
|
|
std::vector<unsigned int> ssrcs(ssrc, ssrc + sizeof(ssrc) / sizeof(ssrc[0]));
|
|
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
// Call OnReceiveBitrateChanged twice to get a first estimate.
|
|
TickTime::AdvanceFakeClock(1000);
|
|
EXPECT_CALL(rtp_0, SetREMBData(bitrate_estimate, ssrcs))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
|
|
// Increased estimate shouldn't trigger a callback right away.
|
|
EXPECT_CALL(rtp_0, SetREMBData(_, _))
|
|
.Times(0);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate + 1);
|
|
|
|
// Decreasing the estimate less than 3% shouldn't trigger a new callback.
|
|
EXPECT_CALL(rtp_0, SetREMBData(_, _))
|
|
.Times(0);
|
|
int lower_estimate = bitrate_estimate * 98 / 100;
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, lower_estimate);
|
|
|
|
vie_remb_->RemoveReceiveChannel(&rtp_1);
|
|
vie_remb_->RemoveReceiveChannel(&rtp_0);
|
|
vie_remb_->RemoveRembSender(&rtp_0);
|
|
}
|
|
|
|
TEST_F(ViERembTest, ChangeSendRtpModule) {
|
|
MockRtpRtcp rtp_0;
|
|
MockRtpRtcp rtp_1;
|
|
vie_remb_->AddReceiveChannel(&rtp_0);
|
|
vie_remb_->AddRembSender(&rtp_0);
|
|
vie_remb_->AddReceiveChannel(&rtp_1);
|
|
|
|
unsigned int bitrate_estimate = 456;
|
|
unsigned int ssrc[] = { 1234, 5678 };
|
|
std::vector<unsigned int> ssrcs(ssrc, ssrc + sizeof(ssrc) / sizeof(ssrc[0]));
|
|
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
// Call OnReceiveBitrateChanged twice to get a first estimate.
|
|
TickTime::AdvanceFakeClock(1000);
|
|
EXPECT_CALL(rtp_0, SetREMBData(bitrate_estimate, ssrcs))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
|
|
// Decrease estimate to trigger a REMB.
|
|
bitrate_estimate = bitrate_estimate - 100;
|
|
EXPECT_CALL(rtp_0, SetREMBData(bitrate_estimate, ssrcs))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
|
|
// Remove the sending module, add it again -> should get remb on the second
|
|
// module.
|
|
vie_remb_->RemoveRembSender(&rtp_0);
|
|
vie_remb_->AddRembSender(&rtp_1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
|
|
bitrate_estimate = bitrate_estimate - 100;
|
|
EXPECT_CALL(rtp_1, SetREMBData(bitrate_estimate, ssrcs))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
|
|
vie_remb_->RemoveReceiveChannel(&rtp_0);
|
|
vie_remb_->RemoveReceiveChannel(&rtp_1);
|
|
}
|
|
|
|
TEST_F(ViERembTest, OnlyOneRembForDoubleProcess) {
|
|
MockRtpRtcp rtp;
|
|
unsigned int bitrate_estimate = 456;
|
|
unsigned int ssrc = 1234;
|
|
std::vector<unsigned int> ssrcs(&ssrc, &ssrc + 1);
|
|
|
|
vie_remb_->AddReceiveChannel(&rtp);
|
|
vie_remb_->AddRembSender(&rtp);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
// Call OnReceiveBitrateChanged twice to get a first estimate.
|
|
TickTime::AdvanceFakeClock(1000);
|
|
EXPECT_CALL(rtp, SetREMBData(_, _))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
|
|
// Lower the estimate, should trigger a call to SetREMBData right away.
|
|
bitrate_estimate = bitrate_estimate - 100;
|
|
EXPECT_CALL(rtp, SetREMBData(bitrate_estimate, ssrcs))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
|
|
// Call OnReceiveBitrateChanged again, this should not trigger a new callback.
|
|
EXPECT_CALL(rtp, SetREMBData(_, _))
|
|
.Times(0);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
vie_remb_->RemoveReceiveChannel(&rtp);
|
|
vie_remb_->RemoveRembSender(&rtp);
|
|
}
|
|
|
|
// Only register receiving modules and make sure we fallback to trigger a REMB
|
|
// packet on this one.
|
|
TEST_F(ViERembTest, NoSendingRtpModule) {
|
|
MockRtpRtcp rtp;
|
|
vie_remb_->AddReceiveChannel(&rtp);
|
|
|
|
unsigned int bitrate_estimate = 456;
|
|
unsigned int ssrc = 1234;
|
|
std::vector<unsigned int> ssrcs(&ssrc, &ssrc + 1);
|
|
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
|
|
// Call OnReceiveBitrateChanged twice to get a first estimate.
|
|
TickTime::AdvanceFakeClock(1000);
|
|
EXPECT_CALL(rtp, SetREMBData(_, _))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
|
|
// Lower the estimate to trigger a new packet REMB packet.
|
|
bitrate_estimate = bitrate_estimate - 100;
|
|
EXPECT_CALL(rtp, SetREMBData(_, _))
|
|
.Times(1);
|
|
vie_remb_->OnReceiveBitrateChanged(ssrcs, bitrate_estimate);
|
|
}
|
|
|
|
} // namespace webrtc
|