2943f015b6
This CL is expected to lower goog_max_decode_ms and total_delay_incl_network/receiver_time for screenshare. Reason for revert: This CL did not cause the unexpected goog_encode_usage_percent and goog_avg_encode_ms perf changes. Original issue's description: > Revert of VCMCodecTimer: Change filter from max to 95th percentile (patchset #5 id:180001 of https://codereview.webrtc.org/1742323002/ ) > > Reason for revert: > Caused unexpected perf stats changes, see http://crbug/594575. > > Original issue's description: > > VCMCodecTimer: Change filter from max to 95th percentile > > > > The purpose with this change is to make the filter more robust against anomalies. googMaxDecodeMs is expected to drop a litte by this. > > > > BUG=b/27306053 > > > > Committed: https://crrev.com/4bf0c717740d1834e810ea5f32b3c4306c64235f > > Cr-Commit-Position: refs/heads/master@{#11952} > > TBR=stefan@webrtc.org,philipel@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=594575,b/27306053 > > Committed: https://crrev.com/c4a74e95b545f4752d4e72961ac03c1380d4bc1f > Cr-Commit-Position: refs/heads/master@{#12018} TBR=stefan@webrtc.org,philipel@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=594575,b/27306053 Review URL: https://codereview.webrtc.org/1824763003 Cr-Commit-Position: refs/heads/master@{#12087}
57 lines
1.7 KiB
C++
57 lines
1.7 KiB
C++
/*
|
|
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "webrtc/modules/video_coding/codec_timer.h"
|
|
|
|
namespace webrtc {
|
|
|
|
namespace {
|
|
|
|
// The first kIgnoredSampleCount samples will be ignored.
|
|
const int kIgnoredSampleCount = 5;
|
|
// Return the |kPercentile| value in RequiredDecodeTimeMs().
|
|
const float kPercentile = 0.95f;
|
|
// The window size in ms.
|
|
const int64_t kTimeLimitMs = 10000;
|
|
|
|
} // anonymous namespace
|
|
|
|
VCMCodecTimer::VCMCodecTimer()
|
|
: ignored_sample_count_(0), filter_(kPercentile) {}
|
|
|
|
void VCMCodecTimer::AddTiming(int64_t decode_time_ms, int64_t now_ms) {
|
|
// Ignore the first |kIgnoredSampleCount| samples.
|
|
if (ignored_sample_count_ < kIgnoredSampleCount) {
|
|
++ignored_sample_count_;
|
|
return;
|
|
}
|
|
|
|
// Insert new decode time value.
|
|
filter_.Insert(decode_time_ms);
|
|
history_.emplace(decode_time_ms, now_ms);
|
|
|
|
// Pop old decode time values.
|
|
while (!history_.empty() &&
|
|
now_ms - history_.front().sample_time_ms > kTimeLimitMs) {
|
|
filter_.Erase(history_.front().decode_time_ms);
|
|
history_.pop();
|
|
}
|
|
}
|
|
|
|
// Get the 95th percentile observed decode time within a time window.
|
|
int64_t VCMCodecTimer::RequiredDecodeTimeMs() const {
|
|
return filter_.GetPercentileValue();
|
|
}
|
|
|
|
VCMCodecTimer::Sample::Sample(int64_t decode_time_ms, int64_t sample_time_ms)
|
|
: decode_time_ms(decode_time_ms), sample_time_ms(sample_time_ms) {}
|
|
|
|
} // namespace webrtc
|