67186fe00c
Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.
Not inlining virtual functions with simple bodies such as
{ return false; }
strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.
BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47429004
Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
62 lines
1.7 KiB
C++
62 lines
1.7 KiB
C++
/*
|
|
* Copyright 2005 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_BASE_SOCKETSTREAM_H_
|
|
#define WEBRTC_BASE_SOCKETSTREAM_H_
|
|
|
|
#include "webrtc/base/asyncsocket.h"
|
|
#include "webrtc/base/common.h"
|
|
#include "webrtc/base/stream.h"
|
|
|
|
namespace rtc {
|
|
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
|
|
class SocketStream : public StreamInterface, public sigslot::has_slots<> {
|
|
public:
|
|
explicit SocketStream(AsyncSocket* socket);
|
|
~SocketStream() override;
|
|
|
|
void Attach(AsyncSocket* socket);
|
|
AsyncSocket* Detach();
|
|
|
|
AsyncSocket* GetSocket() { return socket_; }
|
|
|
|
StreamState GetState() const override;
|
|
|
|
StreamResult Read(void* buffer,
|
|
size_t buffer_len,
|
|
size_t* read,
|
|
int* error) override;
|
|
|
|
StreamResult Write(const void* data,
|
|
size_t data_len,
|
|
size_t* written,
|
|
int* error) override;
|
|
|
|
void Close() override;
|
|
|
|
private:
|
|
void OnConnectEvent(AsyncSocket* socket);
|
|
void OnReadEvent(AsyncSocket* socket);
|
|
void OnWriteEvent(AsyncSocket* socket);
|
|
void OnCloseEvent(AsyncSocket* socket, int err);
|
|
|
|
AsyncSocket* socket_;
|
|
|
|
DISALLOW_EVIL_CONSTRUCTORS(SocketStream);
|
|
};
|
|
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
|
|
} // namespace rtc
|
|
|
|
#endif // WEBRTC_BASE_SOCKETSTREAM_H_
|