zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
b6b782da684232d3a226e62cf5dc7f8d5ca028d0
platform-external-webrtc/modules/video_coding
History
Johannes Kron b6b782da68 Fix potential unsafe access to VCMTimestampMap::data 
The access to |_timestampMap| was guarded by a lock but
not the access to the data pointer stored in |_timestampMap|.
There was a potential race condition if new data was added
in VCMGenericDecoder::Decode() while the data pointer
retrieved from _timestampMap.Pop() was being used in
VCMDecodedFrameCallback::Decoded().

This CL moves the storage of data to within |_timestampMap|,
instead of being a pointer so that it's guarded by the same
lock.

Bug: webrtc:11229
Change-Id: I3f2afb568ed724db5719d508a73de402c4531dec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/209361
Commit-Queue: Johannes Kron <kron@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33374}
2021-03-03 14:21:17 +00:00
..
codecs
Do not crash if codec is not available
2021-03-03 13:56:17 +00:00
deprecated
Replace RTC_DEPRECATED with ABSL_DEPRECATED
2021-02-22 12:53:23 +00:00
include
Replace RTC_DEPRECATED with ABSL_DEPRECATED
2021-02-22 12:53:23 +00:00
svc
Add L2T3 K-SVC structure
2021-02-19 10:27:23 +00:00
test
Include module_common_types.h only where needed
2019-09-24 08:22:38 +00:00
utility
Prepare to replace VideoLayerFrameId with int64_t.
2021-02-15 14:42:02 +00:00
BUILD.gn
Fix potential unsafe access to VCMTimestampMap::data
2021-03-03 14:21:17 +00:00
chain_diff_calculator_unittest.cc
Introduce ChainDiffCalculator
2020-05-18 14:22:44 +00:00
chain_diff_calculator.cc
Introduce ChainDiffCalculator
2020-05-18 14:22:44 +00:00
chain_diff_calculator.h
Introduce ChainDiffCalculator
2020-05-18 14:22:44 +00:00
codec_timer.cc
…
codec_timer.h
Include module_common_types.h only where needed
2019-09-24 08:22:38 +00:00
decoder_database.cc
Delay creation of decoders until they are needed
2021-02-19 12:08:49 +00:00
decoder_database.h
Delay creation of decoders until they are needed
2021-02-19 12:08:49 +00:00
decoding_state_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
decoding_state.cc
Concatenate string literals at compile time.
2020-01-14 14:47:48 +00:00
decoding_state.h
…
DEPS
Add RTC_EXPORT to VCMEncodedFrame
2020-02-28 16:59:10 +00:00
encoded_frame.cc
Removed _completeFrame since we never allow incomplete frames.
2020-10-28 16:00:27 +00:00
encoded_frame.h
Stop using inter_layer_predicted flag for VP9.
2020-12-09 09:45:50 +00:00
event_wrapper.cc
Move EventWrapper class to target video_coding_legacy.
2020-03-06 08:39:35 +00:00
event_wrapper.h
Move EventWrapper class to target video_coding_legacy.
2020-03-06 08:39:35 +00:00
fec_controller_default.cc
Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 11:41:21 +00:00
fec_controller_default.h
Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 11:41:21 +00:00
fec_controller_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
fec_rate_table.h
…
frame_buffer2_unittest.cc
Prepare to replace VideoLayerFrameId with int64_t.
2021-02-15 14:42:02 +00:00
frame_buffer2.cc
Prepare to replace VideoLayerFrameId with int64_t.
2021-02-15 14:42:02 +00:00
frame_buffer2.h
Prepare to replace VideoLayerFrameId with int64_t.
2021-02-15 14:42:02 +00:00
frame_buffer.cc
Removed _completeFrame since we never allow incomplete frames.
2020-10-28 16:00:27 +00:00
frame_buffer.h
Refactor legacy FrameBuffer to use EncodedImageBuffer::Realloc
2019-09-30 09:48:26 +00:00
frame_dependencies_calculator_unittest.cc
Ignore frame type when calculating generic frame dependencies.
2020-11-23 10:52:06 +00:00
frame_dependencies_calculator.cc
Ignore frame type when calculating generic frame dependencies.
2020-11-23 10:52:06 +00:00
frame_dependencies_calculator.h
Ignore frame type when calculating generic frame dependencies.
2020-11-23 10:52:06 +00:00
frame_object.cc
Removed _completeFrame since we never allow incomplete frames.
2020-10-28 16:00:27 +00:00
frame_object.h
Reland "Delete the non-const version of the EncodedImage::data() method."
2020-09-28 13:51:51 +00:00
generic_decoder_unittest.cc
Signaling for low-latency renderer algorithm
2020-10-26 15:03:56 +00:00
generic_decoder.cc
Fix potential unsafe access to VCMTimestampMap::data
2021-03-03 14:21:17 +00:00
generic_decoder.h
Fix potential unsafe access to VCMTimestampMap::data
2021-03-03 14:21:17 +00:00
h264_sprop_parameter_sets_unittest.cc
Fully qualify googletest symbols.
2019-04-09 17:18:20 +00:00
h264_sprop_parameter_sets.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
h264_sprop_parameter_sets.h
…
h264_sps_pps_tracker_unittest.cc
in PacketBuffer::Packet pass payload using smart buffer
2019-12-03 14:55:54 +00:00
h264_sps_pps_tracker.cc
H264: Fix stap-a-to-annex-b loop over-read
2020-06-24 21:54:45 +00:00
h264_sps_pps_tracker.h
in PacketBuffer::Packet pass payload using smart buffer
2019-12-03 14:55:54 +00:00
histogram_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
histogram.cc
…
histogram.h
…
inter_frame_delay.cc
Remove unused method in VCMInterFrameDelay.
2019-04-03 07:35:28 +00:00
inter_frame_delay.h
Remove unused method in VCMInterFrameDelay.
2019-04-03 07:35:28 +00:00
internal_defines.h
Remove unused defines and methods in internal_defines.h
2019-01-28 10:31:40 +00:00
jitter_buffer_common.h
Format almost everything.
2019-07-08 13:45:15 +00:00
jitter_buffer_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
jitter_buffer.cc
Removed _completeFrame since we never allow incomplete frames.
2020-10-28 16:00:27 +00:00
jitter_buffer.h
Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 11:41:21 +00:00
jitter_estimator_tests.cc
Add option to disable reduced jitter delay through field trial.
2020-05-19 11:51:29 +00:00
jitter_estimator.cc
Add option to disable reduced jitter delay through field trial.
2020-05-19 11:51:29 +00:00
jitter_estimator.h
Add option to disable reduced jitter delay through field trial.
2020-05-19 11:51:29 +00:00
loss_notification_controller_unittest.cc
Detach LossNotificationController from RtpGenericFrameDescriptor
2020-01-24 11:53:28 +00:00
loss_notification_controller.cc
Detach LossNotificationController from RtpGenericFrameDescriptor
2020-01-24 11:53:28 +00:00
loss_notification_controller.h
Use SequenceChecker from public API
2021-02-10 15:04:55 +00:00
media_opt_util.cc
Stop checking VP8BaseHeavyTl3RateAllocation field trial on every frame.
2019-11-04 13:50:59 +00:00
media_opt_util.h
Stop checking VP8BaseHeavyTl3RateAllocation field trial on every frame.
2019-11-04 13:50:59 +00:00
nack_module2_unittest.cc
Remove locks and dependency on ProcessThread+Module from NackModule2.
2020-05-27 14:20:34 +00:00
nack_module2.cc
Remove locks and dependency on ProcessThread+Module from NackModule2.
2020-05-27 14:20:34 +00:00
nack_module2.h
Use SequenceChecker from public API
2021-02-10 15:04:55 +00:00
nack_module_unittest.cc
Deprecate webrtc::NackModule.
2020-05-30 16:34:44 +00:00
OWNERS
Remove wildcard ownership for build files.
2020-02-19 14:05:46 +00:00
packet_buffer_unittest.cc
Add new fmtp parameter for H.264
2020-08-07 10:32:41 +00:00
packet_buffer.cc
Add new fmtp parameter for H.264
2020-08-07 10:32:41 +00:00
packet_buffer.h
Move ABSL_MUST_USE_RESULT at the beginning of the method decl.
2020-08-31 08:19:29 +00:00
packet.cc
Add plumbing of RtpPacketInfos to each VideoFrame as input for SourceTracker.
2019-06-20 10:24:29 +00:00
packet.h
Add plumbing of RtpPacketInfos to each VideoFrame as input for SourceTracker.
2019-06-20 10:24:29 +00:00
receiver_unittest.cc
Move EventWrapper class to target video_coding_legacy.
2020-03-06 08:39:35 +00:00
receiver.cc
Removed _completeFrame since we never allow incomplete frames.
2020-10-28 16:00:27 +00:00
receiver.h
Remove unused critical section includes.
2020-07-16 13:52:28 +00:00
rtp_frame_id_only_ref_finder.cc
Prepare to replace VideoLayerFrameId with int64_t.
2021-02-15 14:42:02 +00:00
rtp_frame_id_only_ref_finder.h
Break RtpFrameReferenceFinder into descriptor specific parts.
2020-11-27 17:59:28 +00:00
rtp_frame_reference_finder_unittest.cc
VP8 ref finder unittest cleanup
2021-03-01 17:23:38 +00:00
rtp_frame_reference_finder.cc
Prepare to replace VideoLayerFrameId with int64_t.
2021-02-15 14:42:02 +00:00
rtp_frame_reference_finder.h
Break RtpFrameReferenceFinder into descriptor specific parts.
2020-11-27 17:59:28 +00:00
rtp_generic_ref_finder.cc
Prepare to replace VideoLayerFrameId with int64_t.
2021-02-15 14:42:02 +00:00
rtp_generic_ref_finder.h
Break RtpFrameReferenceFinder into descriptor specific parts.
2020-11-27 17:59:28 +00:00
rtp_seq_num_only_ref_finder.cc
Prepare to replace VideoLayerFrameId with int64_t.
2021-02-15 14:42:02 +00:00
rtp_seq_num_only_ref_finder.h
Break RtpFrameReferenceFinder into descriptor specific parts.
2020-11-27 17:59:28 +00:00
rtp_vp8_ref_finder_unittest.cc
VP8 ref finder unittest cleanup
2021-03-01 17:23:38 +00:00
rtp_vp8_ref_finder.cc
Prepare to replace VideoLayerFrameId with int64_t.
2021-02-15 14:42:02 +00:00
rtp_vp8_ref_finder.h
Break RtpFrameReferenceFinder into descriptor specific parts.
2020-11-27 17:59:28 +00:00
rtp_vp9_ref_finder_unittest.cc
Prepare to replace VideoLayerFrameId with int64_t.
2021-02-15 14:42:02 +00:00
rtp_vp9_ref_finder.cc
Prepare to replace VideoLayerFrameId with int64_t.
2021-02-15 14:42:02 +00:00
rtp_vp9_ref_finder.h
Stop using inter_layer_predicted flag for VP9.
2020-12-09 09:45:50 +00:00
rtt_filter.cc
…
rtt_filter.h
…
session_info_unittest.cc
Include module_common_types.h only where needed
2019-09-24 08:22:38 +00:00
session_info.cc
Remove framemarking RTP extension.
2020-06-15 11:18:00 +00:00
session_info.h
Format almost everything.
2019-07-08 13:45:15 +00:00
timestamp_map.cc
Fix potential unsafe access to VCMTimestampMap::data
2021-03-03 14:21:17 +00:00
timestamp_map.h
Fix potential unsafe access to VCMTimestampMap::data
2021-03-03 14:21:17 +00:00
timing_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
timing.cc
Delete master_timing argument to VCMTiming.
2020-11-02 11:49:46 +00:00
timing.h
Delete master_timing argument to VCMTiming.
2020-11-02 11:49:46 +00:00
unique_timestamp_counter_unittest.cc
Split out counting unique rtp timestamps from packet_buffer
2019-10-30 15:27:48 +00:00
unique_timestamp_counter.cc
Split out counting unique rtp timestamps from packet_buffer
2019-10-30 15:27:48 +00:00
unique_timestamp_counter.h
Split out counting unique rtp timestamps from packet_buffer
2019-10-30 15:27:48 +00:00
video_codec_initializer_unittest.cc
Make VP9 correctly accept middle-layer singlecast
2020-09-22 16:09:53 +00:00
video_codec_initializer.cc
Add support for VideoLayersAllocation for Vp9 scv/ksvc and none scalable
2020-12-30 16:45:03 +00:00
video_coding_defines.cc
Fix frames dropped statistics
2019-08-27 07:43:01 +00:00
video_coding_impl.cc
Use SequenceChecker from public API
2021-02-10 15:04:55 +00:00
video_coding_impl.h
Use SequenceChecker from public API
2021-02-10 15:04:55 +00:00
video_receiver2.cc
Delay creation of decoders until they are needed
2021-02-19 12:08:49 +00:00
video_receiver2.h
Delay creation of decoders until they are needed
2021-02-19 12:08:49 +00:00
video_receiver_unittest.cc
Prepare for deleting VideoCodec::plType
2020-08-11 14:20:59 +00:00
video_receiver.cc
Use SequenceChecker from public API
2021-02-10 15:04:55 +00:00