b6df60492c
The following are not yet available in their respective libraries so attempts to use it in webrtc result in a call to abort(): * libvpx's CONSTRAINED_FROM_ABOVE_DROP constant * libyuv's I010 buffers The original webrtc project expects to have third party libraries checked out in third_party/ and base/third_party/. Added some headers in those directories with a single line including the right header from external/<library>. Updated .gitignore to keep track of said headers. Bug: 153469641 Test: mm, also built cuttlefish using this library and ran it locally Change-Id: I2d596942e34093dccc65d4b7b8249b6afc14d31f Merged-In: I2d596942e34093dccc65d4b7b8249b6afc14d31f
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.