16de21696a
Move deletion of channel objects over to the RtpTransceiver instead of having it done by SdpOfferAnswer. The deletion is now also done via PostTask rather than Invoke. Bug: webrtc:11992, webrtc:13540 Change-Id: I5aff14956d5e572ca8816bbfef8739bb609b4484 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/248170 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35798}
394 lines
17 KiB
C++
394 lines
17 KiB
C++
/*
|
|
* Copyright 2018 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
// This file contains tests for `RtpTransceiver`.
|
|
|
|
#include "pc/rtp_transceiver.h"
|
|
|
|
#include <memory>
|
|
|
|
#include "absl/types/optional.h"
|
|
#include "api/rtp_parameters.h"
|
|
#include "media/base/fake_media_engine.h"
|
|
#include "pc/test/mock_channel_interface.h"
|
|
#include "pc/test/mock_rtp_receiver_internal.h"
|
|
#include "pc/test/mock_rtp_sender_internal.h"
|
|
#include "test/gmock.h"
|
|
#include "test/gtest.h"
|
|
|
|
using ::testing::_;
|
|
using ::testing::ElementsAre;
|
|
using ::testing::Optional;
|
|
using ::testing::Property;
|
|
using ::testing::Return;
|
|
using ::testing::ReturnRef;
|
|
|
|
namespace webrtc {
|
|
|
|
namespace {
|
|
class ChannelManagerForTest : public cricket::ChannelManager {
|
|
public:
|
|
ChannelManagerForTest()
|
|
: cricket::ChannelManager(std::make_unique<cricket::FakeMediaEngine>(),
|
|
true,
|
|
rtc::Thread::Current(),
|
|
rtc::Thread::Current()) {}
|
|
|
|
MOCK_METHOD(void, DestroyChannel, (cricket::ChannelInterface*), (override));
|
|
};
|
|
} // namespace
|
|
|
|
// Checks that a channel cannot be set on a stopped `RtpTransceiver`.
|
|
TEST(RtpTransceiverTest, CannotSetChannelOnStoppedTransceiver) {
|
|
ChannelManagerForTest cm;
|
|
const std::string content_name("my_mid");
|
|
RtpTransceiver transceiver(cricket::MediaType::MEDIA_TYPE_AUDIO, &cm);
|
|
cricket::MockChannelInterface channel1;
|
|
EXPECT_CALL(channel1, media_type())
|
|
.WillRepeatedly(Return(cricket::MediaType::MEDIA_TYPE_AUDIO));
|
|
EXPECT_CALL(channel1, mid()).WillRepeatedly(ReturnRef(content_name));
|
|
EXPECT_CALL(channel1, SetFirstPacketReceivedCallback(_));
|
|
EXPECT_CALL(channel1, SetRtpTransport(_)).WillRepeatedly(Return(true));
|
|
|
|
transceiver.SetChannel(&channel1, [&](const std::string& mid) {
|
|
EXPECT_EQ(mid, content_name);
|
|
return nullptr;
|
|
});
|
|
EXPECT_EQ(&channel1, transceiver.channel());
|
|
|
|
// Stop the transceiver.
|
|
transceiver.StopInternal();
|
|
EXPECT_EQ(&channel1, transceiver.channel());
|
|
|
|
cricket::MockChannelInterface channel2;
|
|
EXPECT_CALL(channel2, media_type())
|
|
.WillRepeatedly(Return(cricket::MediaType::MEDIA_TYPE_AUDIO));
|
|
|
|
// Channel can no longer be set, so this call should be a no-op.
|
|
transceiver.SetChannel(&channel2, [](const std::string&) { return nullptr; });
|
|
EXPECT_EQ(&channel1, transceiver.channel());
|
|
|
|
// Clear the current channel before `transceiver` goes out of scope.
|
|
EXPECT_CALL(channel1, SetFirstPacketReceivedCallback(_));
|
|
EXPECT_CALL(cm, DestroyChannel(&channel1)).WillRepeatedly(testing::Return());
|
|
transceiver.SetChannel(nullptr, nullptr);
|
|
}
|
|
|
|
// Checks that a channel can be unset on a stopped `RtpTransceiver`
|
|
TEST(RtpTransceiverTest, CanUnsetChannelOnStoppedTransceiver) {
|
|
ChannelManagerForTest cm;
|
|
const std::string content_name("my_mid");
|
|
RtpTransceiver transceiver(cricket::MediaType::MEDIA_TYPE_VIDEO, &cm);
|
|
cricket::MockChannelInterface channel;
|
|
EXPECT_CALL(channel, media_type())
|
|
.WillRepeatedly(Return(cricket::MediaType::MEDIA_TYPE_VIDEO));
|
|
EXPECT_CALL(channel, mid()).WillRepeatedly(ReturnRef(content_name));
|
|
EXPECT_CALL(channel, SetFirstPacketReceivedCallback(_))
|
|
.WillRepeatedly(testing::Return());
|
|
EXPECT_CALL(channel, SetRtpTransport(_)).WillRepeatedly(Return(true));
|
|
EXPECT_CALL(cm, DestroyChannel(&channel)).WillRepeatedly(testing::Return());
|
|
|
|
transceiver.SetChannel(&channel, [&](const std::string& mid) {
|
|
EXPECT_EQ(mid, content_name);
|
|
return nullptr;
|
|
});
|
|
EXPECT_EQ(&channel, transceiver.channel());
|
|
|
|
// Stop the transceiver.
|
|
transceiver.StopInternal();
|
|
EXPECT_EQ(&channel, transceiver.channel());
|
|
|
|
// Set the channel to `nullptr`.
|
|
transceiver.SetChannel(nullptr, nullptr);
|
|
EXPECT_EQ(nullptr, transceiver.channel());
|
|
}
|
|
|
|
class RtpTransceiverUnifiedPlanTest : public ::testing::Test {
|
|
public:
|
|
RtpTransceiverUnifiedPlanTest()
|
|
: transceiver_(RtpSenderProxyWithInternal<RtpSenderInternal>::Create(
|
|
rtc::Thread::Current(),
|
|
sender_),
|
|
RtpReceiverProxyWithInternal<RtpReceiverInternal>::Create(
|
|
rtc::Thread::Current(),
|
|
rtc::Thread::Current(),
|
|
receiver_),
|
|
&channel_manager_,
|
|
channel_manager_.GetSupportedAudioRtpHeaderExtensions(),
|
|
/* on_negotiation_needed= */ [] {}) {}
|
|
|
|
static rtc::scoped_refptr<MockRtpReceiverInternal> MockReceiver() {
|
|
auto receiver = rtc::make_ref_counted<MockRtpReceiverInternal>();
|
|
EXPECT_CALL(*receiver.get(), media_type())
|
|
.WillRepeatedly(Return(cricket::MediaType::MEDIA_TYPE_AUDIO));
|
|
return receiver;
|
|
}
|
|
|
|
static rtc::scoped_refptr<MockRtpSenderInternal> MockSender() {
|
|
auto sender = rtc::make_ref_counted<MockRtpSenderInternal>();
|
|
EXPECT_CALL(*sender.get(), media_type())
|
|
.WillRepeatedly(Return(cricket::MediaType::MEDIA_TYPE_AUDIO));
|
|
return sender;
|
|
}
|
|
|
|
rtc::scoped_refptr<MockRtpReceiverInternal> receiver_ = MockReceiver();
|
|
rtc::scoped_refptr<MockRtpSenderInternal> sender_ = MockSender();
|
|
ChannelManagerForTest channel_manager_;
|
|
RtpTransceiver transceiver_;
|
|
};
|
|
|
|
// Basic tests for Stop()
|
|
TEST_F(RtpTransceiverUnifiedPlanTest, StopSetsDirection) {
|
|
EXPECT_CALL(*receiver_.get(), StopAndEndTrack());
|
|
EXPECT_CALL(*sender_.get(), SetTransceiverAsStopped());
|
|
EXPECT_CALL(*sender_.get(), Stop());
|
|
|
|
EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver_.direction());
|
|
EXPECT_FALSE(transceiver_.current_direction());
|
|
transceiver_.StopStandard();
|
|
EXPECT_EQ(RtpTransceiverDirection::kStopped, transceiver_.direction());
|
|
EXPECT_FALSE(transceiver_.current_direction());
|
|
transceiver_.StopTransceiverProcedure();
|
|
EXPECT_TRUE(transceiver_.current_direction());
|
|
EXPECT_EQ(RtpTransceiverDirection::kStopped, transceiver_.direction());
|
|
EXPECT_EQ(RtpTransceiverDirection::kStopped,
|
|
*transceiver_.current_direction());
|
|
}
|
|
|
|
class RtpTransceiverTestForHeaderExtensions : public ::testing::Test {
|
|
public:
|
|
RtpTransceiverTestForHeaderExtensions()
|
|
: extensions_(
|
|
{RtpHeaderExtensionCapability("uri1",
|
|
1,
|
|
RtpTransceiverDirection::kSendOnly),
|
|
RtpHeaderExtensionCapability("uri2",
|
|
2,
|
|
RtpTransceiverDirection::kRecvOnly),
|
|
RtpHeaderExtensionCapability(RtpExtension::kMidUri,
|
|
3,
|
|
RtpTransceiverDirection::kSendRecv),
|
|
RtpHeaderExtensionCapability(RtpExtension::kVideoRotationUri,
|
|
4,
|
|
RtpTransceiverDirection::kSendRecv)}),
|
|
transceiver_(RtpSenderProxyWithInternal<RtpSenderInternal>::Create(
|
|
rtc::Thread::Current(),
|
|
sender_),
|
|
RtpReceiverProxyWithInternal<RtpReceiverInternal>::Create(
|
|
rtc::Thread::Current(),
|
|
rtc::Thread::Current(),
|
|
receiver_),
|
|
&channel_manager_,
|
|
extensions_,
|
|
/* on_negotiation_needed= */ [] {}) {}
|
|
|
|
static rtc::scoped_refptr<MockRtpReceiverInternal> MockReceiver() {
|
|
auto receiver = rtc::make_ref_counted<MockRtpReceiverInternal>();
|
|
EXPECT_CALL(*receiver.get(), media_type())
|
|
.WillRepeatedly(Return(cricket::MediaType::MEDIA_TYPE_AUDIO));
|
|
return receiver;
|
|
}
|
|
|
|
static rtc::scoped_refptr<MockRtpSenderInternal> MockSender() {
|
|
auto sender = rtc::make_ref_counted<MockRtpSenderInternal>();
|
|
EXPECT_CALL(*sender.get(), media_type())
|
|
.WillRepeatedly(Return(cricket::MediaType::MEDIA_TYPE_AUDIO));
|
|
return sender;
|
|
}
|
|
|
|
void ClearChannel(cricket::MockChannelInterface& mock_channel) {
|
|
EXPECT_CALL(*sender_.get(), SetMediaChannel(nullptr));
|
|
EXPECT_CALL(*receiver_.get(), Stop());
|
|
EXPECT_CALL(mock_channel, SetFirstPacketReceivedCallback(_));
|
|
EXPECT_CALL(channel_manager_, DestroyChannel(&mock_channel))
|
|
.WillRepeatedly(testing::Return());
|
|
transceiver_.SetChannel(nullptr, nullptr);
|
|
}
|
|
|
|
rtc::scoped_refptr<MockRtpReceiverInternal> receiver_ = MockReceiver();
|
|
rtc::scoped_refptr<MockRtpSenderInternal> sender_ = MockSender();
|
|
|
|
ChannelManagerForTest channel_manager_;
|
|
std::vector<RtpHeaderExtensionCapability> extensions_;
|
|
RtpTransceiver transceiver_;
|
|
};
|
|
|
|
TEST_F(RtpTransceiverTestForHeaderExtensions, OffersChannelManagerList) {
|
|
EXPECT_CALL(*receiver_.get(), StopAndEndTrack());
|
|
EXPECT_CALL(*sender_.get(), SetTransceiverAsStopped());
|
|
EXPECT_CALL(*sender_.get(), Stop());
|
|
|
|
EXPECT_EQ(transceiver_.HeaderExtensionsToOffer(), extensions_);
|
|
}
|
|
|
|
TEST_F(RtpTransceiverTestForHeaderExtensions, ModifiesDirection) {
|
|
EXPECT_CALL(*receiver_.get(), StopAndEndTrack());
|
|
EXPECT_CALL(*sender_.get(), SetTransceiverAsStopped());
|
|
EXPECT_CALL(*sender_.get(), Stop());
|
|
|
|
auto modified_extensions = extensions_;
|
|
modified_extensions[0].direction = RtpTransceiverDirection::kSendOnly;
|
|
EXPECT_TRUE(
|
|
transceiver_.SetOfferedRtpHeaderExtensions(modified_extensions).ok());
|
|
EXPECT_EQ(transceiver_.HeaderExtensionsToOffer(), modified_extensions);
|
|
modified_extensions[0].direction = RtpTransceiverDirection::kRecvOnly;
|
|
EXPECT_TRUE(
|
|
transceiver_.SetOfferedRtpHeaderExtensions(modified_extensions).ok());
|
|
EXPECT_EQ(transceiver_.HeaderExtensionsToOffer(), modified_extensions);
|
|
modified_extensions[0].direction = RtpTransceiverDirection::kSendRecv;
|
|
EXPECT_TRUE(
|
|
transceiver_.SetOfferedRtpHeaderExtensions(modified_extensions).ok());
|
|
EXPECT_EQ(transceiver_.HeaderExtensionsToOffer(), modified_extensions);
|
|
modified_extensions[0].direction = RtpTransceiverDirection::kInactive;
|
|
EXPECT_TRUE(
|
|
transceiver_.SetOfferedRtpHeaderExtensions(modified_extensions).ok());
|
|
EXPECT_EQ(transceiver_.HeaderExtensionsToOffer(), modified_extensions);
|
|
}
|
|
|
|
TEST_F(RtpTransceiverTestForHeaderExtensions, AcceptsStoppedExtension) {
|
|
EXPECT_CALL(*receiver_.get(), StopAndEndTrack());
|
|
EXPECT_CALL(*sender_.get(), SetTransceiverAsStopped());
|
|
EXPECT_CALL(*sender_.get(), Stop());
|
|
|
|
auto modified_extensions = extensions_;
|
|
modified_extensions[0].direction = RtpTransceiverDirection::kStopped;
|
|
EXPECT_TRUE(
|
|
transceiver_.SetOfferedRtpHeaderExtensions(modified_extensions).ok());
|
|
EXPECT_EQ(transceiver_.HeaderExtensionsToOffer(), modified_extensions);
|
|
}
|
|
|
|
TEST_F(RtpTransceiverTestForHeaderExtensions, RejectsUnsupportedExtension) {
|
|
EXPECT_CALL(*receiver_.get(), StopAndEndTrack());
|
|
EXPECT_CALL(*sender_.get(), SetTransceiverAsStopped());
|
|
EXPECT_CALL(*sender_.get(), Stop());
|
|
|
|
std::vector<RtpHeaderExtensionCapability> modified_extensions(
|
|
{RtpHeaderExtensionCapability("uri3", 1,
|
|
RtpTransceiverDirection::kSendRecv)});
|
|
EXPECT_THAT(transceiver_.SetOfferedRtpHeaderExtensions(modified_extensions),
|
|
Property(&RTCError::type, RTCErrorType::UNSUPPORTED_PARAMETER));
|
|
EXPECT_EQ(transceiver_.HeaderExtensionsToOffer(), extensions_);
|
|
}
|
|
|
|
TEST_F(RtpTransceiverTestForHeaderExtensions,
|
|
RejectsStoppedMandatoryExtensions) {
|
|
EXPECT_CALL(*receiver_.get(), StopAndEndTrack());
|
|
EXPECT_CALL(*sender_.get(), SetTransceiverAsStopped());
|
|
EXPECT_CALL(*sender_.get(), Stop());
|
|
|
|
std::vector<RtpHeaderExtensionCapability> modified_extensions = extensions_;
|
|
// Attempting to stop the mandatory MID extension.
|
|
modified_extensions[2].direction = RtpTransceiverDirection::kStopped;
|
|
EXPECT_THAT(transceiver_.SetOfferedRtpHeaderExtensions(modified_extensions),
|
|
Property(&RTCError::type, RTCErrorType::INVALID_MODIFICATION));
|
|
EXPECT_EQ(transceiver_.HeaderExtensionsToOffer(), extensions_);
|
|
modified_extensions = extensions_;
|
|
// Attempting to stop the mandatory video orientation extension.
|
|
modified_extensions[3].direction = RtpTransceiverDirection::kStopped;
|
|
EXPECT_THAT(transceiver_.SetOfferedRtpHeaderExtensions(modified_extensions),
|
|
Property(&RTCError::type, RTCErrorType::INVALID_MODIFICATION));
|
|
EXPECT_EQ(transceiver_.HeaderExtensionsToOffer(), extensions_);
|
|
}
|
|
|
|
TEST_F(RtpTransceiverTestForHeaderExtensions,
|
|
NoNegotiatedHdrExtsWithoutChannel) {
|
|
EXPECT_CALL(*receiver_.get(), StopAndEndTrack());
|
|
EXPECT_CALL(*sender_.get(), SetTransceiverAsStopped());
|
|
EXPECT_CALL(*sender_.get(), Stop());
|
|
EXPECT_THAT(transceiver_.HeaderExtensionsNegotiated(), ElementsAre());
|
|
}
|
|
|
|
TEST_F(RtpTransceiverTestForHeaderExtensions,
|
|
NoNegotiatedHdrExtsWithChannelWithoutNegotiation) {
|
|
const std::string content_name("my_mid");
|
|
EXPECT_CALL(*receiver_.get(), SetMediaChannel(_));
|
|
EXPECT_CALL(*receiver_.get(), StopAndEndTrack());
|
|
EXPECT_CALL(*sender_.get(), SetMediaChannel(_));
|
|
EXPECT_CALL(*sender_.get(), SetTransceiverAsStopped());
|
|
EXPECT_CALL(*sender_.get(), Stop());
|
|
cricket::MockChannelInterface mock_channel;
|
|
EXPECT_CALL(mock_channel, SetFirstPacketReceivedCallback(_));
|
|
EXPECT_CALL(mock_channel, media_type())
|
|
.WillRepeatedly(Return(cricket::MediaType::MEDIA_TYPE_AUDIO));
|
|
EXPECT_CALL(mock_channel, media_channel()).WillRepeatedly(Return(nullptr));
|
|
EXPECT_CALL(mock_channel, mid()).WillRepeatedly(ReturnRef(content_name));
|
|
EXPECT_CALL(mock_channel, SetRtpTransport(_)).WillRepeatedly(Return(true));
|
|
transceiver_.SetChannel(&mock_channel,
|
|
[](const std::string&) { return nullptr; });
|
|
EXPECT_THAT(transceiver_.HeaderExtensionsNegotiated(), ElementsAre());
|
|
|
|
ClearChannel(mock_channel);
|
|
}
|
|
|
|
TEST_F(RtpTransceiverTestForHeaderExtensions, ReturnsNegotiatedHdrExts) {
|
|
const std::string content_name("my_mid");
|
|
EXPECT_CALL(*receiver_.get(), SetMediaChannel(_));
|
|
EXPECT_CALL(*receiver_.get(), StopAndEndTrack());
|
|
EXPECT_CALL(*sender_.get(), SetMediaChannel(_));
|
|
EXPECT_CALL(*sender_.get(), SetTransceiverAsStopped());
|
|
EXPECT_CALL(*sender_.get(), Stop());
|
|
|
|
cricket::MockChannelInterface mock_channel;
|
|
EXPECT_CALL(mock_channel, SetFirstPacketReceivedCallback(_));
|
|
EXPECT_CALL(mock_channel, media_type())
|
|
.WillRepeatedly(Return(cricket::MediaType::MEDIA_TYPE_AUDIO));
|
|
EXPECT_CALL(mock_channel, media_channel()).WillRepeatedly(Return(nullptr));
|
|
EXPECT_CALL(mock_channel, mid()).WillRepeatedly(ReturnRef(content_name));
|
|
EXPECT_CALL(mock_channel, SetRtpTransport(_)).WillRepeatedly(Return(true));
|
|
|
|
cricket::RtpHeaderExtensions extensions = {webrtc::RtpExtension("uri1", 1),
|
|
webrtc::RtpExtension("uri2", 2)};
|
|
cricket::AudioContentDescription description;
|
|
description.set_rtp_header_extensions(extensions);
|
|
transceiver_.OnNegotiationUpdate(SdpType::kAnswer, &description);
|
|
|
|
transceiver_.SetChannel(&mock_channel,
|
|
[](const std::string&) { return nullptr; });
|
|
EXPECT_THAT(transceiver_.HeaderExtensionsNegotiated(),
|
|
ElementsAre(RtpHeaderExtensionCapability(
|
|
"uri1", 1, RtpTransceiverDirection::kSendRecv),
|
|
RtpHeaderExtensionCapability(
|
|
"uri2", 2, RtpTransceiverDirection::kSendRecv)));
|
|
|
|
ClearChannel(mock_channel);
|
|
}
|
|
|
|
TEST_F(RtpTransceiverTestForHeaderExtensions,
|
|
ReturnsNegotiatedHdrExtsSecondTime) {
|
|
EXPECT_CALL(*receiver_.get(), StopAndEndTrack());
|
|
EXPECT_CALL(*sender_.get(), SetTransceiverAsStopped());
|
|
EXPECT_CALL(*sender_.get(), Stop());
|
|
|
|
cricket::RtpHeaderExtensions extensions = {webrtc::RtpExtension("uri1", 1),
|
|
webrtc::RtpExtension("uri2", 2)};
|
|
cricket::AudioContentDescription description;
|
|
description.set_rtp_header_extensions(extensions);
|
|
transceiver_.OnNegotiationUpdate(SdpType::kAnswer, &description);
|
|
|
|
EXPECT_THAT(transceiver_.HeaderExtensionsNegotiated(),
|
|
ElementsAre(RtpHeaderExtensionCapability(
|
|
"uri1", 1, RtpTransceiverDirection::kSendRecv),
|
|
RtpHeaderExtensionCapability(
|
|
"uri2", 2, RtpTransceiverDirection::kSendRecv)));
|
|
|
|
extensions = {webrtc::RtpExtension("uri3", 4),
|
|
webrtc::RtpExtension("uri5", 6)};
|
|
description.set_rtp_header_extensions(extensions);
|
|
transceiver_.OnNegotiationUpdate(SdpType::kAnswer, &description);
|
|
|
|
EXPECT_THAT(transceiver_.HeaderExtensionsNegotiated(),
|
|
ElementsAre(RtpHeaderExtensionCapability(
|
|
"uri3", 4, RtpTransceiverDirection::kSendRecv),
|
|
RtpHeaderExtensionCapability(
|
|
"uri5", 6, RtpTransceiverDirection::kSendRecv)));
|
|
}
|
|
|
|
} // namespace webrtc
|