b8781796d4
This reverts commit 39a31afb77e3ce5c4ff53b8bab06364712cae7ce. Reason for revert: Will cause RTCP Target bitrate messages to not be sent unless BWE changes. Original change's description: > Refactor reporting of VideoBitrateAllocation > > Move reporting of target bitrate to just after the encoder has been > updated. > > Bug: webrtc:12000 > Change-Id: I3e7c5bd44c2f64e5f7e32d6451861b80e0b779ca > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186041 > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Reviewed-by: Erik Språng <sprang@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32275} TBR=sprang@webrtc.org,perkj@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:12000 Change-Id: Icf21e6ae28dc17c61b9243c037ffef9b623894ee Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186945 Reviewed-by: Per Kjellander <perkj@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32337}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.