ae3df54f67
This changes the MIDs that are generated if calling createOffer twice without setting a local or remote description. Managing the list of seen mids is now deferred to a helper object. This is a reland of 1c376760d83119166407913b965e2e40e9d0c5f6. > Bug: None > Change-Id: I3440d62129884ae49aefd18e03c3a55ae096d923 > Reviewed-on: https://webrtc-review.googlesource.com/c/116021 > Commit-Queue: Amit Hilbuch <amithi@webrtc.org> > Reviewed-by: Steve Anton <steveanton@webrtc.org> > Reviewed-by: Seth Hampson <shampson@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26130} Bug: None Change-Id: Ic8b07a252869f67a476e3af84b8072b7a130f7fd Reviewed-on: https://webrtc-review.googlesource.com/c/116381 Reviewed-by: Steve Anton <steveanton@webrtc.org> Commit-Queue: Amit Hilbuch <amithi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26151}
111 lines
3.7 KiB
C++
111 lines
3.7 KiB
C++
/*
|
|
* Copyright 2018 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "algorithm"
|
|
#include "string"
|
|
#include "vector"
|
|
|
|
#include "api/array_view.h"
|
|
#include "pc/unique_id_generator.h"
|
|
#include "rtc_base/gunit.h"
|
|
#include "rtc_base/helpers.h"
|
|
#include "test/gmock.h"
|
|
|
|
using ::testing::IsEmpty;
|
|
using ::testing::Test;
|
|
|
|
namespace webrtc {
|
|
|
|
template <typename Generator>
|
|
class UniqueIdGeneratorTest : public Test {};
|
|
|
|
using test_types = ::testing::Types<UniqueNumberGenerator<uint8_t>,
|
|
UniqueNumberGenerator<uint16_t>,
|
|
UniqueNumberGenerator<uint32_t>,
|
|
UniqueRandomIdGenerator,
|
|
UniqueStringGenerator>;
|
|
|
|
TYPED_TEST_CASE(UniqueIdGeneratorTest, test_types);
|
|
|
|
TYPED_TEST(UniqueIdGeneratorTest, ElementsDoNotRepeat) {
|
|
typedef TypeParam Generator;
|
|
const size_t num_elements = 255;
|
|
Generator generator;
|
|
std::vector<typename Generator::value_type> values;
|
|
for (size_t i = 0; i < num_elements; i++) {
|
|
values.push_back(generator());
|
|
}
|
|
|
|
EXPECT_EQ(num_elements, values.size());
|
|
// Use a set to check uniqueness.
|
|
std::set<typename Generator::value_type> set(values.begin(), values.end());
|
|
EXPECT_EQ(values.size(), set.size()) << "Returned values were not unique.";
|
|
}
|
|
|
|
TYPED_TEST(UniqueIdGeneratorTest, KnownElementsAreNotGenerated) {
|
|
typedef TypeParam Generator;
|
|
const size_t num_elements = 100;
|
|
rtc::InitRandom(0);
|
|
Generator generator1;
|
|
std::vector<typename Generator::value_type> known_values;
|
|
for (size_t i = 0; i < num_elements; i++) {
|
|
known_values.push_back(generator1());
|
|
}
|
|
EXPECT_EQ(num_elements, known_values.size());
|
|
|
|
rtc::InitRandom(0);
|
|
Generator generator2(known_values);
|
|
|
|
std::vector<typename Generator::value_type> values;
|
|
for (size_t i = 0; i < num_elements; i++) {
|
|
values.push_back(generator2());
|
|
}
|
|
EXPECT_THAT(values, ::testing::SizeIs(num_elements));
|
|
std::sort(values.begin(), values.end());
|
|
std::sort(known_values.begin(), known_values.end());
|
|
std::vector<typename Generator::value_type> intersection;
|
|
std::set_intersection(values.begin(), values.end(), known_values.begin(),
|
|
known_values.end(), std::back_inserter(intersection));
|
|
EXPECT_THAT(intersection, IsEmpty());
|
|
}
|
|
|
|
TYPED_TEST(UniqueIdGeneratorTest, AddedElementsAreNotGenerated) {
|
|
typedef TypeParam Generator;
|
|
const size_t num_elements = 100;
|
|
rtc::InitRandom(0);
|
|
Generator generator1;
|
|
std::vector<typename Generator::value_type> known_values;
|
|
for (size_t i = 0; i < num_elements; i++) {
|
|
known_values.push_back(generator1());
|
|
}
|
|
EXPECT_EQ(num_elements, known_values.size());
|
|
|
|
rtc::InitRandom(0);
|
|
Generator generator2;
|
|
|
|
for (typename Generator::value_type value : known_values) {
|
|
generator2.AddKnownId(value);
|
|
}
|
|
|
|
std::vector<typename Generator::value_type> values;
|
|
for (size_t i = 0; i < num_elements; i++) {
|
|
values.push_back(generator2());
|
|
}
|
|
EXPECT_THAT(values, ::testing::SizeIs(num_elements));
|
|
std::sort(values.begin(), values.end());
|
|
std::sort(known_values.begin(), known_values.end());
|
|
std::vector<typename Generator::value_type> intersection;
|
|
std::set_intersection(values.begin(), values.end(), known_values.begin(),
|
|
known_values.end(), std::back_inserter(intersection));
|
|
EXPECT_THAT(intersection, IsEmpty());
|
|
}
|
|
|
|
} // namespace webrtc
|