zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
baffae6ec0012ad4e53cd8549c6faae90f0fb0bb
platform-external-webrtc/audio
History
Mirko Bonadei fc52b912a3 Implicitly suppress //build/config/clang:find_bad_constructs. 
Since there is no way to enable/disable these diagnostics at runtime,
this CL moves the suppression into the rtc_* templates in order to
remove the need to explicitly add the snippet of code needed to
suppress it (currently copy/pasted in 144 locations).

The diagnostic that causes the most problems is the one about "complex
class/struct explicit ctor/dtor" [1] because WebRTC doesn't find
it useful enough.

Other diagnostics are good (for example the one that warns about
using "virtual" instead of "override", but that will be covered by
this clang-tidy check [2]) while others are Chromium related so
they have never triggered.

[1] - https://cs.chromium.org/chromium/src/tools/clang/plugins/FindBadConstructsConsumer.cpp?l=147-167&rcl=b4bebe1aa15dba7ca5fcc6456a81a55665327c3a
[2] - https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html

Bug: webrtc:163
Change-Id: Icbf27efa5b369100a31e6a32df1a0913729b3b34
Reviewed-on: https://webrtc-review.googlesource.com/c/125088
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26918}
2019-03-01 10:18:17 +00:00
..
test
Reland "Delete test/constants.h"
2019-02-19 08:51:20 +00:00
utility
Implicitly suppress //build/config/clang:find_bad_constructs.
2019-03-01 10:18:17 +00:00
audio_level.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
audio_level.h
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
audio_receive_stream_unittest.cc
Add some missing includes and dependencies.
2019-01-18 15:30:26 +00:00
audio_receive_stream.cc
Propagate base minimum delay to audio_receiver_stream
2019-02-06 11:07:42 +00:00
audio_receive_stream.h
Propagate base minimum delay to audio_receiver_stream
2019-02-06 11:07:42 +00:00
audio_send_stream_tests.cc
Reland "Delete test/constants.h"
2019-02-19 08:51:20 +00:00
audio_send_stream_unittest.cc
Reland "Always offer transport sequence number header extension for audio""
2019-02-15 10:57:38 +00:00
audio_send_stream.cc
Reland "Always offer transport sequence number header extension for audio""
2019-02-15 10:57:38 +00:00
audio_send_stream.h
Make AudioSendStream to be OverheadObserver
2019-02-05 00:25:12 +00:00
audio_state_unittest.cc
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
audio_state.cc
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
audio_state.h
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
audio_transport_impl.cc
Receive-side ready for multiple channels.
2019-01-29 12:43:23 +00:00
audio_transport_impl.h
Remove rtc_base/scoped_ref_ptr.h.
2019-01-25 20:29:58 +00:00
BUILD.gn
Implicitly suppress //build/config/clang:find_bad_constructs.
2019-03-01 10:18:17 +00:00
channel_receive.cc
Revert "Add Sender and Receiver interfaces for MediaTransport audio"
2019-02-18 09:52:40 +00:00
channel_receive.h
Propagate base minimum delay to audio_receiver_stream
2019-02-06 11:07:42 +00:00
channel_send.cc
Fix: Ignore empty frames in Media Transport
2019-02-28 15:52:51 +00:00
channel_send.h
Adds CallEncoder to ChannelSend.
2019-02-13 15:01:53 +00:00
conversion.h
Fixing WebRTC after moving from src/webrtc to src/
2017-09-15 05:02:56 +00:00
DEPS
Move remaining traces of VoiceEngine
2018-01-17 13:27:47 +00:00
mock_voe_channel_proxy.h
Adds CallEncoder to ChannelSend.
2019-02-13 15:01:53 +00:00
null_audio_poller.cc
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
null_audio_poller.h
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
OWNERS
…
remix_resample_unittest.cc
Reformat the WebRTC code base
2018-06-19 14:00:39 +00:00
remix_resample.cc
Receive-side ready for multiple channels.
2019-01-29 12:43:23 +00:00
remix_resample.h
Remove dependencies on modules:module_api from AudioProcessing.
2018-04-12 22:05:27 +00:00
transport_feedback_packet_loss_tracker_unittest.cc
Stop using Googletest legacy APIs.
2019-01-31 13:23:33 +00:00
transport_feedback_packet_loss_tracker.cc
[Cleanup] Add missing #include. Remove useless ones.
2018-10-23 11:32:56 +00:00
transport_feedback_packet_loss_tracker.h
Remove clang:find_bad_constructs suppression from call:call.
2018-08-29 11:57:00 +00:00