bedb7a8aea
This reverts commit 0a88ea050cda58de81d624cf2764d46929447ed5. Reason for revert: This CL breaks Chromium's FYI bots (example: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Linux%20Tester/4033). Original change's description: > Reporting of decoding_codec_plc events > > Change-Id: Id71b37244bc98bffaf25131a519127b3d2b86a8f > > Bug: webrtc:10838 > Change-Id: Id71b37244bc98bffaf25131a519127b3d2b86a8f > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147263 > Commit-Queue: Alex Narest <alexnarest@google.com> > Reviewed-by: Magnus Flodman <mflodman@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#28700} TBR=mflodman@webrtc.org,alexnarest@google.com Change-Id: I5e5dd29ee375ba422f79932d4b8c3fd028a53db4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10838 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147269 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28707}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.