9560d7dc58
For the automatic content type detection we need to know if the update rect is trusted or just not available. Currently we only care if it's not empty, so in case of no update rect available, full frame resolution was set as a changed region. This CL makes the update_rect field optional but should be a no-op in the current code, as absence of update_rect is treated as a full update via a new getter method |update_rect_or_full_frame()|. Bug: webrtc:11058 Change-Id: I913545b71ac2fc845861549ac34eb1b630012109 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158673 Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29654}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.