
Use AdaptDown/AdaptUp instead of ScaleDown/ScaleUp, since we may want to adapt using other means than resolution. Also, extend vie_encoder with unit test that actually uses frames scaled to resolution as determined by VideoAdapter, since that seems to be the default implementation. BUG=webrtc:4172 Review-Url: https://codereview.webrtc.org/2652893015 Cr-Commit-Position: refs/heads/master@{#16402}
179 lines
5.5 KiB
C++
179 lines
5.5 KiB
C++
/*
|
|
* Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "webrtc/modules/video_coding/utility/quality_scaler.h"
|
|
|
|
#include <memory>
|
|
|
|
#include "webrtc/base/event.h"
|
|
#include "webrtc/base/task_queue.h"
|
|
#include "webrtc/test/gmock.h"
|
|
#include "webrtc/test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
namespace {
|
|
static const int kFramerate = 30;
|
|
static const int kLowQp = 15;
|
|
static const int kLowQpThreshold = 18;
|
|
static const int kHighQp = 40;
|
|
static const size_t kDefaultTimeoutMs = 150;
|
|
} // namespace
|
|
|
|
class MockAdaptationObserver : public AdaptationObserverInterface {
|
|
public:
|
|
MockAdaptationObserver() : event(false, false) {}
|
|
virtual ~MockAdaptationObserver() {}
|
|
|
|
void AdaptUp(AdaptReason r) override {
|
|
adapt_up_events_++;
|
|
event.Set();
|
|
}
|
|
void AdaptDown(AdaptReason r) override {
|
|
adapt_down_events_++;
|
|
event.Set();
|
|
}
|
|
|
|
rtc::Event event;
|
|
int adapt_up_events_ = 0;
|
|
int adapt_down_events_ = 0;
|
|
};
|
|
|
|
// Pass a lower sampling period to speed up the tests.
|
|
class QualityScalerUnderTest : public QualityScaler {
|
|
public:
|
|
explicit QualityScalerUnderTest(AdaptationObserverInterface* observer,
|
|
VideoEncoder::QpThresholds thresholds)
|
|
: QualityScaler(observer, thresholds, 5) {}
|
|
};
|
|
|
|
class QualityScalerTest : public ::testing::Test {
|
|
protected:
|
|
enum ScaleDirection {
|
|
kKeepScaleAtHighQp,
|
|
kScaleDown,
|
|
kScaleDownAboveHighQp,
|
|
kScaleUp
|
|
};
|
|
|
|
QualityScalerTest()
|
|
: q_(new rtc::TaskQueue("QualityScalerTestQueue")),
|
|
observer_(new MockAdaptationObserver()) {
|
|
rtc::Event event(false, false);
|
|
q_->PostTask([this, &event] {
|
|
qs_ = std::unique_ptr<QualityScaler>(new QualityScalerUnderTest(
|
|
observer_.get(),
|
|
VideoEncoder::QpThresholds(kLowQpThreshold, kHighQp)));
|
|
event.Set();
|
|
});
|
|
EXPECT_TRUE(event.Wait(kDefaultTimeoutMs));
|
|
}
|
|
|
|
~QualityScalerTest() {
|
|
rtc::Event event(false, false);
|
|
q_->PostTask([this, &event] {
|
|
qs_.reset(nullptr);
|
|
event.Set();
|
|
});
|
|
EXPECT_TRUE(event.Wait(kDefaultTimeoutMs));
|
|
}
|
|
|
|
void TriggerScale(ScaleDirection scale_direction) {
|
|
for (int i = 0; i < kFramerate * 5; ++i) {
|
|
switch (scale_direction) {
|
|
case kScaleUp:
|
|
qs_->ReportQP(kLowQp);
|
|
break;
|
|
case kScaleDown:
|
|
qs_->ReportDroppedFrame();
|
|
break;
|
|
case kKeepScaleAtHighQp:
|
|
qs_->ReportQP(kHighQp);
|
|
break;
|
|
case kScaleDownAboveHighQp:
|
|
qs_->ReportQP(kHighQp + 1);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
std::unique_ptr<rtc::TaskQueue> q_;
|
|
std::unique_ptr<QualityScaler> qs_;
|
|
std::unique_ptr<MockAdaptationObserver> observer_;
|
|
};
|
|
|
|
#define DISABLED_TEST(basename, test) TEST_F(basename, DISABLED_##test)
|
|
DISABLED_TEST(QualityScalerTest, DownscalesAfterContinuousFramedrop) {
|
|
q_->PostTask([this] { TriggerScale(kScaleDown); });
|
|
EXPECT_TRUE(observer_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, observer_->adapt_down_events_);
|
|
}
|
|
|
|
DISABLED_TEST(QualityScalerTest, KeepsScaleAtHighQp) {
|
|
q_->PostTask([this] { TriggerScale(kKeepScaleAtHighQp); });
|
|
EXPECT_FALSE(observer_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(0, observer_->adapt_down_events_);
|
|
EXPECT_EQ(0, observer_->adapt_up_events_);
|
|
}
|
|
|
|
DISABLED_TEST(QualityScalerTest, DownscalesAboveHighQp) {
|
|
q_->PostTask([this] { TriggerScale(kScaleDownAboveHighQp); });
|
|
EXPECT_TRUE(observer_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, observer_->adapt_down_events_);
|
|
EXPECT_EQ(0, observer_->adapt_up_events_);
|
|
}
|
|
|
|
DISABLED_TEST(QualityScalerTest, DownscalesAfterTwoThirdsFramedrop) {
|
|
q_->PostTask([this] {
|
|
qs_->ReportDroppedFrame();
|
|
qs_->ReportDroppedFrame();
|
|
qs_->ReportQP(kHighQp);
|
|
});
|
|
EXPECT_TRUE(observer_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, observer_->adapt_down_events_);
|
|
EXPECT_EQ(0, observer_->adapt_up_events_);
|
|
}
|
|
|
|
DISABLED_TEST(QualityScalerTest, DoesNotDownscaleOnNormalQp) {
|
|
q_->PostTask([this] { TriggerScale(kScaleDownAboveHighQp); });
|
|
EXPECT_TRUE(observer_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, observer_->adapt_down_events_);
|
|
EXPECT_EQ(0, observer_->adapt_up_events_);
|
|
}
|
|
|
|
DISABLED_TEST(QualityScalerTest, DoesNotDownscaleAfterHalfFramedrop) {
|
|
q_->PostTask([this] {
|
|
qs_->ReportDroppedFrame();
|
|
qs_->ReportQP(kHighQp);
|
|
});
|
|
EXPECT_FALSE(observer_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(0, observer_->adapt_down_events_);
|
|
EXPECT_EQ(0, observer_->adapt_up_events_);
|
|
}
|
|
|
|
DISABLED_TEST(QualityScalerTest, UpscalesAfterLowQp) {
|
|
q_->PostTask([this] { TriggerScale(kScaleUp); });
|
|
EXPECT_TRUE(observer_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(0, observer_->adapt_down_events_);
|
|
EXPECT_EQ(1, observer_->adapt_up_events_);
|
|
}
|
|
|
|
DISABLED_TEST(QualityScalerTest, ScalesDownAndBackUp) {
|
|
q_->PostTask([this] { TriggerScale(kScaleDown); });
|
|
EXPECT_TRUE(observer_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, observer_->adapt_down_events_);
|
|
EXPECT_EQ(0, observer_->adapt_up_events_);
|
|
q_->PostTask([this] { TriggerScale(kScaleUp); });
|
|
EXPECT_TRUE(observer_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, observer_->adapt_down_events_);
|
|
EXPECT_EQ(1, observer_->adapt_up_events_);
|
|
}
|
|
#undef DISABLED_TEST
|
|
} // namespace webrtc
|