cb8c40138c
This reverts commit c6a65c8866487c6adc0a7bb472d3bad9389501f9. Reason for revert: Breaks downstream due to missing default Original change's description: > Expose can_trickle_ice_candidates on PeerConnection > > Bug: chromium:708484 > Change-Id: I9a40e75066341f0d9f965bd3718bfcb3f0459533 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169450 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Taylor <deadbeef@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#30653} TBR=deadbeef@webrtc.org,hta@webrtc.org Change-Id: Iaa5b977c4237715a8a5127cf167cf6512a3f7059 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:708484 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169540 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30655}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.